Open Bug 1306320 Opened 8 years ago Updated 2 years ago

New find in page highlighting is all over the page

Categories

(Toolkit :: Find Toolbar, defect)

defect

Tracking

()

People

(Reporter: annevk, Unassigned)

References

(Blocks 1 open bug)

Details

+++ This bug was initially created as a clone of Bug #1280978 +++

[Tracking Requested - why for this release]: Significant user-facing perf regression.

STEPS TO REPRODUCE (on Mac):

1)  Load https://drafts.css-houdini.org/worklets/
2)  Hit Cmd+F.
3)  Type "event loop".
4)  Scroll around while looking at the sidebar

EXPECTED RESULTS: Search results are highlighted and don't move around.

ACTUAL RESULTS: Higlights move all over the page.
No longer blocks: 384458
Iteration: 51.1 - Aug 15 → ---
No longer depends on: 1280978, 1281171, 1281421, 1290842, 1290913, 1290914, 1294392
Keywords: meta, regression
Version: 50 Branch → Trunk
I'm not seeing a perf issue, just that the yellow box has trouble keeping up with our scrolling speed. This has to do with the way I implemented this feature and I try to re-position the div as soon as I possibly can.

Now the only way I can improve that perf is to implement the modal highlighting using a different mechanism/ API that'd allow me to style the range outline as if they were inline box elements and keep them in the text frame. This is apparently very hard to make happen, at least that's what I heard from :heycam about a year ago.
Perhaps there have been developments in the interim that'd make this a more feasible scenario, but afaik it's not.
(Please be careful when cloning bugs as it has the potential to spam many people)
The highlights in the sidebar still move around slightly, but always stop at the right position. I can improve things slightly to improve the scrolling speed with many occurrences to highlight, but that's not what this bug is about, really.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.