Closed Bug 1306359 Opened 9 years ago Closed 9 years ago

Stop using Scoped.h NSS types in RTCCertificate.(cpp|h)

Categories

(Core :: WebRTC: Audio/Video, defect, P5)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Details

Attachments

(1 file)

Bug 1306359 - Stop using Scoped.h NSS types in RTCCertificate.(cpp|h).
58 bytes, text/x-review-board-request
mt
: review+
Details
Scoped.h is deprecated in favour of UniquePtr - UniquePtr is standard, and is the long term solution. Scoped.h is essentially bloat and needs to go away.
I'd prefer to use std::unique_ptr<T>, which is what's actually standard. Do we know when that will be approved?
(In reply to Eric Rescorla (:ekr) from comment #1) > I'd prefer to use std::unique_ptr<T>, which is what's actually standard. Do > we know when that will be approved? No, sorry. The last time I saw this topic being discussed, there were still some issues with using it everywhere. If you really want to use std::unique_ptr, I guess we can wait, but note that switching the underlying type of things like UniqueCERTCertificate from UniquePtr to std::unique_ptr was very straightforward and seemed to work fine the last time I tried it.
In that case, I think we should wait.
Sure.
Assignee: cykesiopka.bmo → nobody
Status: ASSIGNED → NEW
Rank: 55
Priority: -- → P5
I switched the UniqueX types over to std::unique_ptr in Bug 1308132.
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Comment on attachment 8801763 [details] Bug 1306359 - Stop using Scoped.h NSS types in RTCCertificate.(cpp|h). https://reviewboard.mozilla.org/r/86414/#review88716 I rebased this on top of the changes in Bug 1311383. The interdiff is weird, so I recommend not looking at it.
Comment on attachment 8801763 [details] Bug 1306359 - Stop using Scoped.h NSS types in RTCCertificate.(cpp|h). https://reviewboard.mozilla.org/r/86414/#review99156
Attachment #8801763 - Flags: review?(martin.thomson) → review+
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d840edb5b3ec Stop using Scoped.h NSS types in RTCCertificate.(cpp|h). r=mt
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d840edb5b3ec
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: