1306873 - Firefox sending unannounced SSRCs in simulcast, may not be sending RID

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

Bug 1288904 was too aggressive in adding RID support to the SDP header extensions --  added it to audio streams (not useful) as well as to video streams when simulcast/RID wasn't negotiated.

This patch was developed as part of the update to webrtc branch 49 import, and ported back to trunk, like the patch in bug 1288904.  Nico wrote the patch, and I reviewed it and resolved nits (plus checked jsep_session_unittests).

The other patch here it the extmap direction support patch from the 49 update, which was reviewed by bwc in Bug 1250356.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: extmap direction support and cleanup

Also removes RID support from audio

MozReview-Commit-ID: 28pmbvm4kw4

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: only offer RID for video, and only if simulcast is being negotiated

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8796857 [details] [diff] [review]
extmap direction support and cleanup

r=bwc

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8796858 [details] [diff] [review]
only offer RID for video, and only if simulcast is being negotiated

r=jesup; I resolved nits in the original patch from Nico - it was still added RID to audio streams, and didn't adjust the constants in jsep_session_unittest

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e71268c4cc73
extmap direction support and cleanup r=bwc
https://hg.mozilla.org/integration/mozilla-inbound/rev/1378de3d013b
only offer RID for video, and only if simulcast is being negotiated r=jesup

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e71268c4cc73
https://hg.mozilla.org/mozilla-central/rev/1378de3d013b

Comment 7

[Daniel Holbert [:dholbert]]

The second commit here caused a new build warning (for the single-case switch statement) - I filed bug 1307155 for that.