Closed
Bug 1306906
Opened 8 years ago
Closed 8 years ago
[css-grid] Use the first baseline as the Grid container baseline
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(2 files)
|
2.90 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
|
15.39 KB,
patch
|
Details | Diff | Splinter Review |
I forgot to update the baseline patches in bug 1151204 per bug 1280380 (the CSSWG resolution there happened after I initially implemented the grid container baselines).
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8796897 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b70a9cfd9c81&exclusion_profile=false
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8796897 [details] [diff] [review] fix Review of attachment 8796897 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8796897 -
Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/52948479ec32 [css-grid] Get the relevant baseline from the grid item for the basline group. r=dholbert https://hg.mozilla.org/integration/mozilla-inbound/rev/b153f7df610e [css-grid] Add/tweak grid container baseline reftests.
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/52948479ec32 https://hg.mozilla.org/mozilla-central/rev/b153f7df610e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•