test_css-properties-db.js will permafail from "mask-image" when Gecko 51 merges to beta on November 7th

RESOLVED FIXED in Firefox 51

Status

()

Firefox
Developer Tools: Framework
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: philor, Assigned: gregtatum)

Tracking

51 Branch
Firefox 52
Points:
---

Firefox Tracking Flags

(firefox51 fixed, firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Greg, what's on your schedule for the morning of November 7th, other than "updating a mozilla-beta tree and pushing a new generate-css-db 'on a CLOSED TREE'"?

https://treeherder.mozilla.org/logviewer.html#?job_id=28371802&repo=try
(Reporter)

Updated

2 years ago
Blocks: 1307010
(Assignee)

Comment 1

2 years ago
A
Assignee: nobody → gtatum
(Assignee)

Comment 2

2 years ago
Is there any documentation anywhere on how to build Aurora as Beta? I'm not finding any docs when I'm searching, and sleuthing around in https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/merge_day/gecko_migration.py isn't getting me anywhere.

I thought my preference checking would fix this, but apparently not.
Flags: needinfo?(philringnalda)
(Reporter)

Comment 3

2 years ago
It's nothing anywhere near as formal and supported as that: what you do is know who is currently doing it, hope they aren't screwing up the patch to do it too badly, and search for their try pushes, like https://treeherder.mozilla.org/#/jobs?repo=try&author=philringnalda@gmail.com (though you need to go a little further than the last 10, to get to https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e67649a365cedb0c2c79e575f4d4f37b7fa551d), to borrow their patch.

For your purposes, you could probably simplify it down to just removing the "a2" from the version number, https://hg.mozilla.org/try/rev/7e67649a365cedb0c2c79e575f4d4f37b7fa551d#l19.12 and the two in browser/ just in case they matter, since that's what sets RELEASE_BUILD, and that ifdef is the reason why nothing to do with prefs would save you, because masking made the unfortunate decision to ifdef instead of pref it off on beta/release.
Flags: needinfo?(philringnalda)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8797774 [details]
Bug 1307009 - Restrict the CSS properties db test to only nightly;

https://reviewboard.mozilla.org/r/83382/#review81940

Looks reasonable.  Thanks.
Attachment #8797774 - Flags: review?(ttromey) → review+

Comment 8

2 years ago
mozreview-review
Comment on attachment 8797775 [details]
Bug 1307009 - Remove caching optimization;

https://reviewboard.mozilla.org/r/83384/#review81944

Thank you.  I think it's for the best.
Attachment #8797775 - Flags: review?(ttromey) → review+
(Assignee)

Updated

2 years ago
Keywords: leave-open

Comment 9

2 years ago
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4009150bc53b
Restrict the CSS properties db test to only nightly; r=tromey
https://hg.mozilla.org/integration/autoland/rev/4fa21c0bcb63
Remove caching optimization; r=tromey
(Assignee)

Updated

2 years ago
Keywords: leave-open
Backed out for devtools failing in browser_styleeditor_autocomplete.js:

https://hg.mozilla.org/integration/autoland/rev/436994fa49059a5645920f9369ef55e7666dbda5
https://hg.mozilla.org/integration/autoland/rev/d7f47065d28a39cc007a9fd72582d790bcd6e912

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4fa21c0bcb63fa2b46454ea38767d3239d31b712
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=4531990&repo=autoland

[task 2016-10-05T15:05:57.013648Z] 15:05:57     INFO -  330 INFO TEST-PASS | devtools/client/styleeditor/test/browser_styleeditor_autocomplete.js | Popup is open for index 28 -
[task 2016-10-05T15:05:57.015436Z] 15:05:57     INFO -  331 INFO TEST-UNEXPECTED-FAIL | devtools/client/styleeditor/test/browser_styleeditor_autocomplete.js | Correct total suggestions for index 28 - Got 13, expected 14
[task 2016-10-05T15:05:57.017046Z] 15:05:57     INFO -  Stack trace:
[task 2016-10-05T15:05:57.019206Z] 15:05:57     INFO -  chrome://mochikit/content/browser-test.js:test_is:954
[task 2016-10-05T15:05:57.021152Z] 15:05:57     INFO -  chrome://mochitests/content/browser/devtools/client/styleeditor/test/browser_styleeditor_autocomplete.js:checkState/<:160
[task 2016-10-05T15:05:57.024123Z] 15:05:57     INFO -  chrome://mochikit/content/browser-test.js:testScope/test_executeSoon/<.run:980
Flags: needinfo?(gtatum)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Flags: needinfo?(gtatum)
Status: NEW → ASSIGNED
Component: Developer Tools → Developer Tools: Framework
Priority: -- → P1

Comment 13

2 years ago
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04b5cc7a68ef
Restrict the CSS properties db test to only nightly; r=tromey
https://hg.mozilla.org/integration/autoland/rev/0ff11dd8d054
Remove caching optimization; r=tromey
(Reporter)

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/04b5cc7a68ef
https://hg.mozilla.org/mozilla-central/rev/0ff11dd8d054
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
(Reporter)

Updated

2 years ago
status-firefox51: --- → affected
Comment on attachment 8797774 [details]
Bug 1307009 - Restrict the CSS properties db test to only nightly;

Approval Request Comment
[Feature/regressing bug #]: 1307009
[User impact if declined]:

test_css-properties.js will permafail on uplift. This patch removes the test on anything but nightly, as we only care about providing a fallback css properties database from the nightly build.

[Describe test coverage new/current, TreeHerder]:

The test_css-properties.js file covers the database, but it is disabled with this patch.

[Risks and why]:

This is a test update.

[String/UUID change made/needed]: none
Attachment #8797774 - Flags: approval-mozilla-aurora?
Comment on attachment 8797775 [details]
Bug 1307009 - Remove caching optimization;

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

Approval Request Comment
[Feature/regressing bug #]: 1307009
[User impact if declined]:

test_css-properties.js will permafail on uplift. This patch removes the test on anything but nightly, as we only care about providing a fallback css properties database from the nightly build.

[Describe test coverage new/current, TreeHerder]:

The test_css-properties.js file covers the database, but it is disabled with this patch.

[Risks and why]:

This is a test update.

[String/UUID change made/needed]: none
Attachment #8797775 - Flags: approval-mozilla-aurora?
Oh shoot, I just noticed that you already uplifted this to aurora. I'll cancel those flags.
(Assignee)

Updated

2 years ago
Attachment #8797774 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

2 years ago
Attachment #8797775 - Flags: approval-mozilla-aurora?
You need to log in before you can comment on or make changes to this bug.