1307098 - Floating toolbar covers the carets when enabling full screen browsing

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect, P2)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Steps to reproduce:
1. Turn on "Full screen browsing"
2. Open an arbitrary web page like https://en.m.wikipedia.org/wiki/Main_Page#
3. Long tap to select a word

Expected result:
The floating toolbar does not cover the carets.

Actual result:
The floating toolbar covers the carets.

I can reproduce this on nightly 52 and aurora 51, but not on release 49.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

mozregression finds bug 1302452.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Thanks, I can repro on my Nexus 4 (although on the Z3C it always shows the action bar instead). I'll look into it.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1307098 - Fix the positioning of the floating toolbar so that it doesn't overlap the selection and carets.

Review commit: https://reviewboard.mozilla.org/r/83332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83332/

Comment 4

[Randall Barker [:rbarker]]

Comment on attachment 8797696 [details]
Bug 1307098 - Fix the positioning of the floating toolbar so that it doesn't overlap the selection and carets.

https://reviewboard.mozilla.org/r/83332/#review81870

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3470e326025c
Fix the positioning of the floating toolbar so that it doesn't overlap the selection and carets. r=rbarker

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3470e326025c

Comment 7

[Gerry Chang [:gchang]]

Hi :kats,
Since this bug is a regression and also affects 51, do you consider to uplift this for 51 if this patch is not too risky?

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8797696 [details]
Bug 1307098 - Fix the positioning of the floating toolbar so that it doesn't overlap the selection and carets.

Approval Request Comment
[Feature/regressing bug #]: bug 1302452
[User impact if declined]: on Android devices that have the floating toolbar, "full screen browsing" enabled, and the dynamic toolbar visible, selecting text will cause the selection carets to be obscured by the floating toolbar.
[Describe test coverage new/current, TreeHerder]: no automated tests
[Risks and why]: pretty low risk, it's a simple fix
[String/UUID change made/needed]: none

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8797696 [details]
Bug 1307098 - Fix the positioning of the floating toolbar so that it doesn't overlap the selection and carets.

Fix a regression related to UI. Take it in 51 aurora.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4bc6e299b3bb

Comment 11

[Sorina Florean [:sflorean]]

Verified as fixed in build:
- Aurora 51.0a2 (2016-10-16);
- Nightly 52.0a1 (2016-10-16);
Device: LG G4 (Android 6.0).