Closed Bug 1302452 Opened 3 years ago Closed 3 years ago

Remove filler view in dynamic toolbar code

Categories

(Firefox for Android :: Toolbar, defect, P3)

51 Branch
All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

In bug 1180295 with the most recent rewrite of the dynamic toolbar code we had to add some junk to support Gingerbread properly. Now that we no longer support Gingerbread (as of bug 1220184) we can remove that junk. It should be a no-op functionally but less code is better.
Bug 1197811 is actually where we added the gingerbread-specific code.
Blocks: 1197811
Comment on attachment 8790766 [details]
Bug 1302452 - Rip out the filler view inside LayerView since we don't support older Android versions any more.

https://reviewboard.mozilla.org/r/78434/#review77000
Attachment #8790766 - Flags: review?(rbarker) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b996739ade2
Rip out the filler view inside LayerView since we don't support older Android versions any more. r=rbarker
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/cec9f17302db
Backed out changeset 2b996739ade2 for failing test_group_mouseevents.html on Android. r=backout on a CLOSED TREE
Backed out for failing test_group_mouseevents.html on Android:

https://hg.mozilla.org/integration/autoland/rev/cec9f17302dbc776fa3a43c3a3c81e7fee873f0f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2b996739ade25a2d6cf3fb5ad6f2af1aa1e2fe88
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=3446549&repo=autoland

12:35:10     INFO -  219 INFO TEST-START | gfx/layers/apz/test/mochitest/test_group_mouseevents.html
12:35:10     INFO -  220 INFO must wait for load
12:35:10     INFO -  221 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_mouseevents.html | helper_click.html?dtc=false | Clicked on button, yay! (at 13,73) - got [object HTMLHtmlElement], expected [object HTMLButtonElement]
12:35:10     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:270:5
12:35:10     INFO -      spawnTest/w.is@gfx/layers/apz/test/mochitest/apz_test_utils.js:230:45
12:35:10     INFO -      clicked@gfx/layers/apz/test/mochitest/helper_click.html?dtc=false:29:3
12:35:22     INFO -  222 INFO must wait for load
12:35:22     INFO -  223 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_mouseevents.html | helper_click.html?dtc=true | Clicked on button, yay! (at 13,73) - got [object HTMLHtmlElement], expected [object HTMLButtonElement]
12:35:22     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:270:5
12:35:22     INFO -      spawnTest/w.is@gfx/layers/apz/test/mochitest/apz_test_utils.js:230:45
12:35:22     INFO -      clicked@gfx/layers/apz/test/mochitest/helper_click.html?dtc=true:29:3
12:35:22     INFO -  224 INFO must wait for load
12:35:22     INFO -  225 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_mouseevents.html | helper_drag_click.html | Clicked on button, yay! (at 16,76) - got [object HTMLHtmlElement], expected [object HTMLButtonElement]
12:35:22     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:270:5
12:35:22     INFO -      spawnTest/w.is@gfx/layers/apz/test/mochitest/apz_test_utils.js:230:45
12:35:22     INFO -      clicked@gfx/layers/apz/test/mochitest/helper_drag_click.html:29:3
12:35:22     INFO -  226 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_mouseevents.html | helper_drag_click.html | x-coord of click event looks sane
12:35:22     INFO -  227 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_mouseevents.html | helper_drag_click.html | y-coord of click event looks sane - got 76, expected 28
12:35:22     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:270:5
12:35:22     INFO -      spawnTest/w.is@gfx/layers/apz/test/mochitest/apz_test_utils.js:230:45
12:35:22     INFO -      clicked@gfx/layers/apz/test/mochitest/helper_drag_click.html:31:3
Flags: needinfo?(bugmail)
Thanks. I think I missed removing the line where the synthesized events are transformed by the translation as well [1]. With that removed the tests pass for me locally. Try push to confirm [2].

[1] http://searchfox.org/mozilla-central/rev/6b94deded39a868f248a492e74e05733d6c4ed48/mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/GeckoLayerClient.java#648
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cc12c112cca
Flags: needinfo?(bugmail)
Try push is green, will reland.
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f1ad9ea1c9e
Rip out the filler view inside LayerView since we don't support older Android versions any more. r=rbarker
https://hg.mozilla.org/mozilla-central/rev/3f1ad9ea1c9e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Depends on: 1307098
You need to log in before you can comment on or make changes to this bug.