Closed Bug 1307332 Opened 3 years ago Closed 3 years ago

Remove B2G and Mulet annotations from reftest.list

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: dholbert, Assigned: aryx)

References

(Blocks 1 open bug)

Details

Attachments

(79 files)

58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
58 bytes, text/x-review-board-request
dholbert
: review+
Details
As noted in bug 1306391, we're removing B2G-specific code from mozilla-central.

We have lots of (sometimes-complex) reftest.list test-failure annotations that are B2G or Mulet-specific. (Mulet is a B2G shim described at https://wiki.mozilla.org/Mulet )

Examples:
> skip-if(B2G||Mulet) fuzzy-if(skiaContent,1,3) needs-focus == input-load.html input-ref.html # B2G timed out waiting for reftest-wait to be removed # Initial mulet triage: parity with B2G/B2G Desktop
https://dxr.mozilla.org/mozilla-central/source/dom/html/reftests/autofocus/reftest.list#2

...and:
> skip-if((B2G&&browserIsRemote)||Mulet) == dynamic-1-remove-to-none-grouped.xul dynamic-1-ref.xul # Initial mulet triage: parity with B2G/B2G Desktop
https://dxr.mozilla.org/mozilla-central/source/layout/reftests/box-ordinal/reftest.list#2

Filing this bug on removing these annotations.
FYI, I think Aryx is already working on this.
The |reftest-stylo.list|s will be reimported by Manish.

Try series which turned the patch queue (together with changes to a test manifests) from orange to green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a029b48343e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bea97f54490
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b64e3687a87e
Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
Comment on attachment 8797444 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/abs-pos.

https://reviewboard.mozilla.org/r/83056/#review81814

Ship It!
Comment on attachment 8797444 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/abs-pos.

https://reviewboard.mozilla.org/r/83056/#review81816

Hmm, the "Ship It!" Button used to work for 2-click r+'s (after I unhide it with a customm Stylish stylesheet), but apparently it doesn't grant r+ anymore. :-/  Serves me right for using unsupported hidden functionality.

I guess I'll go with the standard ~4-click r+ workflow here. (woe is me)

Thanks for attacking this, BTW!
Attachment #8797444 - Flags: review?(dholbert) → review+
Comment on attachment 8797445 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/async-scrolling.

https://reviewboard.mozilla.org/r/83058/#review81820
Attachment #8797445 - Flags: review?(dholbert) → review+
Comment on attachment 8797446 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/backgrounds.

https://reviewboard.mozilla.org/r/83060/#review81826
Attachment #8797446 - Flags: review?(dholbert) → review+
Comment on attachment 8797447 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/bidi.

https://reviewboard.mozilla.org/r/83062/#review81830
Attachment #8797447 - Flags: review?(dholbert) → review+
Comment on attachment 8797449 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/border-image.

https://reviewboard.mozilla.org/r/83064/#review81832
Attachment #8797449 - Flags: review?(dholbert) → review+
Comment on attachment 8797450 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/border-radius.

https://reviewboard.mozilla.org/r/83066/#review81834
Attachment #8797450 - Flags: review?(dholbert) → review+
Comment on attachment 8797451 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/box.

https://reviewboard.mozilla.org/r/83068/#review81836

Ship It!
Comment on attachment 8797451 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/box.

https://reviewboard.mozilla.org/r/83068/#review81840
Attachment #8797451 - Flags: review?(dholbert) → review+
Comment on attachment 8797452 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/box-ordinal.

https://reviewboard.mozilla.org/r/83070/#review81844
Attachment #8797452 - Flags: review?(dholbert) → review+
Comment on attachment 8797453 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/box-properties.

https://reviewboard.mozilla.org/r/83072/#review81846
Attachment #8797453 - Flags: review?(dholbert) → review+
Comment on attachment 8797454 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/box-shadow.

https://reviewboard.mozilla.org/r/83074/#review81848
Attachment #8797454 - Flags: review?(dholbert) → review+
Comment on attachment 8797455 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/bugs.

https://reviewboard.mozilla.org/r/83076/#review81850

Looks like this patch incorporated something busted -- right now it's deleting a ton of files from layout/reftests/bugs, which I don't think is what you intended.

(Direct link to the commit showing all the deletions: https://reviewboard-hg.mozilla.org/gecko/rev/c9532f6e1ab8ddf14583f0fa5cf78dfc9bd4c561 )
Attachment #8797455 - Flags: review?(dholbert) → review-
Comment on attachment 8797456 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/canvas.

https://reviewboard.mozilla.org/r/83078/#review81852
Attachment #8797456 - Flags: review?(dholbert) → review+
Comment on attachment 8797457 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/columns.

https://reviewboard.mozilla.org/r/83080/#review81854
Attachment #8797457 - Flags: review?(dholbert) → review+
Comment on attachment 8797458 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/counter-style.

https://reviewboard.mozilla.org/r/83082/#review81856
Attachment #8797458 - Flags: review?(dholbert) → review+
Comment on attachment 8797459 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-disabled.

https://reviewboard.mozilla.org/r/83084/#review81858
Attachment #8797459 - Flags: review?(dholbert) → review+
Comment on attachment 8797460 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-display.

https://reviewboard.mozilla.org/r/83086/#review81860
Attachment #8797460 - Flags: review?(dholbert) → review+
Comment on attachment 8797461 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-enabled.

https://reviewboard.mozilla.org/r/83088/#review81862
Attachment #8797461 - Flags: review?(dholbert) → review+
Comment on attachment 8797462 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-gradients.

https://reviewboard.mozilla.org/r/83090/#review81864
Attachment #8797462 - Flags: review?(dholbert) → review+
Comment on attachment 8797463 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-import.

https://reviewboard.mozilla.org/r/83092/#review81866
Attachment #8797463 - Flags: review?(dholbert) → review+
Comment on attachment 8797464 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-invalid.

https://reviewboard.mozilla.org/r/83094/#review81888

Ship It!
Attachment #8797464 - Flags: review?(dholbert) → review+
Comment on attachment 8797465 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-mediaqueries.

https://reviewboard.mozilla.org/r/83096/#review81892

Ship It!
Attachment #8797465 - Flags: review?(dholbert) → review+
Comment on attachment 8797466 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-selectors.

https://reviewboard.mozilla.org/r/83098/#review81894

Ship It!
Attachment #8797466 - Flags: review?(dholbert) → review+
Comment on attachment 8797467 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-submit-invalid.

https://reviewboard.mozilla.org/r/83100/#review81896

Ship It!
Attachment #8797467 - Flags: review?(dholbert) → review+
Comment on attachment 8797468 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-ui-invalid.

https://reviewboard.mozilla.org/r/83102/#review81898

Ship It!
Attachment #8797468 - Flags: review?(dholbert) → review+
Comment on attachment 8797469 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-ui-valid.

https://reviewboard.mozilla.org/r/83104/#review81900

Ship It!
Attachment #8797469 - Flags: review?(dholbert) → review+
Comment on attachment 8797470 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-valid.

https://reviewboard.mozilla.org/r/83106/#review81902

Ship It!
Attachment #8797470 - Flags: review?(dholbert) → review+
Comment on attachment 8797471 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/css-valuesandunits.

https://reviewboard.mozilla.org/r/83108/#review81904

Ship It!
Attachment #8797471 - Flags: review?(dholbert) → review+
Comment on attachment 8797472 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/cssom.

https://reviewboard.mozilla.org/r/83110/#review81906

Ship It!
Attachment #8797472 - Flags: review?(dholbert) → review+
Comment on attachment 8797473 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/dom.

https://reviewboard.mozilla.org/r/83112/#review81908

Ship It!
Attachment #8797473 - Flags: review?(dholbert) → review+
Comment on attachment 8797474 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/first-letter.

https://reviewboard.mozilla.org/r/83114/#review81910

r=me with the following issue addressed:

::: layout/reftests/first-letter/reftest.list:67
(Diff revision 1)
>  fails-if(winWidget||cocoaWidget) == 617869-1.html 617869-1-ref.html
>  == 723509-1.html 723509-1-ref.html
>  == 922550-1.html 922550-1-ref.html
>  == 958249.html 958249-ref.html
>  == font-text-styles.html font-text-styles-ref.html
> -fails-if(gtkWidget&&!Mulet) random-if(winWidget&&!d2d) == font-text-styles-floater.html font-text-styles-floater-ref.html # bug 992846 # Initial mulet triage: parity with B2G/B2G Desktop
> +fails-if(gtkWidget) random-if(winWidget&&!d2d) == font-text-styles-floater.html font-text-styles-floater-ref.html

The "bug 992846" annotation needs to stay here -- don't remove that.
Attachment #8797474 - Flags: review?(dholbert) → review+
Comment on attachment 8797475 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/flexbox.

https://reviewboard.mozilla.org/r/83116/#review81912

Ship It!
Attachment #8797475 - Flags: review?(dholbert) → review+
Comment on attachment 8797476 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/font-face.

https://reviewboard.mozilla.org/r/83118/#review81914

Ship It!
Attachment #8797476 - Flags: review?(dholbert) → review+
Comment on attachment 8797477 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/font-features.

https://reviewboard.mozilla.org/r/83120/#review81916

Ship It!
Attachment #8797477 - Flags: review?(dholbert) → review+
Comment on attachment 8797478 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/font-inflation.

https://reviewboard.mozilla.org/r/83122/#review81918

Ship It!
Attachment #8797478 - Flags: review?(dholbert) → review+
Comment on attachment 8797455 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/bugs.

https://reviewboard.mozilla.org/r/83076/#review81850

That's intended because the tests which used these files only ran for B2G and don't get executed anymore, see https://reviewboard-hg.mozilla.org/gecko/rev/c9532f6e1ab8ddf14583f0fa5cf78dfc9bd4c561#l57.1179 Should they be kept in tree?
Comment on attachment 8797455 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/bugs.

https://reviewboard.mozilla.org/r/83076/#review81850

I see, thanks. I just asked over on bug 1177334 (which is where we made these tests B2G-specific) -- let's see what happens over there.

Also: if we *are* removing the tests files here, this changeset's commit message should reflect that. Right now it's "Remove B2G and Mulet annotations from reftest.list: layout/reftests/bugs".  That should probably say: "Remove B2G and Mulet annotations from reftest.list (and B2G-specific reftests): layout/reftests/bugs"
Comment on attachment 8797479 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/font-matching.

https://reviewboard.mozilla.org/r/83124/#review81920

r=me on this part with the following comment-nit:

::: layout/reftests/font-matching/reftest.list:75
(Diff revision 1)
>  fuzzy-if(OSX==1010&&browserIsRemote,1,17) fuzzy-if(Android,4,8) HTTP(..) == stretchmapping-35.html stretchmapping-35-ref.html
>  fuzzy-if(OSX==1010,3,5) HTTP(..) == stretchmapping-137.html stretchmapping-137-ref.html
>  
>  # test for font-stretch using @font-face
> -skip-if(B2G||Mulet) skip-if(Android) HTTP(..) == font-stretch-1.html font-stretch-1-ref.html # bugs 773482, 927602 # Initial mulet triage: parity with B2G/B2G Desktop
> -skip-if(B2G||Mulet) skip-if(Android) HTTP(..) == font-shorthand-stretch-1.html font-stretch-1-ref.html # bugs 773482, 927602 # Initial mulet triage: parity with B2G/B2G Desktop
> +skip-if(Android) HTTP(..) == font-stretch-1.html font-stretch-1-ref.html # 927602
> +skip-if(Android) HTTP(..) == font-shorthand-stretch-1.html font-stretch-1-ref.html # 927602

s/927602/bug 927602/ in the comment at the end of these two lines, please (for font-stretch and font-shorthand-stretch).  Include the word "bug".
Attachment #8797479 - Flags: review?(dholbert) → review+
Comment on attachment 8797455 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/bugs.

https://reviewboard.mozilla.org/r/83076/#review81850

OK, kats says these tests might want to change to "skip-if(!Android)", though we're not sure that'll work (and it also might initially work but turn out to be flaky, perhaps.

My suggestion: could we leave these "skip-if(!B2G)" tests alone for the purposes of this bug, and spin off a followup-bug to deal with them? It might end up being as easy as a straight s/!B2G/!Android/ search-and-replace, but if there are unforseen compliations or regressions, it'd be nice to have a dedicated place to deal with them, rather than lumping it into a monster bug like this one.
Comment on attachment 8797480 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/forms.

https://reviewboard.mozilla.org/r/83126/#review81928

r=me on this part, with the following:

::: layout/reftests/forms/button/reftest.list:12
(Diff revision 1)
>  == max-height.html max-height-ref.html
>  == min-height.html min-height-ref.html
>  == overflow-areas-1.html overflow-areas-1-ref.html
>  
> -# The buttons in these tests have some fancy shading applied to their corners
> -# on B2G, despite their "-moz-appearance: none; background: gray", so they
> +# The buttons in these tests have some fancy shading applied to their corners,
> +# despite their "-moz-appearance: none; background: gray", so they

You're removing the "on B2G" qualifier from the comment here.

Instead of just removing it, please replace it with "on Android".  (This comment still applies to Android -- in fact, it *only* applies to Android now.)

(Note: We really should have added a mention of Android to the comment here, back when we added Android to the fuzzy annotations, in https://hg.mozilla.org/integration/mozilla-inbound/rev/ac696b8baf85#l5.9 )
Attachment #8797480 - Flags: review?(dholbert) → review+
Comment on attachment 8797481 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/generated-content.

https://reviewboard.mozilla.org/r/83128/#review81942

Ship It!
Attachment #8797481 - Flags: review?(dholbert) → review+
Comment on attachment 8797482 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/image.

https://reviewboard.mozilla.org/r/83130/#review81946

Ship It!
Attachment #8797482 - Flags: review?(dholbert) → review+
Comment on attachment 8797483 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/image-element.

https://reviewboard.mozilla.org/r/83132/#review81950

Ship It!
Attachment #8797483 - Flags: review?(dholbert) → review+
Comment on attachment 8797484 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/image-rect.

https://reviewboard.mozilla.org/r/83134/#review81952

Ship It!
Attachment #8797484 - Flags: review?(dholbert) → review+
Comment on attachment 8797485 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/image-region.

https://reviewboard.mozilla.org/r/83136/#review81954

Ship It!
Attachment #8797485 - Flags: review?(dholbert) → review+
Comment on attachment 8797486 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/indic-shaping.

https://reviewboard.mozilla.org/r/83138/#review81956

Ship It!
Attachment #8797486 - Flags: review?(dholbert) → review+
Comment on attachment 8797487 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/invalidation.

https://reviewboard.mozilla.org/r/83140/#review81958

r=me with trailing space fixed:

::: layout/reftests/invalidation/reftest.list:5
(Diff revision 1)
>  == table-repaint-a.html table-repaint-a-ref.html
>  == table-repaint-b.html table-repaint-b-ref.html
>  == table-repaint-c.html table-repaint-c-ref.html
>  == table-repaint-d.html table-repaint-d-ref.html
> -skip-if((B2G&&browserIsRemote)||Mulet) == 540247-1.xul 540247-1-ref.xul  # bug 974780 # Initial mulet triage: parity with B2G/B2G Desktop
> +== 540247-1.xul 540247-1-ref.xul 

Nit: drop whitespace at end of line.

(This probably got missed because there were two spaces before the comment instead of 1, and your regex only spliced out a single space.)
Attachment #8797487 - Flags: review?(dholbert) → review+
Comment on attachment 8797488 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/line-breaking.

https://reviewboard.mozilla.org/r/83142/#review81966

Ship It!
Attachment #8797488 - Flags: review?(dholbert) → review+
Comment on attachment 8797489 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/margin-collapsing.

https://reviewboard.mozilla.org/r/83144/#review81968

Ship It!
Attachment #8797489 - Flags: review?(dholbert) → review+
Comment on attachment 8797490 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/marquee.

https://reviewboard.mozilla.org/r/83146/#review81970

Ship It!
Attachment #8797490 - Flags: review?(dholbert) → review+
Comment on attachment 8797491 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/mathml.

https://reviewboard.mozilla.org/r/83148/#review81972

Ship It!
Attachment #8797491 - Flags: review?(dholbert) → review+
Comment on attachment 8797492 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/mp4-video.

https://reviewboard.mozilla.org/r/83150/#review81976

Ship It!
Attachment #8797492 - Flags: review?(dholbert) → review+
Comment on attachment 8797493 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/object.

https://reviewboard.mozilla.org/r/83152/#review81978

Ship It!
Attachment #8797493 - Flags: review?(dholbert) → review+
Comment on attachment 8797494 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/ogg-video.

https://reviewboard.mozilla.org/r/83154/#review81982

Ship It!
Attachment #8797494 - Flags: review?(dholbert) → review+
Comment on attachment 8797495 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/outline.

https://reviewboard.mozilla.org/r/83156/#review81984

Ship It!
Attachment #8797495 - Flags: review?(dholbert) → review+
Comment on attachment 8797496 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/pagination.

https://reviewboard.mozilla.org/r/83158/#review81988

r=me with the following addressed:

::: layout/reftests/pagination/reftest.list:56
(Diff revision 1)
>  == table-page-break-before-right-1.html table-page-break-before-auto-2-ref.html
>  == table-page-break-after-always-1.html table-page-break-before-auto-2-ref.html
>  == table-page-break-after-left-1.html table-page-break-before-auto-2-ref.html
>  == table-page-break-after-right-1.html table-page-break-before-auto-2-ref.html
> -skip-if(B2G||Mulet) == rowgroup-page-break-after-always-1.html table-page-break-before-auto-2-ref.html # bug 773482 # Initial mulet triage: parity with B2G/B2G Desktop
> -skip-if(B2G||Mulet) == row-page-break-after-always-1.html table-page-break-before-auto-2-ref.html # bug 773482 # Initial mulet triage: parity with B2G/B2G Desktop
> +== rowgroup-page-break-after-always-1.html table-page-break-before-auto-2-ref.html # bug 773482
> +== row-page-break-after-always-1.html table-page-break-before-auto-2-ref.html # bug 773482

In this file, you've left behind "# bug 773482" comments (and that bug is "Tracking Bug to enable reftests on B2G", and is associated with the skip-if() annotation that you're removing).

So: please remove all these # bug 773482 mentions here.
Attachment #8797496 - Flags: review?(dholbert) → review+
Comment on attachment 8797497 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/percent-overflow-sizing.

https://reviewboard.mozilla.org/r/83160/#review81990

Ship It!
Attachment #8797497 - Flags: review?(dholbert) → review+
Comment on attachment 8797498 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/pixel-rounding.

https://reviewboard.mozilla.org/r/83162/#review81992

Ship It!
Attachment #8797498 - Flags: review?(dholbert) → review+
Comment on attachment 8797499 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/position-dynamic-changes.

https://reviewboard.mozilla.org/r/83164/#review81994

Ship It!
Attachment #8797499 - Flags: review?(dholbert) → review+
Comment on attachment 8797500 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/position-sticky.

https://reviewboard.mozilla.org/r/83166/#review81996

Ship It!
Attachment #8797500 - Flags: review?(dholbert) → review+
Comment on attachment 8797501 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/printing.

https://reviewboard.mozilla.org/r/83168/#review81998

Ship It!
Attachment #8797501 - Flags: review?(dholbert) → review+
Comment on attachment 8797502 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/reftest-sanity.

https://reviewboard.mozilla.org/r/83170/#review82000

Ship It!
Attachment #8797502 - Flags: review?(dholbert) → review+
Comment on attachment 8797503 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/scrolling.

https://reviewboard.mozilla.org/r/83172/#review82004

Ship It!
Attachment #8797503 - Flags: review?(dholbert) → review+
Comment on attachment 8797504 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/selection.

https://reviewboard.mozilla.org/r/83174/#review82008

Ship It!
Attachment #8797504 - Flags: review?(dholbert) → review+
Comment on attachment 8797505 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/svg.

https://reviewboard.mozilla.org/r/83176/#review82012

r=me, with obsolete bug reference cleaned up:

::: layout/reftests/svg/moz-only/reftest.list:5
(Diff revision 1)
>  
>  # XBL tests
> -skip-if((B2G&&browserIsRemote)||Mulet) == xbl-basic-01.svg                             pass.svg # Initial mulet triage: parity with B2G/B2G Desktop
> -skip-if((B2G&&browserIsRemote)||Mulet) == xbl-basic-02.svg                             pass.svg # Initial mulet triage: parity with B2G/B2G Desktop
> -skip-if(B2G||Mulet) == xbl-basic-03.svg                             pass.svg # bug 773482 # Initial mulet triage: parity with B2G/B2G Desktop
> +== xbl-basic-01.svg                             pass.svg
> +== xbl-basic-02.svg                             pass.svg
> +== xbl-basic-03.svg                             pass.svg # bug 773482

Let's drop this straggling reference to bug 773482 here.
Attachment #8797505 - Flags: review?(dholbert) → review+
Comment on attachment 8797506 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/table-background.

https://reviewboard.mozilla.org/r/83178/#review82022

Ship It!
Attachment #8797506 - Flags: review?(dholbert) → review+
Comment on attachment 8797507 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/table-overflow.

https://reviewboard.mozilla.org/r/83180/#review82024

Ship It!
Attachment #8797507 - Flags: review?(dholbert) → review+
Comment on attachment 8797508 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/table-width.

https://reviewboard.mozilla.org/r/83182/#review82028

Ship It!
Attachment #8797508 - Flags: review?(dholbert) → review+
Comment on attachment 8797509 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/text.

https://reviewboard.mozilla.org/r/83184/#review82030

r=me, with one nit addressed:

::: layout/reftests/text/reftest.list:61
(Diff revision 1)
>  # D2D/DirectWrite results depend on the rendering mode chosen, so considering this as random for now.
>  skip-if(!(d2d||cocoaWidget)) random-if(d2d) != subpixel-glyphs-x-2a.html subpixel-glyphs-x-2b.html
> -skip-if(B2G||Mulet) HTTP(..) == subpixel-glyphs-x-3a.html subpixel-glyphs-x-3b.html # Initial mulet triage: parity with B2G/B2G Desktop
> +HTTP(..) == subpixel-glyphs-x-3a.html subpixel-glyphs-x-3b.html
>  # No platforms do subpixel positioning vertically
>  fuzzy-if(Android,19,2) == subpixel-glyphs-y-1a.html subpixel-glyphs-y-1b.html
> -fuzzy-if((Android||B2G),231,653) == subpixel-lineheight-1a.html subpixel-lineheight-1b.html
> +fuzzy-if((Android),231,653) == subpixel-lineheight-1a.html subpixel-lineheight-1b.html

Please drop straggling extra parens around (Android) here.
Attachment #8797509 - Flags: review?(dholbert) → review+
Comment on attachment 8797510 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/text-decoration.

https://reviewboard.mozilla.org/r/83186/#review82032

Ship It!
Attachment #8797510 - Flags: review?(dholbert) → review+
Comment on attachment 8797511 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/text-overflow.

https://reviewboard.mozilla.org/r/83188/#review82034

r=me, with 1 whitespace nit fixed:

::: layout/reftests/text-overflow/reftest.list:23
(Diff revision 1)
>  == aligned-baseline.html aligned-baseline-ref.html
> -skip-if(Android||B2G) fuzzy-if(skiaContent,1,5) == clipped-elements.html clipped-elements-ref.html
> +skip-if(Android) fuzzy-if(skiaContent,1,5) == clipped-elements.html clipped-elements-ref.html
>  HTTP(..) == theme-overflow.html theme-overflow-ref.html
> -skip-if(B2G||Mulet) HTTP(..) == table-cell.html table-cell-ref.html # Initial mulet triage: parity with B2G/B2G Desktop
> -skip-if(Mulet) fuzzy-if(gtkWidget,10,32) HTTP(..) == two-value-syntax.html two-value-syntax-ref.html # MULET: Bug 1144079: Re-enable Mulet mochitests and reftests taskcluster-specific disables
> -skip-if(B2G||Mulet) HTTP(..) == single-value.html single-value-ref.html  # Initial mulet triage: parity with B2G/B2G Desktop
> +HTTP(..) == table-cell.html table-cell-ref.html
> +fuzzy-if(gtkWidget,10,32) HTTP(..) == two-value-syntax.html two-value-syntax-ref.html
> +HTTP(..) == single-value.html single-value-ref.html 

Please drop the trailing space character on this line.
Attachment #8797511 - Flags: review?(dholbert) → review+
Comment on attachment 8797512 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/text-shadow.

https://reviewboard.mozilla.org/r/83190/#review82038

Ship It!
Attachment #8797512 - Flags: review?(dholbert) → review+
Comment on attachment 8797513 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/text-svgglyphs.

https://reviewboard.mozilla.org/r/83192/#review82042

Ship It!
Attachment #8797513 - Flags: review?(dholbert) → review+
Comment on attachment 8797514 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/text-transform.

https://reviewboard.mozilla.org/r/83194/#review82044

Ship It!

::: layout/reftests/text-transform/reftest.list:21
(Diff revision 1)
>  HTTP(..) != graphite-small-caps-1.html graphite-small-caps-1-notref.html
>  == uppercase-1.html uppercase-ref.html
>  == uppercase-szlig-1.html uppercase-szlig-ref.html
>  # these use DejaVu Sans via @font-face for consistency of results
> -skip-if(B2G||Mulet) fuzzy-if(cocoaWidget,250,15) HTTP(..) == all-upper.html all-upper-ref.html # bug 773482, 1140292 # Initial mulet triage: parity with B2G/B2G Desktop
> -skip-if(B2G||Mulet) fuzzy-if(cocoaWidget,250,15) fuzzy-if(skiaContent,1,1800) HTTP(..) == all-lower.html all-lower-ref.html # bug 773482, 1140292 # Initial mulet triage: parity with B2G/B2G Desktop
> +fuzzy-if(cocoaWidget,250,15) HTTP(..) == all-upper.html all-upper-ref.html # 1140292
> +fuzzy-if(cocoaWidget,250,15) fuzzy-if(skiaContent,1,1800) HTTP(..) == all-lower.html all-lower-ref.html # 1140292

Please add the word "bug" to the comments on these two lines. ("bug 1140292")
Attachment #8797514 - Flags: review?(dholbert) → review+
Comment on attachment 8797515 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/transform.

https://reviewboard.mozilla.org/r/83196/#review82046

Ship It!
Attachment #8797515 - Flags: review?(dholbert) → review+
Comment on attachment 8797516 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/transform-3d.

https://reviewboard.mozilla.org/r/83198/#review82048

Ship It!
Attachment #8797516 - Flags: review?(dholbert) → review+
Comment on attachment 8797517 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/reftest.list.

https://reviewboard.mozilla.org/r/83200/#review82066

r=me with one comment updated (or removed if necessary), per below:

::: layout/reftests/reftest.list:255
(Diff revision 1)
>  # marquee/
>  include marquee/reftest.list
>  
>  # native-theme/
> -# skipping for B2G since something around radio-nonnative.html makes the whole suite hang
> -skip-if(B2G||Android||Mulet) include native-theme/reftest.list # Initial mulet triage: parity with B2G/B2G Desktop
> +# skipping for Android since something around radio-nonnative.html makes the whole suite hang
> +skip-if(Android) include native-theme/reftest.list

I suspect the modified comment here ("skipping for android since...") is actually wrong. Based on hg blame, it looks like we disabled this on Android *separately* from when we disabled it on B2G, as part of some theming rewrite in bug 1223526. So the old B2G explanatory comment is unlikely to accurately explain why it's also disabled on Android.

SO: we should replace this comment with something more accurate. I asked mfinkle & gbrown over in bug 1223526 comment 33 what we should replace it with.  (That the bug where we added Android to this skip-if annotation.)

(If we don't get a response over there right away & end up being blocked on this, I'd be OK landing this with the "skipping for..." comment removed entirely, and perhaps handling the Android annotation in a followup.)
Attachment #8797517 - Flags: review?(dholbert) → review+
Comment on attachment 8797518 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/w3c-css.

https://reviewboard.mozilla.org/r/83202/#review82068

Ship It!
Attachment #8797518 - Flags: review?(dholbert) → review+
Comment on attachment 8797519 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/webcomponents.

https://reviewboard.mozilla.org/r/83204/#review82070

Ship It!
Attachment #8797519 - Flags: review?(dholbert) → review+
Comment on attachment 8797520 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/webm-video.

https://reviewboard.mozilla.org/r/83206/#review82074

Ship It!
Attachment #8797520 - Flags: review?(dholbert) → review+
Comment on attachment 8797521 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/writing-mode.

https://reviewboard.mozilla.org/r/83208/#review82076

Ship It!
Attachment #8797521 - Flags: review?(dholbert) → review+
Comment on attachment 8797522 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/xul.

https://reviewboard.mozilla.org/r/83210/#review82078

Ship It!
Attachment #8797522 - Flags: review?(dholbert) → review+
Comment on attachment 8797523 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/xul-document-load.

https://reviewboard.mozilla.org/r/83212/#review82080

Ship It!
Attachment #8797523 - Flags: review?(dholbert) → review+
Comment on attachment 8797517 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/reftest.list.

https://reviewboard.mozilla.org/r/83200/#review82066

> I suspect the modified comment here ("skipping for android since...") is actually wrong. Based on hg blame, it looks like we disabled this on Android *separately* from when we disabled it on B2G, as part of some theming rewrite in bug 1223526. So the old B2G explanatory comment is unlikely to accurately explain why it's also disabled on Android.
> 
> SO: we should replace this comment with something more accurate. I asked mfinkle & gbrown over in bug 1223526 comment 33 what we should replace it with.  (That the bug where we added Android to this skip-if annotation.)
> 
> (If we don't get a response over there right away & end up being blocked on this, I'd be OK landing this with the "skipping for..." comment removed entirely, and perhaps handling the Android annotation in a followup.)

OK -- from looking at the commit* that made this "skip-if(Android)", it looks like the accurate explanatory comment here would be something like:
# (no XUL theme on Android)

So: Please replace the patch's current comment here ("Skipping for Android since something around radio-nonnative.html makes the whole suite hang") with that.

* https://hg.mozilla.org/integration/fx-team/rev/67a9dd1470e7#l3.36
Comment on attachment 8797455 [details]
Bug 1307332 - Remove B2G and Mulet annotations from reftest.list: layout/reftests/bugs.

https://reviewboard.mozilla.org/r/83076/#review83006

Thanks again for taking this on! This is awesome.

r=me, just a few bug number comments to be removed (which only exist to explain the b2g annotations that you're removing in this patch).

::: layout/reftests/bugs/reftest.list:320
(Diff revision 2)
>  == 296361-1.html 296361-ref.html
>  == 296904-1.html 296904-1-ref.html
> -skip-if(B2G||Mulet) == 299136-1.html 299136-1-ref.html # Initial mulet triage: parity with B2G/B2G Desktop
> +== 299136-1.html 299136-1-ref.html
>  == 299837-1.html 299837-1-ref.html
> -skip-if((B2G&&browserIsRemote)||Mulet) == 299837-2.xul 299837-2-ref.xul # bug 974780 # Initial mulet triage: parity with B2G/B2G Desktop
> -random-if(d2d) skip-if((B2G&&browserIsRemote)||Mulet) == 299837-3.xul 299837-3-ref.xul # bug 587631, 974780 # Initial mulet triage: parity with B2G/B2G Desktop
> +== 299837-2.xul 299837-2-ref.xul
> +random-if(d2d) == 299837-3.xul 299837-3-ref.xul # bug 587631, 974780

Drop ", 974780" from the end of this line.

::: layout/reftests/bugs/reftest.list:640
(Diff revision 2)
>  == 370525-rowspan-2b.html 370525-rowspan-2b-ref.html
>  == 370525-rowspan-3.html 370525-rowspan-3-ref.html
>  == 370525-rowspan-4.html 370525-rowspan-4-ref.html
>  == 370525-sib.html 370525-sib-ref.html
>  == 370586-1.xhtml 370586-1-ref.xhtml
> -skip-if(B2G||Mulet) == 370629-1.html 370629-1-ref.html # bug 1060869 # Initial mulet triage: parity with B2G/B2G Desktop
> +== 370629-1.html 370629-1-ref.html # bug 1060869

Drop the "bug 1060869" bug number comment here.

That bug number was added at the same time as the annotation, here:
 https://hg.mozilla.org/mozilla-central/rev/1cbca597b025#l6.12
...so it should be removed with the annotation.

::: layout/reftests/bugs/reftest.list:775
(Diff revision 2)
>  == 389074-1.html 389074-1-ref.html
>  == 389224-1.html 389224-1-ref.html
>  == 389224-2.html about:blank
> -skip-if(B2G||Mulet) == 389468-1.html 389468-1-ref.html # Initial mulet triage: parity with B2G/B2G Desktop
> +== 389468-1.html 389468-1-ref.html
>  == 389623-1.html 389623-1-ref.html
> -skip-if((B2G&&browserIsRemote)||Mulet) == 389636-1.html about:blank  # assertion test # bug 975911 # Initial mulet triage: parity with B2G/B2G Desktop
> +== 389636-1.html about:blank  # assertion test # bug 975911

Please drop the "bug 975911" comment at the end of this line.

::: layout/reftests/bugs/reftest.list:810
(Diff revision 2)
>  == 393671-3.html 393671-3-ref.html
>  == 393760-1.xml 393760-1-ref.xml
>  fuzzy-if(skiaContent,1,500) == 393760-2.xml 393760-2-ref.xml
>  == 394111-1.html about:blank  # Really an assertion test rather than a rendering test
>  == 394534-1.html 394534-1-ref.html
> -skip-if((B2G&&browserIsRemote)||Mulet) == 394676-1.xhtml 394676-1-ref.xhtml # bug 975911 # Initial mulet triage: parity with B2G/B2G Desktop
> +== 394676-1.xhtml 394676-1-ref.xhtml # bug 975911

As above, drop the comment about bug 975911 here.
Attachment #8797455 - Flags: review?(dholbert) → review+