Closed Bug 1307724 Opened 3 years ago Closed 3 years ago

Cherry-pick cubeb revision 50d92c

Categories

(Core :: Audio/Video: cubeb, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: padenot, Assigned: padenot)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → padenot
Comment on attachment 8797954 [details]
Bug 1307724 - Cherry-pick cubeb revision 50d92c.

https://reviewboard.mozilla.org/r/83558/#review82148

::: media/libcubeb/src/cubeb_wasapi.cpp:512
(Diff revision 1)
>  
>    /* If this is not true, there will be glitches.
>       It is alright to have produced less frames if we are draining, though. */
>    XASSERT(out_frames == output_frames_needed || stm->draining || !has_output(stm));
>  
> +

Accidental extra newline here? (and it's not in the patch)

::: media/libcubeb/wasapi-stereo-mic.patch:5
(Diff revision 1)
> +From 50d92c0eaa05a93f4dd8ff5072e983c6c84d0369 Mon Sep 17 00:00:00 2001
> +From: Paul Adenot <paul@paul.cx>
> +Date: Tue, 4 Oct 2016 07:18:04 -0700
> +Subject: [PATCH] Divide by the number of channel of the stream to compute the
> + duratio of the buffer.

Typo: duration
Comment on attachment 8797954 [details]
Bug 1307724 - Cherry-pick cubeb revision 50d92c.

https://reviewboard.mozilla.org/r/83560/#review82150

r+ with nits
Attachment #8797954 - Flags: review?(kinetik) → review+
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6732c97395e
Cherry-pick cubeb revision 50d92c. r=kinetik
https://hg.mozilla.org/mozilla-central/rev/d6732c97395e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
The patch for this bug resolved the bug in Bug 1300650.  

Paul -- We should uplift the patch here to Aurora or disable full duplex in Aurora.  Thanks.
Flags: needinfo?(padenot)
Maire, this is already on aurora, https://bugzilla.mozilla.org/show_bug.cgi?id=1310206#c7
Flags: needinfo?(padenot)
You need to log in before you can comment on or make changes to this bug.