Originally posted by:linclark see https://github.com/devtools-html/gecko-dev/issues/233 For many of these, new stubs will need to be added. The current tests have an object with the following keys: - input: this is passed into console.log() - output (or consoleOutput): this is the expected output - printOutput: this will be handled in #232 - inspectable: whether you can click on it for variables view - variablesViewLabel: the label for the collapsible that represents the object in variables view. We don't currently implement this. @bgrins, do you think that we should? I'd say we don't need to since vview is just a short term solution for us. - supressClick: I'm not actually sure why this is here. It's not documented and there are only [4 test cases](https://dxr.mozilla.org/mozilla-central/search?q=suppressClick&redirect=false) that use it, all in the same test. I wonder if it's similar to noClick? @bgrins any ideas? - noClick: ignore We will need stubs for these test cases. We may need to reconsider how we organize snippets. For now, let's just have all of these in their own snippet file.
Priority: P2 → P3
Whiteboard: new-console → [reserve-new-console]
Whiteboard: [reserve-new-console] → [reserve-console-html]
I wonder if there is any value doing this since the output is handled by Reps and tested there. The only thing that we may keep is testing the result of `print()` that some case have, maybe they could be copied into a dedicated test in Bug 1307916 ? I will go through the examples and see if we get similar output, and if there is a bug, file an issue against reps. Then we'll be able to delete these tests when Bug 1347127 lands. browser_webconsole_output_01: ✔ browser_webconsole_output_02: - https://github.com/devtools-html/devtools-core/issues/680 (DomTokenList in TINY mode) - https://github.com/devtools-html/devtools-core/issues/495 (Set in TINY mode) - https://github.com/devtools-html/devtools-core/issues/681 browser_webconsole_output_03: ✔ browser_webconsole_output_04: - https://github.com/devtools-html/devtools-core/issues/682 (DomException message) - https://github.com/devtools-html/devtools-core/issues/683 (expanded CSS2Properties, but was similar in the VariableView) - https://github.com/devtools-html/devtools-core/issues/684 (CSSRule) browser_webconsole_output_05: - https://github.com/devtools-html/devtools-core/issues/685 - https://github.com/devtools-html/devtools-core/issues/686 browser_webconsole_output_06: ✔ (but might be good to move to a server unit test since we do the "object with a length property are rendered as ArrayLike" there).
Issues were filed in Github, and we do have a server test for ArrayLike object. Closing
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.