Closed
Bug 1347127
Opened 8 years ago
Closed 7 years ago
Enable new console frontend in Browser Toolbox
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jdescottes, Assigned: bgrins)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [newconsole-mvp])
Attachments
(1 file, 1 obsolete file)
The new console frontend is currently explicitly disabled in the browser toolbox and in the browser content toolbox, even if the "webconsole.new-frontend-enabled"
preference is on.
http://searchfox.org/mozilla-central/rev/a5c2b278897272497e14a8481513fee34bbc7e2c/devtools/client/webconsole/webconsole.js#539-541
We need to check if there was a good reason to keep the new console off in those environments, and if not we should probably enable it.
Reporter | ||
Comment 1•8 years ago
|
||
Nicolas, do you know if there is any good reason not to do this?
Flags: needinfo?(chevobbe.nicolas)
Comment 2•8 years ago
|
||
If I remember correctly, it was when we decided to enable the new console in nightly, but we weren't at feature parity (and were afraid that there would be still some bugs that would annoy moz people which rely on it). Also, it was a nice way to debug the new console, because if you use it in the browser console too and break it, you can't really see anything :)
Now, I'd say that the console is working pretty well, doesn't lack much in comparison with the old one, so I guess we could enable it in browser toolbox.
Brian may have a different opinion on this, so maybe we could wait until he's back to decide what to do ?
Flags: needinfo?(chevobbe.nicolas)
Updated•8 years ago
|
Component: Developer Tools: Inspector → Developer Tools: Console
Comment 3•8 years ago
|
||
One way around the debugging issue would be to have a second pref controlling
which console is used by the browser toolbox.
Updated•8 years ago
|
Flags: qe-verify?
Priority: -- → P2
Whiteboard: [new-console]
Updated•8 years ago
|
Whiteboard: [new-console] → [console-html]
Updated•8 years ago
|
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Updated•8 years ago
|
Iteration: --- → 55.4 - May 1
Priority: P2 → P1
Comment 4•8 years ago
|
||
I think this depends at least on bug 1307895
"LogMessage" log type needs to be supported before we can enable it otherwise there is an exception in convertCachedPacket() function (utils/message.js).
Honza
Depends on: 1307895
Comment hidden (mozreview-request) |
Comment 6•8 years ago
|
||
@Brian, the attached patch requires also patch from bug 1307895
Do you know if there are any other issues blocking us from enabling the new front end in Browser Console/Toolbox?
Honza
Updated•8 years ago
|
Flags: qe-verify? → qe-verify+
QA Contact: iulia.cristescu
Assignee | ||
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8862433 [details]
Bug 1347127 - Enable new console frontend in Browser Toolbox;
https://reviewboard.mozilla.org/r/134366/#review137468
As we discussed, let's wait to merge until we do a pass through remaining bugs and then do a run-through comparison to make sure we aren't either missing features or going to blank out when running in chrome.
::: devtools/client/webconsole/webconsole.js:539
(Diff revision 1)
> * @private
> */
> _initUI: function () {
> this.document = this.window.document;
> this.rootElement = this.document.documentElement;
> - this.NEW_CONSOLE_OUTPUT_ENABLED = !this.isBrowserConsole
> + this.NEW_CONSOLE_OUTPUT_ENABLED = !this.owner.target.chrome &&
This bug is for the Browser Toolbox but this patch is actually covering the Browser Console path.
I'm not sure if we want to do both in this bug. If so we'd need to get rid of the `!this.owner.target.chrome` condition as well. If not then we should make a new bug for the browser console. Let's chat about this next week before making a decision.
Attachment #8862433 -
Flags: review?(bgrinstead)
Updated•8 years ago
|
Iteration: 55.4 - May 1 → 55.5 - May 15
Comment 8•8 years ago
|
||
When fixing this bug, we should copy devtools/client/webconsole/test/browser_console_nsiconsolemessage.js to devtools/client/webconsole/new-console-output/test/mochitest/ to ensure everything is working.
Updated•8 years ago
|
Iteration: 55.5 - May 15 → 55.6 - May 29
Updated•7 years ago
|
Iteration: 55.6 - May 29 → 55.7 - Jun 12
Updated•7 years ago
|
Iteration: 55.7 - Jun 12 → 56.1 - Jun 26
Updated•7 years ago
|
Iteration: 56.1 - Jun 26 → 56.2 - Jul 10
Updated•7 years ago
|
Iteration: 56.2 - Jul 10 → 56.3 - Jul 24
Updated•7 years ago
|
Assignee: odvarko → nobody
Status: ASSIGNED → NEW
Iteration: 56.3 - Jul 24 → ---
Priority: P1 → P3
Whiteboard: [console-html] → [reserve-console-html]
Updated•7 years ago
|
Priority: P3 → P4
Updated•7 years ago
|
Flags: qe-verify+
Priority: P4 → P2
QA Contact: iulia.cristescu
Whiteboard: [reserve-console-html] → [newconsole-mvp]
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8862433 -
Attachment is obsolete: true
Updated•7 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8961432 [details]
Bug 1347127 - Enable new console frontend in Browser Toolbox;
https://reviewboard.mozilla.org/r/230180/#review235822
Attachment #8961432 -
Flags: review?(nchevobbe) → review+
Comment 11•7 years ago
|
||
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ef446fff8e6
Enable new console frontend in Browser Toolbox;r=nchevobbe
Comment 12•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•7 years ago
|
Keywords: dev-doc-needed
Comment 13•7 years ago
|
||
Maybe worth a release note? Not sure how that's requested nowadays, though.
Sebastian
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 14•7 years ago
|
||
(In reply to Sebastian Zartner [:sebo] from comment #13)
> Maybe worth a release note? Not sure how that's requested nowadays, though.
>
> Sebastian
I don't think this alone warrants a release note, but this combined with the Browser Console switching (currently on in nightly but will be switched to ride the train in bug 1362023) does. I'll ask for relnote on that bug when we land it.
Flags: needinfo?(bgrinstead)
Updated•6 years ago
|
Product: Firefox → DevTools
Comment 15•6 years ago
|
||
I've added a note to the Fx61 rel notes:
https://developer.mozilla.org/en-US/Firefox/Releases/61#Developer_tools
Does this sound accurate? Of course, there is the bigger task of updating all the screenshots in the devtools documentation to show the new console UI, but I've not got time for this now. I'm going to add this to the long term devtools docs plan.
Flags: needinfo?(bgrinstead)
Keywords: dev-doc-needed → dev-doc-complete
Assignee | ||
Comment 16•6 years ago
|
||
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #15)
> I've added a note to the Fx61 rel notes:
>
> https://developer.mozilla.org/en-US/Firefox/Releases/61#Developer_tools
>
> Does this sound accurate? Of course, there is the bigger task of updating
> all the screenshots in the devtools documentation to show the new console
> UI, but I've not got time for this now. I'm going to add this to the long
> term devtools docs plan.
Thanks! Instead of "The new-look Web/Browser Console UI has been enabled by default" I might say something like "The new Web Console UI has been enabled in the Browser Toolbox and Browser Console" to clarify that this isn't a change to the normal devtools toolbox (where the new UI has been enabled for a few releases already).
Flags: needinfo?(bgrinstead)
You need to log in
before you can comment on or make changes to this bug.
Description
•