1308032 - Cache::Memcached::Fast from bugzilla bug 1189281 and bug 1274764

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Description

[Dylan Hardison [:dylan] (he/him)]

This is quite a performance win especially with bug 1274764.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1308032_1.patch

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8798234 [details] [diff] [review]
1308032_1.patch

Review of attachment 8798234 [details] [diff] [review]:
-----------------------------------------------------------------

Otherwise works once I make the suggested changed. Fix on commit. r=dkl

::: Bugzilla/Memcached.pm
@@ -28,4 @@
>  
>      # always return an object to simplify calling code when memcached is
>      # disabled.
> -    my $servers = Bugzilla->get_param_with_override('memcached_servers');

Do not remove this line as we still need to be able to override in localconfig.

@@ +37,2 @@
>                  namespace => $self->{namespace},
>              });

Need 

require Cache::Memcached::Fast;

::: Makefile.PL
@@ +120,4 @@
>      memcached => {
>          description => 'Memcached Support',
>          prereqs     => {
> +            runtime => { requires => { 'Cache::Memcached::Fast' => '0.17' } }

Add to 'bmo' feature.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8798234 [details] [diff] [review]
1308032_1.patch

(In reply to David Lawrence [:dkl] from comment #2)
> Comment on attachment 8798234 [details] [diff] [review]
> 1308032_1.patch
> 
> Review of attachment 8798234 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> @@ +37,2 @@
> >                  namespace => $self->{namespace},
> >              });
> 
> Need 
> 
> require Cache::Memcached::Fast;

This was due to not re-running 'perl Makefile.PL' after applying the patch to regenerate MYMETA.*. After doing that the above fix is not needed as the module is loaded by Bugzilla->feature.

I will need to add the command to 'bz patch' in order to not have this issue in the future.

Other fixes can be done on commit.

dkl

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1308032_2.patch

Quick sanity check please.

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8799462 [details] [diff] [review]
1308032_2.patch

Review of attachment 8799462 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 6

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   b14f11a..9f4d372  master -> master