1308239 - Remove CSS pref layout.css.masking.enabled (for mask-type property)

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Astley Chen (inactive)]

mask-type prop support for SVG <mask> element was enabled since 2012. It seems that the corresponding preference control is no longer needed now.

Comment 1

[Astley Chen (inactive)]

Attachment: Bug 1308239 : Remove CSS mask-type pref layout.css.masking.enabled.

Review commit: https://reviewboard.mozilla.org/r/83964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83964/

Comment 2

[Astley Chen (inactive)]

TRYing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbd428e614ea

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8798481 [details]
Bug 1308239 : Remove CSS mask-type pref layout.css.masking.enabled.

https://reviewboard.mozilla.org/r/83964/#review82998

Thanks, this pref has been enabled by default since 2014, so is overdue for removal.

::: layout/style/test/property_database.js
(Diff revision 1)
> -if (IsCSSPropertyPrefEnabled("layout.css.masking.enabled")) {
> -  gCSSProperties["mask-type"] = {
> +gCSSProperties["mask-type"] = {
> -    domProp: "maskType",
> +  domProp: "maskType",
> -    inherited: false,
> +  inherited: false,
> -    type: CSS_TYPE_LONGHAND,
> +  type: CSS_TYPE_LONGHAND,
> -    initial_values: [ "luminance" ],
> +  initial_values: [ "luminance" ],
> -    other_values: [ "alpha" ],
> +  other_values: [ "alpha" ],
> -    invalid_values: []
> +  invalid_values: []
> -  };
> +};
> -}

Please move this definition up to the main statement that assigns to gCSSProperties.

Comment 4

[Astley Chen (inactive)]

Comment on attachment 8798481 [details]
Bug 1308239 : Remove CSS mask-type pref layout.css.masking.enabled.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/83964/diff/1-2/

Comment 5

[Astley Chen (inactive)]

Comment on attachment 8798481 [details]
Bug 1308239 : Remove CSS mask-type pref layout.css.masking.enabled.

https://reviewboard.mozilla.org/r/83964/#review82998

> Please move this definition up to the main statement that assigns to gCSSProperties.

Updated, thanks for pointing it out. :)

Comment 6

[Astley Chen (inactive)]

Need an update on MDN page: https://developer.mozilla.org/en-US/docs/Web/CSS/mask-type

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c44ee9cb3ba8
Remove CSS mask-type pref layout.css.masking.enabled. r=heycam

Comment 8

[Tim Nguyen :ntim]

(In reply to Astley Chen [:astley] (UTC+8) from comment #6)
> Need an update on MDN page:
> https://developer.mozilla.org/en-US/docs/Web/CSS/mask-type

Updated.

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c44ee9cb3ba8