Remove CSS pref layout.css.masking.enabled (for mask-type property)

RESOLVED FIXED in Firefox 52

Status

()

Core
Layout
P3
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Astley Chen (inactive), Assigned: Astley Chen (inactive))

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla52
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
mask-type prop support for SVG <mask> element was enabled since 2012. It seems that the corresponding preference control is no longer needed now.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 years ago
TRYing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbd428e614ea
Assignee: nobody → aschen
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Attachment #8798481 - Flags: review?(cam)
(Assignee)

Updated

2 years ago
Priority: -- → P3

Comment 3

2 years ago
mozreview-review
Comment on attachment 8798481 [details]
Bug 1308239 : Remove CSS mask-type pref layout.css.masking.enabled.

https://reviewboard.mozilla.org/r/83964/#review82998

Thanks, this pref has been enabled by default since 2014, so is overdue for removal.

::: layout/style/test/property_database.js
(Diff revision 1)
> -if (IsCSSPropertyPrefEnabled("layout.css.masking.enabled")) {
> -  gCSSProperties["mask-type"] = {
> +gCSSProperties["mask-type"] = {
> -    domProp: "maskType",
> +  domProp: "maskType",
> -    inherited: false,
> +  inherited: false,
> -    type: CSS_TYPE_LONGHAND,
> +  type: CSS_TYPE_LONGHAND,
> -    initial_values: [ "luminance" ],
> +  initial_values: [ "luminance" ],
> -    other_values: [ "alpha" ],
> +  other_values: [ "alpha" ],
> -    invalid_values: []
> +  invalid_values: []
> -  };
> +};
> -}

Please move this definition up to the main statement that assigns to gCSSProperties.
Attachment #8798481 - Flags: review?(cam) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 5

2 years ago
mozreview-review-reply
Comment on attachment 8798481 [details]
Bug 1308239 : Remove CSS mask-type pref layout.css.masking.enabled.

https://reviewboard.mozilla.org/r/83964/#review82998

> Please move this definition up to the main statement that assigns to gCSSProperties.

Updated, thanks for pointing it out. :)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

2 years ago
Need an update on MDN page: https://developer.mozilla.org/en-US/docs/Web/CSS/mask-type
Keywords: dev-doc-needed

Comment 7

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c44ee9cb3ba8
Remove CSS mask-type pref layout.css.masking.enabled. r=heycam
Keywords: checkin-needed

Comment 8

2 years ago
(In reply to Astley Chen [:astley] (UTC+8) from comment #6)
> Need an update on MDN page:
> https://developer.mozilla.org/en-US/docs/Web/CSS/mask-type

Updated.
Keywords: dev-doc-needed

Updated

2 years ago
Keywords: dev-doc-complete

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c44ee9cb3ba8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Updated

2 years ago
Blocks: 1312613
Summary: Remove CSS pref layout.css.masking.enabled → Remove CSS pref layout.css.masking.enabled (for mask-type property)
You need to log in before you can comment on or make changes to this bug.