Closed Bug 1308239 Opened 5 years ago Closed 5 years ago

Remove CSS pref layout.css.masking.enabled (for mask-type property)

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: bmo, Assigned: bmo)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

mask-type prop support for SVG <mask> element was enabled since 2012. It seems that the corresponding preference control is no longer needed now.
TRYing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbd428e614ea
Assignee: nobody → aschen
Status: NEW → ASSIGNED
Attachment #8798481 - Flags: review?(cam)
Priority: -- → P3
Comment on attachment 8798481 [details]
Bug 1308239 : Remove CSS mask-type pref layout.css.masking.enabled.

https://reviewboard.mozilla.org/r/83964/#review82998

Thanks, this pref has been enabled by default since 2014, so is overdue for removal.

::: layout/style/test/property_database.js
(Diff revision 1)
> -if (IsCSSPropertyPrefEnabled("layout.css.masking.enabled")) {
> -  gCSSProperties["mask-type"] = {
> +gCSSProperties["mask-type"] = {
> -    domProp: "maskType",
> +  domProp: "maskType",
> -    inherited: false,
> +  inherited: false,
> -    type: CSS_TYPE_LONGHAND,
> +  type: CSS_TYPE_LONGHAND,
> -    initial_values: [ "luminance" ],
> +  initial_values: [ "luminance" ],
> -    other_values: [ "alpha" ],
> +  other_values: [ "alpha" ],
> -    invalid_values: []
> +  invalid_values: []
> -  };
> +};
> -}

Please move this definition up to the main statement that assigns to gCSSProperties.
Attachment #8798481 - Flags: review?(cam) → review+
Comment on attachment 8798481 [details]
Bug 1308239 : Remove CSS mask-type pref layout.css.masking.enabled.

https://reviewboard.mozilla.org/r/83964/#review82998

> Please move this definition up to the main statement that assigns to gCSSProperties.

Updated, thanks for pointing it out. :)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c44ee9cb3ba8
Remove CSS mask-type pref layout.css.masking.enabled. r=heycam
Keywords: checkin-needed
(In reply to Astley Chen [:astley] (UTC+8) from comment #6)
> Need an update on MDN page:
> https://developer.mozilla.org/en-US/docs/Web/CSS/mask-type

Updated.
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/c44ee9cb3ba8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Summary: Remove CSS pref layout.css.masking.enabled → Remove CSS pref layout.css.masking.enabled (for mask-type property)
Depends on: 1308904
You need to log in before you can comment on or make changes to this bug.