Closed Bug 1308450 Opened 5 years ago Closed 5 years ago

[meta] Integrate HTTPi into the Net panel

Categories

(DevTools :: Netmonitor, defect)

defect
Not set
normal

Tracking

(firefox52 affected)

RESOLVED DUPLICATE of bug 1317645
Tracking Status
firefox52 --- affected

People

(Reporter: rickychien, Unassigned)

References

(Depends on 4 open bugs)

Details

HTTPi should be used in the Net panel and replace the current sidebar. HTTPi components should be moved into netmonitor/shared directory. These are going to be shared by the Console panel as well as the Net panel.

This task can be further split into:

- Copy HTTPi code into netmonitor/shared panel directory
- Make RequestItem expandable (hidden behind a pref)
- Implement Timings Panel
- Implement Security Panel
- Remove NetworkDetailsView tabs + Make RequestItem expandable by default (removing the pref)
- Introduce an option for switching between expandability and sidebar HTTP preview
Whiteboard: [devtools-html]
Depends on: 1307667
Depends on: 1309185
Depends on: 1309186
Depends on: 1309187
Depends on: 1309188
Depends on: 1309189
Depends on: 1309190
Whiteboard: [netmonitor]
Flags: qe-verify+
QA Contact: ciprian.georgiu
Priority: -- → P2
Depends on: 1317077
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Iteration: --- → 53.1 - Nov 28
Priority: P2 → P1
Depends on: 1317645
Depends on: 1317648
Depends on: 1317649
Depends on: 1317650
Depends on: 1317651
Depends on: 1317659
My current plan is put headers-tab, cookies-tab, params-tab, response-tab into netmonitor/components/net and bring related tests.

We can replace each tab in
https://github.com/mozilla/gecko-dev/blob/master/devtools/client/netmonitor/netmonitor-view.js#L484
with react components, then introduce TabBar/Toolbar to replace the whole Sidebar tabs.

webconsole has the Post Tab `devtools/client/webconsole/net/components/post-tab` and we may consider bring it to the netmonitor as well.

we may consider bring DataProvider from webconsole/net for data backend once we know the code relation better.
according to honza's feedback, the Post Tab content is within the params tab in netmonitor.
(In reply to Fred Lin [:gasolin] from comment #1)
> My current plan is put headers-tab, cookies-tab, params-tab, response-tab
> into netmonitor/components/net and bring related tests.
> 
> We can replace each tab in
> https://github.com/mozilla/gecko-dev/blob/master/devtools/client/netmonitor/
> netmonitor-view.js#L484
> with react components, then introduce TabBar/Toolbar to replace the whole
> Sidebar tabs.
Yep, I like it. When refactoring stuff in netmonitor-view.js we should take
every opportunity to move stuff out to an independent module.

> webconsole has the Post Tab
> `devtools/client/webconsole/net/components/post-tab` and we may consider
> bring it to the netmonitor as well.
We discussed this at the meeting so, just for the record. I like having
Post tab in the side panel but, we should focus on refactoring first.
UI/UX changes can be introduced later.

> we may consider bring DataProvider from webconsole/net for data backend once
> we know the code relation better.
Agree


Honza
About the discussion of how to copy HTTPi components into netmonitor (comment 1 ~ comment 3) should continue in bug 1309185.

I think this bug should be treated as a meta bug since it depends on many breakdown tasks. Please take a look at the bug dependency tree https://bugzilla.mozilla.org/showdependencytree.cgi?id=1308450&hide_resolved=1.

Base on dependency tree, there are four tasks have been moved to "Reserve Backlog" in tracking dashboard such as:

* Bug 1307667 - [UX] Unifying HTTP inspector UX between netmonitor and the new web console
* Bug 1309186 - Make RequestItem expandable (hidden behind a pref)
* Bug 1309189 - Remove NetworkDetailsView tabs + Make RequestItem expandable by default (removing the pref)
* Bug 1309190 - Introduce an option for switching between expandability and sidebar HTTP preview

So the goal for this meta will focus on copying HTTPi code and implementing sidebar refactoring

* Bug 1309185 - Copy HTTPi code into netmonitor/shared panel directory
* Bug 1317645 - Implement sidebar view (network details view)

Marco, would you do me a favor to set this bug as a meta? thanks :)
Flags: needinfo?(mmucci)
Will do, thanks Ricky.
Assignee: gasolin → nobody
Status: ASSIGNED → NEW
Iteration: 53.1 - Nov 28 → ---
Flags: qe-verify+
Flags: needinfo?(mmucci)
Keywords: meta
Priority: P1 → --
QA Contact: ciprian.georgiu
Summary: Integrate HTTPi into the Net panel → [meta] Integrate HTTPi into the Net panel
Whiteboard: [netmonitor]
Actually Timings, Security, Preview tab can be work separately without HTTPi integration
No longer depends on: 1309187, 1309188, 1317659
Setting the priority field so, this bug doesn't look like untriaged.

Honza
Priority: -- → P2
I'd like to close this bug since sidebar detail panel was completed in bug 1317645.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1317645
No longer blocks: netmonitor-html
Keywords: meta
Priority: P2 → --
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.