1308450 - [meta] Integrate HTTPi into the Net panel

Status: RESOLVED DUPLICATE of bug 1317645

(DevTools :: Netmonitor, defect)

Description

[Ricky Chien [:rickychien] (inactive)]

HTTPi should be used in the Net panel and replace the current sidebar. HTTPi components should be moved into netmonitor/shared directory. These are going to be shared by the Console panel as well as the Net panel.

This task can be further split into:

- Copy HTTPi code into netmonitor/shared panel directory
- Make RequestItem expandable (hidden behind a pref)
- Implement Timings Panel
- Implement Security Panel
- Remove NetworkDetailsView tabs + Make RequestItem expandable by default (removing the pref)
- Introduce an option for switching between expandability and sidebar HTTP preview

Comment 1

[[e-mail]]

My current plan is put headers-tab, cookies-tab, params-tab, response-tab into netmonitor/components/net and bring related tests.

We can replace each tab in
https://github.com/mozilla/gecko-dev/blob/master/devtools/client/netmonitor/netmonitor-view.js#L484
with react components, then introduce TabBar/Toolbar to replace the whole Sidebar tabs.

webconsole has the Post Tab `devtools/client/webconsole/net/components/post-tab` and we may consider bring it to the netmonitor as well.

we may consider bring DataProvider from webconsole/net for data backend once we know the code relation better.

Comment 2

[[e-mail]]

according to honza's feedback, the Post Tab content is within the params tab in netmonitor.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Fred Lin [:gasolin] from comment #1)
> My current plan is put headers-tab, cookies-tab, params-tab, response-tab
> into netmonitor/components/net and bring related tests.
> 
> We can replace each tab in
> https://github.com/mozilla/gecko-dev/blob/master/devtools/client/netmonitor/
> netmonitor-view.js#L484
> with react components, then introduce TabBar/Toolbar to replace the whole
> Sidebar tabs.
Yep, I like it. When refactoring stuff in netmonitor-view.js we should take
every opportunity to move stuff out to an independent module.

> webconsole has the Post Tab
> `devtools/client/webconsole/net/components/post-tab` and we may consider
> bring it to the netmonitor as well.
We discussed this at the meeting so, just for the record. I like having
Post tab in the side panel but, we should focus on refactoring first.
UI/UX changes can be introduced later.

> we may consider bring DataProvider from webconsole/net for data backend once
> we know the code relation better.
Agree


Honza

Comment 4

[Ricky Chien [:rickychien] (inactive)]

About the discussion of how to copy HTTPi components into netmonitor (comment 1 ~ comment 3) should continue in bug 1309185.

I think this bug should be treated as a meta bug since it depends on many breakdown tasks. Please take a look at the bug dependency tree https://bugzilla.mozilla.org/showdependencytree.cgi?id=1308450&hide_resolved=1.

Base on dependency tree, there are four tasks have been moved to "Reserve Backlog" in tracking dashboard such as:

* Bug 1307667 - [UX] Unifying HTTP inspector UX between netmonitor and the new web console
* Bug 1309186 - Make RequestItem expandable (hidden behind a pref)
* Bug 1309189 - Remove NetworkDetailsView tabs + Make RequestItem expandable by default (removing the pref)
* Bug 1309190 - Introduce an option for switching between expandability and sidebar HTTP preview

So the goal for this meta will focus on copying HTTPi code and implementing sidebar refactoring

* Bug 1309185 - Copy HTTPi code into netmonitor/shared panel directory
* Bug 1317645 - Implement sidebar view (network details view)

Marco, would you do me a favor to set this bug as a meta? thanks :)

Comment 5

[Marco Mucci [:MarcoM]]

Will do, thanks Ricky.

Comment 6

[[e-mail]]

Actually Timings, Security, Preview tab can be work separately without HTTPi integration

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Setting the priority field so, this bug doesn't look like untriaged.

Honza

Comment 8

[Ricky Chien [:rickychien] (inactive)]

I'd like to close this bug since sidebar detail panel was completed in bug 1317645.