Move sharable basic components from netmonitor to shared

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
2 years ago
7 months ago

People

(Reporter: rickychien, Unassigned)

Tracking

Trunk

Firefox Tracking Flags

(firefox52 affected)

Details

This is a breakdown task for bug 1308450 in order to integrate HTTP inspector into the Net panel.

- Copy HTTPi code into netmonitor/shared panel directory
Blocks: 1307743
Whiteboard: [netmonitor]
Flags: qe-verify-
Priority: -- → P2

Updated

2 years ago
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Iteration: --- → 53.1 - Nov 28
Priority: P2 → P1
need update devtools/docs/http-inspector.md as well
Follow the discussion from bug 1308450 comment 1,

On contrary to DataProvider from webconsole/net, all related backend request in netmonitor are done with gNetwork, which is a shortcut for NetmonitorController::NetworkEventsHandler. Since it still works well, we can focus on UI refactoring at this moment.

Then I found more difference in webconsole/net

1. layout difference
2. style are hard coded in webconsole/net components
3. 10n: webconsole/net components use Locale.$STR to get l10n strings

Therefore instead of `Copy` webconsole/net, 
I'll start from porting a smaller portion of webconsole/net components to netmonitor/components/net/ and replace the current UI. It means porting Cookie tab in Bug 1317649, which includes cookie-tab, net-info-group-list, net-info-group, spinner components, related styles and tests
(In reply to Fred Lin [:gasolin] from comment #2)
> I'll start from porting a smaller portion of webconsole/net components to
> netmonitor/components/net/ and replace the current UI. It means porting
> Cookie tab in Bug 1317649, which includes cookie-tab, net-info-group-list,
> net-info-group, spinner components, related styles and tests
Sounds good to me, thanks Fred.

Honza
Fred, 

After discussing, we've agreed that it makes sense to port HTTP inspector from webconsole in each sub-panel bug (as you mentioned on comment 2). 

In order to avoid confusing, would you close this bug? Perhaps I think the bug might be reusable for the last step to move HTTPi component from netmonitor to shared folder once the HTTPi is completed and becomes stable. If the second option makes sense to you, please unassign yourself and change the bug title to something like "Move HTTPi component from netmonitor to shared":)
Flags: needinfo?(gasolin)
Good suggestion. Though in practice I think we should keep HTTPi related components inside the netmonitor and only move reusable basic components to /share.

Marco, as a result we can remove this from MVP bug and discuss what can be added in next Monday's meeting
Flags: needinfo?(gasolin) → needinfo?(mmucci)
Summary: Copy HTTPi code into netmonitor/shared panel directory → Move sharable basic components from netmonitor to shared
Hi Fred.  To confirm, would you like this bug moved from the current release to the MVP backlog, removed to the reserve backlog or removed from the project altogether?
Flags: needinfo?(mmucci) → needinfo?(gasolin)
I'd like move this into reserve backlog, thanks
Assignee: gasolin → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(gasolin)
Iteration: 53.1 - Nov 28 → ---
Priority: P1 → P3
Whiteboard: [netmonitor] → [netmonitor-reserve]
Priority: P3 → P4
We have implemented all HTTP inspector panels in netmonitor
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
No longer blocks: 1307743
Flags: qe-verify-
Priority: P4 → --
Whiteboard: [netmonitor-reserve]

Updated

7 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.