Intermittent e10s dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 12, expected 11

RESOLVED FIXED in Firefox 52

Status

()

defect
P5
normal
RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: aryx, Assigned: dholbert)

Tracking

(Blocks 1 bug, {intermittent-failure})

Trunk
mozilla54
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox52 fixed, firefox-esr52 fixed, firefox53 fixed, firefox54 fixed)

Details

(Whiteboard: [stockwell fixed])

Attachments

(2 attachments)

+++ This bug was initially created as a clone of Bug #1224873 +++

https://treeherder.mozilla.org/logviewer.html#?job_id=4702412&repo=autoland

12:05:00     INFO -  480 INFO TEST-START | dom/base/test/browser_use_counters.js
12:05:25     INFO -  TEST-INFO | started process screenshot
12:05:25     INFO -  TEST-INFO | screenshot: exit 0
12:05:25     INFO -  481 INFO checking window state
12:05:25     INFO -  482 INFO Entering test bound test_initialize
12:05:25     INFO -  483 INFO canRecord for content: true
12:05:25     INFO -  484 INFO Leaving test bound test_initialize
12:05:25     INFO -  485 INFO Entering test bound
12:05:25     INFO -  486 INFO checking file_use_counter_svg_getElementById.svg with histogram SVGSVGELEMENT_GETELEMENTBYID
12:05:25     INFO -  487 INFO TEST-PASS | dom/base/test/browser_use_counters.js | page counts for SVGSVGELEMENT_GETELEMENTBYID after are correct -
12:05:25     INFO -  488 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  489 INFO TEST-PASS | dom/base/test/browser_use_counters.js | document counts for SVGSVGELEMENT_GETELEMENTBYID after are correct -
12:05:25     INFO -  490 INFO checking file_use_counter_svg_currentScale.svg with histogram SVGSVGELEMENT_CURRENTSCALE_getter
12:05:25     INFO -  491 INFO TEST-PASS | dom/base/test/browser_use_counters.js | page counts for SVGSVGELEMENT_CURRENTSCALE_getter after are correct -
12:05:25     INFO -  492 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  493 INFO TEST-PASS | dom/base/test/browser_use_counters.js | document counts for SVGSVGELEMENT_CURRENTSCALE_getter after are correct -
12:05:25     INFO -  494 INFO checking file_use_counter_svg_currentScale.svg with histogram SVGSVGELEMENT_CURRENTSCALE_setter
12:05:25     INFO -  495 INFO TEST-PASS | dom/base/test/browser_use_counters.js | page counts for SVGSVGELEMENT_CURRENTSCALE_setter after are correct -
12:05:25     INFO -  496 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  497 INFO TEST-PASS | dom/base/test/browser_use_counters.js | document counts for SVGSVGELEMENT_CURRENTSCALE_setter after are correct -
12:05:25     INFO -  498 INFO checking file_use_counter_svg_getElementById.svg with histogram SVGSVGELEMENT_GETELEMENTBYID
12:05:25     INFO -  499 INFO TEST-PASS | dom/base/test/browser_use_counters.js | page counts for SVGSVGELEMENT_GETELEMENTBYID after are correct -
12:05:25     INFO -  500 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  501 INFO checking file_use_counter_svg_currentScale.svg with histogram SVGSVGELEMENT_CURRENTSCALE_getter
12:05:25     INFO -  502 INFO TEST-PASS | dom/base/test/browser_use_counters.js | page counts for SVGSVGELEMENT_CURRENTSCALE_getter after are correct -
12:05:25     INFO -  503 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  504 INFO checking file_use_counter_svg_currentScale.svg with histogram SVGSVGELEMENT_CURRENTSCALE_setter
12:05:25     INFO -  505 INFO TEST-PASS | dom/base/test/browser_use_counters.js | page counts for SVGSVGELEMENT_CURRENTSCALE_setter after are correct -
12:05:25     INFO -  506 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  507 INFO checking file_use_counter_svg_getElementById.svg as image with histogram PROPERTY_FILL
12:05:25     INFO -  508 INFO TEST-PASS | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILL after are correct -
12:05:25     INFO -  509 INFO TEST-PASS | dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILL after are correct -
12:05:25     INFO -  510 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  511 INFO TEST-PASS | dom/base/test/browser_use_counters.js | document counts are correct -
12:05:25     INFO -  512 INFO checking file_use_counter_svg_currentScale.svg as image with histogram PROPERTY_FILL
12:05:25     INFO -  513 INFO TEST-PASS | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILL after are correct -
12:05:25     INFO -  514 INFO TEST-PASS | dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILL after are correct -
12:05:25     INFO -  515 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  516 INFO TEST-PASS | dom/base/test/browser_use_counters.js | document counts are correct -
12:05:25     INFO -  517 INFO checking file_use_counter_svg_fill_pattern.svg with histogram PROPERTY_FILLOPACITY
12:05:25     INFO -  518 INFO TEST-FAIL | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILLOPACITY after are correct -
12:05:25     INFO -  519 INFO TEST-FAIL | dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILLOPACITY after are correct -
12:05:25     INFO -  520 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  521 INFO TEST-PASS | dom/base/test/browser_use_counters.js | document counts are correct -
12:05:25     INFO -  522 INFO checking file_use_counter_svg_fill_pattern_internal.svg with histogram PROPERTY_FILLOPACITY
12:05:25     INFO -  523 INFO TEST-PASS | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILLOPACITY after are correct -
12:05:25     INFO -  524 INFO TEST-PASS | dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILLOPACITY after are correct -
12:05:25     INFO -  525 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  526 INFO TEST-PASS | dom/base/test/browser_use_counters.js | document counts are correct -
12:05:25     INFO -  527 INFO checking file_use_counter_svg_list_style_image.html with histogram PROPERTY_FILL
12:05:25     INFO -  528 INFO TEST-PASS | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILL after are correct -
12:05:25     INFO -  529 INFO TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct -
12:05:25     INFO -  530 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 12, expected 11
12:05:25     INFO -  Stack trace:
12:05:25     INFO -      chrome://mochikit/content/browser-test.js:test_is:905
12:05:25     INFO -      chrome://mochitests/content/browser/dom/base/test/browser_use_counters.js:check_use_counter_iframe<:189
12:05:25     INFO -      @chrome://mochitests/content/browser/dom/base/test/browser_use_counters.js:78:9
12:05:25     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:322:42
12:05:25     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
12:05:25     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
12:05:25     INFO -      Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
12:05:25     INFO -      this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
12:05:25     INFO -      this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
12:05:25     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:327:15
12:05:25     INFO -      Async*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:399:7
12:05:25     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:330:15
12:05:25     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
12:05:25     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
12:05:25     INFO -      Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
12:05:25     INFO -      this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
12:05:25     INFO -      this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
12:05:25     INFO -      SpecialPowersAPI.prototype.exactGC/genGCCallback/<@chrome://mochikit/content/tests/SimpleTest/specialpowersAPI.js:1518:11
froydnj, do you know what might be happening here?
Flags: needinfo?(nfroyd)
(In reply to Daniel Holbert [:dholbert] from comment #1)
> froydnj, do you know what might be happening here?

I guess this is the situation you alluded to in bug 1224873 comment 38, where you were surprised that list-style-image with SVG images wasn't hitting the same intermittent failures as using SVG images for a background image.  Guess we get to delete this test, too?
Flags: needinfo?(nfroyd)
See Also: → 1301257
(In reply to Nathan Froyd [:froydnj] from comment #2)
> I guess this is the situation you alluded to in bug 1224873 comment 38,
> where you were surprised that list-style-image with SVG images wasn't
> hitting the same intermittent failures as using SVG images for a background
> image.  Guess we get to delete this test, too?
Flags: needinfo?(dholbert)
Thanks, RyanVM. Yeah, I think froydnj is right that this is the same issue.

HOWEVER, it's not quite as simple as "guess we get to delete this test too". In the other bug, we deleted the test because we already had svg-as-image coverage for use counters.  But here, I think this is the last SVG-as-image-coverage test.  (We have other SVG coverage, but not *SVG-as-an-image* coverage beyond this test.)

However, I'm coming up with a patch that tweaks this test such that it'll pass. Stay tuned.
(In reply to Daniel Holbert [:dholbert] from comment #18)
> But here, I think this is the last
> SVG-as-image-coverage test.  (We have other SVG coverage, but not
> *SVG-as-an-image* coverage beyond this test.)

Ah! I was wrong -- I misread the test.  browser_use_counters.js does indeed have two tests for use-counter-flushing in SVG images -- its calls to "check_use_counter_img".  So we're good to remove this list-style-image piece of the test after all.
(just re-pushed to update my original patches with some minor commit message tweaks)
Flags: needinfo?(dholbert)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment on attachment 8834649 [details]
Bug 1308610 part 0: Remove no-longer-used mochitest helper file "file_use_counter_svg_background.html".

https://reviewboard.mozilla.org/r/110504/#review112042
Attachment #8834649 - Flags: review?(nfroyd) → review+
Comment on attachment 8834650 [details]
Bug 1308610 part 1: Remove use-counter mochitest's flaky chunk about testing counters in SVG "list-style-image" docs.

https://reviewboard.mozilla.org/r/110506/#review112044

Thanks!
Attachment #8834650 - Flags: review?(nfroyd) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3711f6ee47a8
part 0: Remove no-longer-used mochitest helper file "file_use_counter_svg_background.html". r=froydnj
https://hg.mozilla.org/integration/autoland/rev/5e64a0332bc6
part 1: Remove use-counter mochitest's flaky chunk about testing counters in SVG "list-style-image" docs. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/3711f6ee47a8
https://hg.mozilla.org/mozilla-central/rev/5e64a0332bc6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Whiteboard: [stockwell fixed]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.