1308629 - Firefox goes Not Responding (or crashes) on Quit

Status: RESOLVED INCOMPLETE

(Core :: Audio/Video: Playback, defect, P2)

Description

[Steve Chessin]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160817112116

Steps to reproduce:

Command-Q to Firefox


Actual results:

All the Firefox windows closed, but Firefox itself did not exit. Activity Monitor showed it Not Responding. I had to Force Quit it. (On occasion, a second Quit through Activity Monitor, instead of a Force Quit, would cause it to crash, with Crash Reporter opening up.)


Expected results:

It should have eventually exited.

Comment 1

[Steve Chessin]

These are the URLs of the crash reports:
https://crash-stats.mozilla.com/report/index/284cd420-9fe9-4714-85dc-bd9d02161007
https://crash-stats.mozilla.com/report/index/bf0cf5f3-c41e-4e3d-9c43-6e0312161004
https://crash-stats.mozilla.com/report/index/daee2dce-77b2-4b00-85b7-5d9642160922

Comment 2

[Steve Chessin]

Got another one today:
https://crash-stats.mozilla.com/report/index/bp-7a145b95-117f-4fc3-b2c4-66b462161010

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Jean-Yves - do you want this one?

Comment 4

[Emil Pasca [:emilpasca]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:49.0) Gecko/20100101 Firefox/49.0

I have tested this issue on Mac OS 10.9 x64 with the latest Firefox release (49.0.1) and the latest Nightly (52.0a1-20161011030212) and could not reproduce it.
After opening the browser, when closing it using the keyboard shortcut (Command-Q), the browser immediately closes, also when checking the Activity Monitor, the browser process doesn't show up after the window closes.

Based on the crash reports submitted  by the reporter I will move this to JavaScript Engine, maybe someone with extensive knowledge on this area could provide some feedback for this issue.

Comment 6

[Marco Castelluccio [:marco]]

There are several threads in mozilla::H264Converter::Init -> mozilla::AppleVTDecoder::Init -> mozilla::AppleVTDecoder::InitializeSession.

Comment 7

[Jean-Yves Avenard [:jya]]

Could you please retry in 50?

An issue with the AAC decoder was fixed there.

Comment 8

[Steve Chessin]

(In reply to Jean-Yves Avenard [:jya] from comment #7)
> Could you please retry in 50?
> 
> An issue with the AAC decoder was fixed there.

It happens with 50. See
https://crash-stats.mozilla.com/report/index/bp-ec6878c7-2ba8-4412-bcfb-75fb32161128

It may or may not be related to bug 1309012.

Comment 9

[Jean-Yves Avenard [:jya]]

Yeah, so we have a few Apple hardware h264 decoder stuck. 
Must be a bug in apple framework. The GPU on that very old mac could only handle a set number of decoders (4 Iirc). And we have exactly 4 stuck here.  

A mate of mine reported the same trouble on an old MacBook Air also with a nvidia gpu.

Comment 10

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Maybe we should also be running the Mac decoders in a compositor process.

Comment 11

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.

Comment 12

[Bulk Bug Changes for mreavy's org]

Mass change P1->P2 to align with new Mozilla triage process

Comment 13

[Steve Chessin]

Just wanted to let you know that Firefox still frequently crashes on Quit. Crash Reporter says it sends the report to Mozilla, but it's not clear to me that anyone actually receives it. (This was with 73.0.1 and 74.0.0. I just upgraded to 74.0.1 so don't know if it still happens.)

Comment 14

[Steve Chessin]

It still happens. It happened today with FF 78.0.2.

Comment 15

[Arthur K. (he/him)]

(In reply to Steve Chessin from comment #14)

It still happens. It happened today with FF 78.0.2.

Is this still an issue using 78.7.0 (or 85)?

Comment 16

[Steve Chessin]

(In reply to Arthur K. [He/Him/His] from comment #15)

(In reply to Steve Chessin from comment #14)

It still happens. It happened today with FF 78.0.2.

Is this still an issue using 78.7.0 (or 85)?

I'm still on 78.0.2. "About Firefox" tells me I'm up-to-date. When I Quit Firefox (which I do on a weekly basis, just prior to shutting down my MacBook so I can clean the screen and recover from various memory leaks), eventually Crash Reporter comes up and says it will send in the report and asks if I want to Quit or Restart Firefox. I tell it to Quit. I don't know if it actually submits the crash reports or not. about:crashes shows two unsubmitted crash reports since July 27, 2020, which is when I upgraded to 78.0.2. I'll submit them and clear the rest.

Comment 17

[Steve Chessin]

I scrolled down towards the bottom of about:crashes and see that it also lists Submitted Crash Reports. I see that it submitted reports on 1/25/21, 1/19/21, 1/18/21, 1/11/21, etc., so I guess Crash Reporter does submit the reports (since I didn't manually submit those). You learn something new every day :-).

Comment 18

[Arthur K. (he/him)]

(In reply to Steve Chessin from comment #16)

(In reply to Arthur K. [He/Him/His] from comment #15)

(In reply to Steve Chessin from comment #14)

It still happens. It happened today with FF 78.0.2.

Is this still an issue using 78.7.0 (or 85)?

I'm still on 78.0.2. "About Firefox" tells me I'm up-to-date. When I Quit Firefox (which I do on a weekly basis, just prior to shutting down my MacBook so I can clean the screen and recover from various memory leaks), eventually Crash Reporter comes up and says it will send in the report and asks if I want to Quit or Restart Firefox. I tell it to Quit. I don't know if it actually submits the crash reports or not. about:crashes shows two unsubmitted crash reports since July 27, 2020, which is when I upgraded to 78.0.2. I'll submit them and clear the rest.

That can't be working right if it's telling you 78.0.2 is current. Try going to https://www.thunderbird.net/en-US/thunderbird/all/ and grabbing the Mac version and updating manually and see what's up. I'm guessing you had a failed update and now it's stuck.

Comment 19

[Steve Chessin]

Why would I go to https://www.thunderbird.net/en-US/thunderbird/all/ to grab a version of Firefox?

Comment 20

[Arthur K. (he/him)]

(In reply to Steve Chessin from comment #19)

Why would I go to https://www.thunderbird.net/en-US/thunderbird/all/ to grab a version of Firefox?

Sorry, I was in the middle of looking at a Thunderbird bug when I wrote this. Here's a direct download for 78.7.0: https://ftp.mozilla.org/pub/firefox/releases/78.7.0esr/mac/en-US/Firefox%2078.7.0esr.dmg

Please try updating manually and see if it helps. Do report back.

Comment 21

[Wayne Mery (:wsmwk)]

(In reply to Steve Chessin from comment #13)

Just wanted to let you know that Firefox still frequently crashes on Quit.

Still happens?