Status

defect
P3
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: mt, Assigned: mt)

Tracking

({good-first-bug})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

We have a bunch of places that have name shadowing.  This is bad.

Try the attached patch.
Posted file Enable -Wshadow
Somehow I missed the patch.
Keywords: good-first-bug
Priority: -- → P3
Would love to give this a shot if someone can tell me how to get started!
Flags: needinfo?(martin.thomson)
So the first stage of this bug is to do the actual enable Wshadow in the build process. I would highly recommend looking at the patch submitted in Martin Thomson's final comment on this bug report. It has a patch that does most of the work on enabling Wshadow, though double check that this covers both build processes for NSS. Once you do that, just start trying to build the library, and when it throws and error, fix it. Rinse, repeat, submit resulting patch. Happy hacking!
Happy to review a patch if you could get this working.  Note that the patch I have here doesn't cover the gyp-based build, so that would need to be fixed at the same time as well (I would start there, since the gyp build will make the process Nick suggests MUCH faster).

Set need-info on me if you want to run your patch on our try servers.  You shouldn't need to; I'll just do that before landing.  Shadowing handling should be consistent across mac and linux, and this doesn't affect windows.
Flags: needinfo?(martin.thomson)
Comment on attachment 8950845 [details]
Bug 1309068 - Enable -Wshadow, r?franziskus

Franziskus Kiefer [:fkiefer or :franziskus] has approved the revision.

https://phabricator.services.mozilla.com/D594
Attachment #8950845 - Flags: review+
Comment on attachment 8950845 [details]
Bug 1309068 - Enable -Wshadow, r?franziskus

Franziskus Kiefer [:fkiefer or :franziskus] has been removed from the revision.

https://phabricator.services.mozilla.com/D594
Attachment #8950845 - Flags: review+
Comment on attachment 8950845 [details]
Bug 1309068 - Enable -Wshadow, r?franziskus

Franziskus Kiefer [:fkiefer or :franziskus] has approved the revision.

https://phabricator.services.mozilla.com/D594
Attachment #8950845 - Flags: review+
https://hg.mozilla.org/projects/nss/rev/942d28a4f3d561cb6ccdd4de2318396276a29258
Assignee: nobody → martin.thomson
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → 3.37
You need to log in before you can comment on or make changes to this bug.