1309126 - mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:906:47: error: no match for 'operator!='

Status: RESOLVED DUPLICATE of bug 1308548

(MailNews Core :: Security: S/MIME, defect)

Description

[Edmund Wong (:ewong)]

getting this bustage:

builds/slave/c-cen-t-lnx/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../x86_64-unknown-linux-gnu/bin/as: /lib64/libz.so.1: no version information available (required by /builds/slave/c-cen-t-lnx/build/gcc/bin/../lib/gcc/x86_64-unknown-linux-gnu/4.8.5/../../../../x86_64-unknown-linux-gnu/bin/as)
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp: In member function 'nsresult nsMsgComposeSecure::MimeCryptoHackCerts(const char*, nsIMsgSendReport*, bool, bool, nsIMsgIdentity*)':
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:906:47: error: no match for 'operator!=' (operand types are 'mozilla::pkix::Result' and '_SECStatus')
                                   builtChain) != SECSuccess)) {
                                               ^
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:906:47: note: candidates are:
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:906:47: note: operator!=(_SECStatus, _SECStatus) <built-in>
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:906:47: note:   no known conversion for argument 1 from 'mozilla::pkix::Result' to '_SECStatus'
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:906:47: note: operator!=(mozilla::pkix::Result, mozilla::pkix::Result) <built-in>
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:906:47: note:   no known conversion for argument 2 from '_SECStatus' to 'mozilla::pkix::Result'
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:928:47: error: no match for 'operator!=' (operand types are 'mozilla::pkix::Result' and '_SECStatus')
                                   builtChain) != SECSuccess)) {
                                               ^
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:928:47: note: candidates are:
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:928:47: note: operator!=(_SECStatus, _SECStatus) <built-in>
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:928:47: note:   no known conversion for argument 1 from 'mozilla::pkix::Result' to '_SECStatus'
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:928:47: note: operator!=(mozilla::pkix::Result, mozilla::pkix::Result) <built-in>
../../../../../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp:928:47: note:   no known conversion for argument 2 from '_SECStatus' to 'mozilla::pkix::Result'
make[4]: *** [nsMsgComposeSecure.o] Error 1
make[4]: *** Waiting for unfinished jobs....

Comment 1

[Edmund Wong (:ewong)]

probably related to: http://hg.mozilla.org/mozilla-central/rev/12c51a960f26

Comment 2

[Edmund Wong (:ewong)]

Attachment: proposed patch (v1)

Comment 3

[:Cykesiopka]

Comment on attachment 8799630 [details] [diff] [review]
proposed patch (v1)

Review of attachment 8799630 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/mime/src/nsCMS.cpp
@@ +288,1 @@
>      if (srv != SECSuccess) {

Just FYI, this won't compile - SECSuccess is a SECStatus, which isn't comparable to a mozilla::pkix::Result.