Closed
Bug 1309243
Opened 9 years ago
Closed 9 years ago
Params aren't shown as expected in the HTTP inspector
Categories
(DevTools :: Console, defect, P1)
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: andras, Assigned: Honza)
References
Details
(Keywords: testcase)
Attachments
(5 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36
Steps to reproduce:
I submitted a form, containing this:
<input type="checkbox" name="box[]" value="123" checked>
<input type="checkbox" name="box[]" value="456" checked>
Actual results:
In the web console, under POST tab, the Params section only show this:
box[] 123
Expected results:
box[] 123
box[] 456
In the Raw Data section both of them shows:
box%5B%5D=123&box%5B%5D=456
Updated•9 years ago
|
Component: Untriaged → Developer Tools: Console
Could you attach a simple testcase to reproduce the issue, please.
Flags: needinfo?(andras)
Keywords: testcase-wanted
Reporter | ||
Comment 2•9 years ago
|
||
Simple testcase: http://bogex.hu/test/webconsole.php
Keywords: testcase-wanted → testcase
Comment 4•9 years ago
|
||
He is not at the Network tab. He is at console, when POST happens, expand the data (not clicking on link, click on the arraw), and then POST tab.
There is only one param. This is a real bug.
I think you should disable or remove that from the FF because it could be confusing, let's force the users to use the Network tab.
AFAIK, it has been removed with the new experimental console in Nightly.
So I'd say the bug will be "fixed" in next versions of Firefox.
Comment 6•9 years ago
|
||
The plan is a little complex.
There are multiple views of the console. There is the web console, which most web developers use, and then there is the browser console and browser toolbox: https://developer.mozilla.org/en-US/docs/Tools/Browser_Console
The browser console does not have a net monitor. We will likely add this back in for the browser console but not in the web console.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Updated•9 years ago
|
Summary: Firefox developer edition web console issue → Params aren't shown as expected in the HTTP inspector
Assignee | ||
Comment 8•9 years ago
|
||
Patch attached.
- Make React key prop unique
- Extend and existing test to cover the bug
Thanks for the report!
Honza
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)
Attachment #8801697 -
Flags: review?(chevobbe.nicolas)
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Lin Clark [:linclark] from comment #6)
> The plan is a little complex.
>
> There are multiple views of the console. There is the web console, which
> most web developers use, and then there is the browser console and browser
> toolbox: https://developer.mozilla.org/en-US/docs/Tools/Browser_Console
>
> The browser console does not have a net monitor. We will likely add this
> back in for the browser console but not in the web console.
Lin, we are not putting the HTTP logs back into the web console? This was one of the most requested features in Firebug community and it was also one of the reasons why we had it in the Web Console. It would be great to have it back.
Honza
Flags: needinfo?(lclark)
Priority: P2 → P1
Comment 10•9 years ago
|
||
Patrick has already asked Bryan to decide this in Bug 1308219.
My personal feeling is that the current status (having two views on the same data) is confusing for users and that we should have a UX review before reimplementing everything as it is now. I leave the decision up to Bryan, though.
Flags: needinfo?(lclark)
Comment 11•9 years ago
|
||
Comment on attachment 8801697 [details] [diff] [review]
bug1309243.patch
Review of attachment 8801697 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me !
One minor thing on the test, but feel free to lands this as is.
::: devtools/client/webconsole/net/test/mochitest/browser_net_params.js
@@ +59,5 @@
> + let tabBody = yield selectNetInfoTab(hud, netInfoBody, "params");
> +
> + let params = tabBody.querySelectorAll(
> + ".netInfoParamName > span[title='box[]']");
> + is(params.length, 2, "Two URI parameters must exist");
could we check the content of each param too ? I don't really see how this could happen now, but it will prevent to be bitten by a refactor that would use the property name to retrieve the value for example.
No strong opinion on this, it would be an extra safety net
Attachment #8801697 -
Flags: review?(chevobbe.nicolas) → review+
Assignee | ||
Comment 12•9 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #11)
> could we check the content of each param too ? I don't really see how this
> could happen now, but it will prevent to be bitten by a refactor that would
> use the property name to retrieve the value for example.
> No strong opinion on this, it would be an extra safety net
Sure, done.
Thanks for the review!
Honza
Attachment #8801697 -
Attachment is obsolete: true
Attachment #8801760 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 13•9 years ago
|
||
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be0b952903d0
Use unique key property; r=nchevobbe
Keywords: checkin-needed
Comment 14•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•