1309243 - Params aren't shown as expected in the HTTP inspector

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Lay András]

Attachment: firefoxdeveloper.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36

Steps to reproduce:

I submitted a form, containing this:

<input type="checkbox" name="box[]" value="123" checked>
<input type="checkbox" name="box[]" value="456" checked>




Actual results:

In the web console, under POST tab, the Params section only show this:

box[]  123


Expected results:

box[]  123
box[]  456

In the Raw Data section both of them shows:

box%5B%5D=123&box%5B%5D=456

Comment 1

[Loic]

Could you attach a simple testcase to reproduce the issue, please.

Comment 2

[Lay András]

Simple testcase: http://bogex.hu/test/webconsole.php

Comment 3

[Loic]

Attachment: screen-ff52.jpg

I can't reproduce it with FF52 32b.

Comment 4

[vasoczki.ferenc]

Attachment: console.jpg

He is not at the Network tab. He is at console, when POST happens, expand the data (not clicking on link, click on the arraw), and then POST tab.

There is only one param. This is a real bug.

I think you should disable or remove that from the FF because it could be confusing, let's force the users to use the Network tab.

Comment 5

[Loic]

Attachment: ff52console.jpg

AFAIK, it has been removed with the new experimental console in Nightly.
So I'd say the bug will be "fixed" in next versions of Firefox.

Comment 6

[Lin Clark [:linclark]]

The plan is a little complex.

There are multiple views of the console. There is the web console, which most web developers use, and then there is the browser console and browser toolbox: https://developer.mozilla.org/en-US/docs/Tools/Browser_Console

The browser console does not have a net monitor. We will likely add this back in for the browser console but not in the web console.

Comment 7

[Loic]

https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=bccb11375f2af838cda714d42fd8cef78f5c7bf1&tochange=27104628616c5550fc56b060e727248c5f3a1c2c

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1309243.patch

Patch attached.

- Make React key prop unique
- Extend and existing test to cover the bug

Thanks for the report!

Honza

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Lin Clark [:linclark] from comment #6)
> The plan is a little complex.
> 
> There are multiple views of the console. There is the web console, which
> most web developers use, and then there is the browser console and browser
> toolbox: https://developer.mozilla.org/en-US/docs/Tools/Browser_Console
> 
> The browser console does not have a net monitor. We will likely add this
> back in for the browser console but not in the web console.
Lin, we are not putting the HTTP logs back into the web console? This was one of the most requested features in Firebug community and it was also one of the reasons why we had it in the Web Console. It would be great to have it back.

Honza

Comment 10

[Lin Clark [:linclark]]

Patrick has already asked Bryan to decide this in Bug 1308219.

My personal feeling is that the current status (having two views on the same data) is confusing for users and that we should have a UX review before reimplementing everything as it is now. I leave the decision up to Bryan, though.

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8801697 [details] [diff] [review]
bug1309243.patch

Review of attachment 8801697 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me !
One minor thing on the test, but feel free to lands this as is.

::: devtools/client/webconsole/net/test/mochitest/browser_net_params.js
@@ +59,5 @@
> +  let tabBody = yield selectNetInfoTab(hud, netInfoBody, "params");
> +
> +  let params = tabBody.querySelectorAll(
> +    ".netInfoParamName > span[title='box[]']");
> +  is(params.length, 2, "Two URI parameters  must exist");

could we check the content of each param too ?  I don't really see how this could happen now, but it will prevent to be bitten by a refactor that would use the property name to retrieve the value for example.
No strong opinion on this, it would be an extra safety net

Comment 12

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: bug1309243.patch

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #11)
> could we check the content of each param too ?  I don't really see how this
> could happen now, but it will prevent to be bitten by a refactor that would
> use the property name to retrieve the value for example.
> No strong opinion on this, it would be an extra safety net
Sure, done.

Thanks for the review!

Honza

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/be0b952903d0
Use unique key property; r=nchevobbe

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/be0b952903d0