Closed Bug 1309604 Opened 3 years ago Closed 3 years ago

The webcam favicon is very faded when the call is in a background tab

Categories

(Firefox :: Theme, defect)

51 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 52
Iteration:
52.3 - Nov 14
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- verified
firefox52 --- verified

People

(Reporter: cornel_ionce, Assigned: dao)

References

Details

(Keywords: regression, Whiteboard: [fxprivacy])

Attachments

(1 file)

[Note]:
- Screenshot: http://i.imgur.com/Rr8t3YY.png

[Affected versions]:
- latest 52.0a1 Nightly
- latest 51.0a2 Aurora

[Affected platforms]:
- Windows 10 x64
- Ubuntu 14.04 x86
- Mac OS X 10.12

[Steps to reproduce]:
1. Open Firefox
2. Go to https://people.mozilla.org/~fqueze2/webrtc/
3. Select "Audio & Video" and share the devices.
4. Open a new tab.
5. Observe the favicon of the tab where the call is active.

[Expected result]:
- The favicon changes to a webcam and back.

[Actual result]:
- The webcam favicon is very faded compared to the one from the identity panel. See the screenshot for a better understanding of the issue.

[Regression range]:
- This is not a regression.
(In reply to Cornel Ionce [QA] (:cornel_ionce) from comment #0)

> [Regression range]:
> - This is not a regression.

Looks a lot like a regression to me, I'm pretty sure this sharing icon wasn't partially transparent when I landed it in bug 1275262. Could you please find the regression range?
Blocks: 1275262
Flags: needinfo?(cornel.ionce)
Whiteboard: [fxprivacy][triage]
Mozregression narrowed down the regression range to this push:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c0ca8b0d966ee28bc6542a762f8a592cf76054d8&tochange=a481cba452933d5e7571fce7733b1ad7d41f493b

Bug 1304708 was uplifted to Aurora51 as well, so that seems like the most likely candidate.
Blocks: 1304708
Flags: needinfo?(cornel.ionce) → needinfo?(dao+bmo)
Version: Trunk → 51 Branch
The fix will likely be similar to what we did in bug 1303339.
Assignee: nobody → dao+bmo
Flags: needinfo?(dao+bmo)
Attached patch patchSplinter Review
Attachment #8802181 - Flags: review?(florian)
Comment on attachment 8802181 [details] [diff] [review]
patch

Review of attachment 8802181 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8802181 - Flags: review?(florian) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72a82d357f15
Stop using the fill filter for tab-sharing-icon-overlay, use designated sharing icon variants instead. r=florian
https://hg.mozilla.org/mozilla-central/rev/72a82d357f15
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
No longer blocks: 1206233, 1275262
Comment on attachment 8802181 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1304708
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: I missed updating this use case of notification-icons.svg in bug 1304708. Simple fix, low risk.
[String/UUID change made/needed]: none
Attachment #8802181 - Flags: approval-mozilla-aurora?
Comment on attachment 8802181 [details] [diff] [review]
patch

Fix a regression related to webcam favicon. Take it in 51 aurora.

Hi :cornel_ionce,
Can you help to verify this?
Flags: needinfo?(cornel.ionce)
Attachment #8802181 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Sure,

I'm confirming the fix for this issue across platforms using:
* latest 51.0a2 Aurora, build ID 20161021004016
* latest 52.0a1 Nightly, build ID 20161020030211.
Status: RESOLVED → VERIFIED
QA Contact: cornel.ionce
Iteration: --- → 52.3 - Nov 7
Whiteboard: [fxprivacy][triage] → [fxprivacy]
Flags: needinfo?(cornel.ionce)
You need to log in before you can comment on or make changes to this bug.