1309604 - The webcam favicon is very faded when the call is in a background tab

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Cornel Ionce [:cornel_ionce], Desktop Release QA]

[Note]:
- Screenshot: http://i.imgur.com/Rr8t3YY.png

[Affected versions]:
- latest 52.0a1 Nightly
- latest 51.0a2 Aurora

[Affected platforms]:
- Windows 10 x64
- Ubuntu 14.04 x86
- Mac OS X 10.12

[Steps to reproduce]:
1. Open Firefox
2. Go to https://people.mozilla.org/~fqueze2/webrtc/
3. Select "Audio & Video" and share the devices.
4. Open a new tab.
5. Observe the favicon of the tab where the call is active.

[Expected result]:
- The favicon changes to a webcam and back.

[Actual result]:
- The webcam favicon is very faded compared to the one from the identity panel. See the screenshot for a better understanding of the issue.

[Regression range]:
- This is not a regression.

Comment 1

[Florian Quèze [:florian]]

(In reply to Cornel Ionce [QA] (:cornel_ionce) from comment #0)

> [Regression range]:
> - This is not a regression.

Looks a lot like a regression to me, I'm pretty sure this sharing icon wasn't partially transparent when I landed it in bug 1275262. Could you please find the regression range?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Mozregression narrowed down the regression range to this push:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c0ca8b0d966ee28bc6542a762f8a592cf76054d8&tochange=a481cba452933d5e7571fce7733b1ad7d41f493b

Bug 1304708 was uplifted to Aurora51 as well, so that seems like the most likely candidate.

Comment 3

[Florian Quèze [:florian]]

The fix will likely be similar to what we did in bug 1303339.

Comment 4

[Dão Gottwald [::dao]]

Attachment: patch

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8802181 [details] [diff] [review]
patch

Review of attachment 8802181 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72a82d357f15
Stop using the fill filter for tab-sharing-icon-overlay, use designated sharing icon variants instead. r=florian

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72a82d357f15

Comment 8

[Dão Gottwald [::dao]]

Comment on attachment 8802181 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1304708
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: I missed updating this use case of notification-icons.svg in bug 1304708. Simple fix, low risk.
[String/UUID change made/needed]: none

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8802181 [details] [diff] [review]
patch

Fix a regression related to webcam favicon. Take it in 51 aurora.

Hi :cornel_ionce,
Can you help to verify this?

Comment 10

[Dão Gottwald [::dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0895f2ef1268cb87b507dfa1e4d7633621215264

Comment 11

[Cornel Ionce [:cornel_ionce], Desktop Release QA]

Sure,

I'm confirming the fix for this issue across platforms using:
* latest 51.0a2 Aurora, build ID 20161021004016
* latest 52.0a1 Nightly, build ID 20161020030211.