1309705 - Folder-display-helpers cannot be used from within Calendar tests

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[[:MakeMyDay]]

test-folder-display-helpers.js cannot be used properly when included from within Calendar Mozmill tests, installInto(module) fails.

The problem is that FILE_LOAD_PATHS doesn't include an appropriate releative path to work from within calendar tests.

Comment 1

[[:MakeMyDay]]

Attachment: FixFolderDisplayHelpersForCalendar-V1.diff

Aceman, you're doing a lot of mozmill stuff, so I assign the review to you.

Comment 2

[:aceman]

Comment on attachment 8800415 [details] [diff] [review]
FixFolderDisplayHelpersForCalendar-V1.diff

Review of attachment 8800415 [details] [diff] [review]:
-----------------------------------------------------------------

Calendar tests do not seem to use the file yet. Are you planning to use it?
Also, in the load_via_src_path() the patch is said to be 'relative to comm-central source path'. What does that mean?
The paths in FILE_LOAD_PATHS are not relative to that files position and also not relative to e.g. the comm-central root. Can you update that comment to make it clear where it starts from?

Comment 3

[[:MakeMyDay]]

Thanks. Yes, currently we have no mozmill tests for email inviations, which is going to be changed.

The comment regarding a relative path is imho correct. The starting point is floating: the shared-modules are stored on a different directory level in calendar than in mail when being staged (at least for local test runs). That codes tries to determine the relative path based on the location of the test-folder-display-helpers.js file, but the places to look at are restricted by FILE_LOAD_PATHS.

Comment 4

[:aceman]

So can the comment say 'relative to the comm-central location of test-folder-display-helpers.js file' ?

Comment 5

[[:MakeMyDay]]

https://hg.mozilla.org/comm-central/rev/a5008a01e8e3f06b06bfbac44338afd882769273