Closed Bug 1309719 Opened 3 years ago Closed 3 years ago

Remove DOM/telephony and related code.

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: mds, Assigned: mds)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.
Comment on attachment 8803181 [details]
Bug 1309719 - Remove DOM/telephony and related code.

https://reviewboard.mozilla.org/r/87430/#review86684

nsITelephonyFoo are accessed from the following places:

* b2g/components/ContentPermissionPrompt.js
* dom/bluetooth
* dom/system/gonk

Removing this without also dealing with those places will break stuff.

r=me but you may not want to land this alone as is.

::: browser/installer/package-manifest.in
(Diff revision 1)
>  @RESPATH@/components/dom_permissionsettings.xpt
>  @RESPATH@/components/dom_sidebar.xpt
>  @RESPATH@/components/dom_mobilemessage.xpt
>  @RESPATH@/components/dom_storage.xpt
>  @RESPATH@/components/dom_stylesheets.xpt
> -@RESPATH@/components/dom_telephony.xpt

There's other stuff you should remove from this file.  Everything in the EXTRA_COMPONENTS variables in the moz.build files you have removed.
Attachment #8803181 - Flags: review?(ehsan) → review+
(In reply to :Ehsan Akhgari (Away Oct 25 - Nov 9) from comment #5)

Hey :Ehsan, thanks for your review.

A couple of remarks:

> * dom/bluetooth

This is gonna go away as per bug 1310020. Also, we're not building that anyway, so nothing is gonna brake (trys are green on all platforms).

> ::: browser/installer/package-manifest.in
> (Diff revision 1)
> >  @RESPATH@/components/dom_permissionsettings.xpt
> >  @RESPATH@/components/dom_sidebar.xpt
> >  @RESPATH@/components/dom_mobilemessage.xpt
> >  @RESPATH@/components/dom_storage.xpt
> >  @RESPATH@/components/dom_stylesheets.xpt
> > -@RESPATH@/components/dom_telephony.xpt
> 
> There's other stuff you should remove from this file.  Everything in the
> EXTRA_COMPONENTS variables in the moz.build files you have removed.

AFAICT all the declared EXTRA_COMPONENTS are "compressed" in dom_telephony.xpt alone: packaging works as expected on both desktop and mobile. Would you please hint me to which one(s) I've overlooked, please?
Flags: needinfo?(ehsan)
(In reply to Michelangelo De Simone [:mds] from comment #6)
> (In reply to :Ehsan Akhgari (Away Oct 25 - Nov 9) from comment #5)
> 
> Hey :Ehsan, thanks for your review.
> 
> A couple of remarks:
> 
> > * dom/bluetooth
> 
> This is gonna go away as per bug 1310020. Also, we're not building that
> anyway, so nothing is gonna brake (trys are green on all platforms).

Cool!

> > ::: browser/installer/package-manifest.in
> > (Diff revision 1)
> > >  @RESPATH@/components/dom_permissionsettings.xpt
> > >  @RESPATH@/components/dom_sidebar.xpt
> > >  @RESPATH@/components/dom_mobilemessage.xpt
> > >  @RESPATH@/components/dom_storage.xpt
> > >  @RESPATH@/components/dom_stylesheets.xpt
> > > -@RESPATH@/components/dom_telephony.xpt
> > 
> > There's other stuff you should remove from this file.  Everything in the
> > EXTRA_COMPONENTS variables in the moz.build files you have removed.
> 
> AFAICT all the declared EXTRA_COMPONENTS are "compressed" in
> dom_telephony.xpt alone: packaging works as expected on both desktop and
> mobile. Would you please hint me to which one(s) I've overlooked, please?

No, you're thinking of XPIDL_SOURCES.  The xpt files are compiled interface information that we get from processing XPIDL .idl files (the other output of that processing is the corresponding generated .h file)

If you look at EXTRA_COMPONENTS in dom/telephony/moz.build, you'll see:

 63     EXTRA_COMPONENTS += [
 64         'gonk/TelephonyAudioService.js',
 65         'gonk/TelephonyAudioService.manifest',
 66         'gonk/USSDReceivedWrapper.js',
 67         'gonk/USSDReceivedWrapper.manifest',
 68     ]
 69     if not CONFIG['DISABLE_MOZ_RIL_GEOLOC']:
 70         EXTRA_COMPONENTS += [
 71             'gonk/TelephonyService.js',
 72             'gonk/TelephonyService.manifest',
 73         ]

All of these files appear in b2g's package manifest in addition to dom_telephony.xpt and they need to all be removed.
Flags: needinfo?(ehsan)
I think given the complex nature of the intertwined patches we'll be going through in order to follow up on our plan to remove the B2G code from mozilla-central, it's ok for things to end up in a broken state between patch landings. We should of course where it makes sense keep that intermittent breakage to a minimum and cluster patches as reasonable.

IOW, go ahead and land this and try to follow up with the continuation of removals of the broken code.
Comment on attachment 8803181 [details]
Bug 1309719 - Remove DOM/telephony and related code.

https://reviewboard.mozilla.org/r/87430/#review86684

> There's other stuff you should remove from this file.  Everything in the EXTRA_COMPONENTS variables in the moz.build files you have removed.

This file was correct:), you meant the b2g one... I've removed the xpt's from that too. Thanks.
Pushed by mdesimone@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7e827f90ba9
Remove DOM/telephony and related code. r=ehsan+251051
https://hg.mozilla.org/mozilla-central/rev/a7e827f90ba9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.