Closed Bug 1310863 Opened 7 years ago Closed 7 years ago

Remove DOM/phonenumberutils and related code.

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: mds, Assigned: mds)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1310863 - Remove DOM/phonenumberutils and related code.
58 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details 
      No description provided.
Comment on attachment 8802683 [details]
Bug 1310863 - Remove DOM/phonenumberutils and related code.

https://reviewboard.mozilla.org/r/87008/#review86086

r=me on the changes, but please note that PhoneNumberUtils is used in dom/contacts, dom/mobilemessage, dom/telephony and dom/wappush.  The last three seem to be gonk only, not sure about the first one...

Technically you should land this after all of those uses have been removed.  But please verify that at least tests pass and whatnot, I won't be too sad if you land this as is right now assuming this won't break tests, and quickly follow up by removing those four directories.
Attachment #8802683 - Flags: review?(ehsan) → review+
And it looks like the contacts tests are failing on try.

FWIW in the future when removing JSMs, look at what names are exported through EXPORTED_SYMBOLS, and search for those names in the code base to find those uses.
(In reply to :Ehsan Akhgari (Away Oct 25 - Nov 9) from comment #2)

> Technically you should land this after all of those uses have been removed. 
> But please verify that at least tests pass and whatnot, I won't be too sad
> if you land this as is right now assuming this won't break tests, and
> quickly follow up by removing those four directories.

Indeed.

dom/(contacts, wappush, telephony, mobilemessage) are all due to be removed. In order to minimize issues I'll push them all in a single batch as soon as everything else's ready.

For the failing tests, I'm not entirely sure whether those are related to this. I'll double-check and re-run everything before landing.
But thanks for the info, though.
No longer blocks: 1310864
Depends on: 1310864
Depends on: 1310027
Depends on: 1309719
Depends on: 1311885
Pushed by mdesimone@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad87ed1bbed5
Remove DOM/phonenumberutils and related code. r=ehsan+251051
https://hg.mozilla.org/mozilla-central/rev/ad87ed1bbed5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
No longer blocks: 1369194
Adding ddn, just to check the docs for this.
Keywords: dev-doc-needed
I've checked, and it doesn't look like we documented any of this. It also doesn't look like it is particularly web dev facing.

Let me know if you think any of this should be mentioned in the rel notes.
Keywords: dev-doc-needed → dev-doc-complete
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.