1310863 - Remove DOM/phonenumberutils and related code.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Michelangelo De Simone [Offline] [:mds]]

Attachment: Bug 1310863 - Remove DOM/phonenumberutils and related code.

Review commit: https://reviewboard.mozilla.org/r/87008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87008/

Comment 2

[(no longer active)]

Comment on attachment 8802683 [details]
Bug 1310863 - Remove DOM/phonenumberutils and related code.

https://reviewboard.mozilla.org/r/87008/#review86086

r=me on the changes, but please note that PhoneNumberUtils is used in dom/contacts, dom/mobilemessage, dom/telephony and dom/wappush.  The last three seem to be gonk only, not sure about the first one...

Technically you should land this after all of those uses have been removed.  But please verify that at least tests pass and whatnot, I won't be too sad if you land this as is right now assuming this won't break tests, and quickly follow up by removing those four directories.

Comment 3

[(no longer active)]

And it looks like the contacts tests are failing on try.

FWIW in the future when removing JSMs, look at what names are exported through EXPORTED_SYMBOLS, and search for those names in the code base to find those uses.

Comment 4

[Michelangelo De Simone [Offline] [:mds]]

(In reply to :Ehsan Akhgari (Away Oct 25 - Nov 9) from comment #2)

> Technically you should land this after all of those uses have been removed. 
> But please verify that at least tests pass and whatnot, I won't be too sad
> if you land this as is right now assuming this won't break tests, and
> quickly follow up by removing those four directories.

Indeed.

dom/(contacts, wappush, telephony, mobilemessage) are all due to be removed. In order to minimize issues I'll push them all in a single batch as soon as everything else's ready.

For the failing tests, I'm not entirely sure whether those are related to this. I'll double-check and re-run everything before landing.
But thanks for the info, though.

Comment 5

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8802683 [details]
Bug 1310863 - Remove DOM/phonenumberutils and related code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87008/diff/1-2/

Comment 6

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8802683 [details]
Bug 1310863 - Remove DOM/phonenumberutils and related code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87008/diff/2-3/

Comment 7

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8802683 [details]
Bug 1310863 - Remove DOM/phonenumberutils and related code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87008/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad87ed1bbed5
Remove DOM/phonenumberutils and related code. r=ehsan+251051

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ad87ed1bbed5

Comment 10

[Chris Mills [:cmills]]

Adding ddn, just to check the docs for this.

Comment 11

[Chris Mills [:cmills]]

I've checked, and it doesn't look like we documented any of this. It also doesn't look like it is particularly web dev facing.

Let me know if you think any of this should be mentioned in the rel notes.