1309824 - Selecting a storage type shows incorrect message

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P3)

Description

[Sebastian Zartner [:sebo]]

When selecting a storage type like 'Cache Storage', 'Cookies', 'Local Storage', etc. you currently see the message "No data present for selected host".

This message doesn't make sense, because there is no host selected.

It would be better to display some general information about the stored data within the selected storage type.

As general information I could imagine the total size of the stored data and the total number of stored entries. There may be some more statistical data for specific storage types. E.g. for cookies it might be interesting to have some information about the number of session vs. date expiring cookies.

If there's no general info for a storage type (or providing storage info seems overkill), at least the current message should be replaced by a message like "Select a host to see the data stored for it.".

Sebastian

Comment 1

[Tim Nguyen :ntim]

Could be nice having a message with some links to the MDN docs for each storage types as well.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on HOTFROG.

Comment 3

[Sebastian Zartner [:sebo]]

(In reply to Tim Nguyen :ntim from comment #1)

Could be nice having a message with some links to the MDN docs for each
storage types as well.

In preparation for that I have split out the descriptions of the storage types into separate pages, so the links can reference them directly.

Also, I think now it's better to first fix this to show a proper message to the user (and link to more info on MDN). In a later step when can then still add additional information for the different storage types. I'll create a separate issue for that.

Sebastian

Comment 4

[Sebastian Zartner [:sebo]]

Attachment: Bug 1309824 - Show proper descriptions for storage types. r=jdescottes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c4b489b6aa0
Show proper descriptions for storage types. r=jdescottes,fluent-reviewers,flod

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 1c4b489b6aa0 (Bug 1309824) for dt failures at browser_tableWidget_basic.js.
https://hg.mozilla.org/integration/autoland/rev/5b981d3376fe4707a6f93c70c1ef97cc075a355b

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=1c4b489b6aa02b4072571e5f634b9266525ef07f&selectedTaskRun=QpwB3gfDSQ6F7_Fi5ZUlRw-0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302153371&repo=autoland&lineNumber=2319

Comment 7

[Sebastian Zartner [:sebo]]

I've already fixed the error. I am just waiting for feedback from Julian about the changes.

Sebastian

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff07fdc7c70e
Show proper descriptions for storage types. r=jdescottes,fluent-reviewers,flod

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ff07fdc7c70e