Closed
Bug 1310017
Opened 8 years ago
Closed 8 years ago
Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
(Keywords: addon-compat)
Attachments
(1 file)
51.68 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|nsISupportsArray| is deprecated. It should be pretty straightforward to swithc over to nsIArray in nsITransferable and nsIFormatConverter.
Assignee | ||
Comment 1•8 years ago
|
||
This converts |nsITransferable.flavorsTransferableCanExport| and |nsITransferable.flavorsTransferableCanImport| to return a |nsIArray|. A search of the addons repo shows a few usages. It's used in multiple copies of "Google Toolbar for Firefox" which has not been supported by Google since 2011 [1]. The rest either just call the method but don't use the return value or are in dead code paths. A full list with notes is below [2]. A cursory search of c-c shows no hits. |nsIFormatConverter.getInputDataFlavors| and |nsIFormatConverter.getOutputDataFlavors| are updated as well. A search of the addons repo shows no usage of either function. A cursory search of c-c shows no hits. Olli, I chose you to review as you have previous context for what I'm doing here but feel free to redirect. [1] https://www.google.com/intl/en/toolbar/ff/index.html [2] Addon references: > 478082-install.rdf - OccupyID-1 - by Mike Perry > - dead code, only path is from a message observer for a non-existent message > 663818-install.rdf - Auto Copy for DTS - by XdemonicX > - referenced, but not used > 674311-install.rdf - easyDITA Copy Paste Plugin - by Jorsek, LLC > - referenced, but not used > 699601-install.rdf - Google Toolbar for Firefox - by Google Inc. > 710868-install.rdf - ggl Toolbar for Firefox - by ggl > 720372-install.rdf - Google Toolbar for Firefox - by Google Inc. > 720375-install.rdf - Google Toolbar for Firefox - by Google Inc. > 720467-install.rdf - Google Toolbar for Firefox - by Google Inc. > 720715-install.rdf - My Own Google Toolbar for Firefox - by me > 721684-install.rdf - Google Toolbar for Firefox - by Google Inc. > 725138-install.rdf - Google Toolbar for Firefox - by Google Inc. > 726215-install.rdf - Auto Copy - by Michael Lidman > - referenced, but not used > 727695-install.rdf - Google Toolbar for Firefox - by Google Inc. > 728065-install.rdf - Google Toolbar for Firefox - by Google Inc. > 728068-install.rdf - Google Toolbar for Firefox - by Google Inc. > 730407-install.rdf - Google Toolbar for Firefox - by Google Inc. > 737130-install.rdf - Google Toolbar for Firefox - by Google Inc.
Attachment #8800859 -
Flags: review?(bugs)
Comment 2•8 years ago
|
||
Comment on attachment 8800859 [details] [diff] [review] Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter So code is fine, but please ask feedback from someone dealing with addons.
Attachment #8800859 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Jorge, does this seem okay from an addons perspective? See detailed breakdown in comment 1.
Flags: needinfo?(jorge)
Keywords: addon-compat
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=21e32acc0788
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3128e7f80aa
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd7461a1ed09447f4d38b4911f0e83933f9d875b Bug 1310017 - Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter. r=smaug
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bd7461a1ed09
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•