1311064 - Crash in nsSupportsArray::Read

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-60199d26-8439-4b56-b180-18c292161018.
=============================================================

Seen while looking at Nightly crash stats: http://bit.ly/2erhgLt. Small volume crash which started on Mac using 20161017030209

Some code in this area was worked on in Bug 1310017. ni on eric in case he has some ideas.

Comment 1

[Eric Rahm [:erahm]]

I think this is a rebasing snafu from landing bug 1310017 before bug 1309698. It's accessing |gDraggedTransferables| [1] which is declared as |extern nsIArray|, but the actual declaration has not been updated and remains |nsISupportsArray| [2]. It's amazing the awful things C++ lets you do!

Bug 1309698 now has an r+, but was waiting for bug 1310040, which also now has an r+ and should be landing shortly.

[1] https://hg.mozilla.org/mozilla-central/annotate/94b0fddf96b4/widget/cocoa/nsChildView.mm#l5842
[2] https://hg.mozilla.org/mozilla-central/annotate/94b0fddf96b4/widget/cocoa/nsDragService.mm#l46

Comment 2

[Eric Rahm [:erahm]]

And bug 1310040 is waiting on bug 1308317 which just got an r+, but the tree is closed so we'll have to wait a bit.

Comment 3

[Markus Stange [:mstange]]

Can this be closed? The crash seems to be fixed, looking at the crash stats graph.

Comment 4

[Eric Rahm [:erahm]]

(In reply to Markus Stange [:mstange] from comment #3)
> Can this be closed? The crash seems to be fixed, looking at the crash stats
> graph.

Looks like we're good.