1310220 - update Permissions UI to to allow for management of User Roles

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P1)

Description

[[e-mail] (:bhearsum)]

As part of the Multiple Signoff project, Users will need to be granted Roles to allow them to Signoff on changes. The backend will be modified to associate Users with Roles, but we need UI for managing them. We already have existing UI in "Permissions" that is User-centric, so we should enhance it to allow for Role configuration as well.

Comment 1

[Njira]

Hi Ben.

A user that does not have permissions gets and empty response from the api i.e `{}`. Could we edit a user not yet assigned roles to also be the same empty response as opposed to a 404 with `No roles found for user`

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Njira from comment #1)
> Hi Ben.
> 
> A user that does not have permissions gets and empty response from the api
> i.e `{}`. Could we edit a user not yet assigned roles to also be the same
> empty response as opposed to a 404 with `No roles found for user`

Yes, that's a good idea. Do you want to do that, or should I?

Comment 3

[Njira]

Doing it now. The 404 was an inconvenience from my end. Thanks.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/061f4bb0e5c3f748957e54d32ba6212d34ada45b
bug 1310220: Return empty list when user has no roles (#195). r=bhearsum

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/870a1dc821f32a331d4542f22b2af93a6d8782a3
bug 1310220: UI for User Roles (#206). r=bhearsum

Comment 6

[[e-mail] (:bhearsum)]

In production. Thank you very much Njira!!