1310226 - ui for changing Required Signoffs

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P1)

Description

[[e-mail] (:bhearsum)]

It would probably be best to integrate Required Signoffs into the existing Rules, Releases, and Permissions UI, as they only make sense in those contexts. Because Rules and Releases will share the same Required Signoffs, it probably makes sense to have some sort of indication of this in the UI to avoid confusion.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: Required Signoffs UI

Vapourware no more! Details in the PR.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8836860 [details] [review]
Required Signoffs UI

Great PR! I found some bugs, but I didn't manage to by-pass the signoffs! :D

We might want some of these bugs fixed before landing the PR. I left more details at https://github.com/mozilla/balrog/pull/253#pullrequestreview-23185787

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8836860 [details] [review]
Required Signoffs UI

I'm going to let jlorenzo's handle the review on this.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 8836860 [details] [review]
Required Signoffs UI

I think I've fixed up all the blocking issues. Let me know if I missed anything, or there's anything else.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8836860 [details] [review]
Required Signoffs UI

Looks great to me! Thanks for the fix ups.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/7eb6163efd2bb67b5ff1e8970bdecdcfec67d30c
bug 1310226: UI for Required Signoffs management (#253). r=jlorenzo

Comment 8

[[e-mail] (:bhearsum)]

In production \o/