1310227 - ui for signing off on proposed changes

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P1)

Description

[[e-mail] (:bhearsum)]

UI for this will be part of the Scheduled Changes sections. Existing Signoffs will be shown for each proposed change as well as which Roles still need to Signoff. An “Approve” button will be shown for any Change that still requires signoff. If the User holds multiple Roles, they will be prompted to specify which Role they are signing off under.

Comment 1

[[e-mail] (:bhearsum)]

I'm implementing this for Required Signoffs as part of bug 1310226. I suspect it will be quite re-usable for other Scheduled Changes.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: signoffs ui for Rules, Releases, and Permissions

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8841997 [details] [review]
signoffs ui for Rules, Releases, and Permissions

Johan is better placed to review this one too.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8841997 [details] [review]
signoffs ui for Rules, Releases, and Permissions

Sorry for the big delay. I left more details at https://github.com/mozilla/balrog/pull/268#pullrequestreview-24998285

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/a4950a5e5860976637d9e58f2da8b16dd0617c87
bug 1310227: UI for signing off on Scheduled Changes for Rules, Releases, and Permissions (#268). r=jlorenzo

Comment 6

[[e-mail] (:bhearsum)]

In production as of yesterday!