ui for signing off on proposed changes

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=js][lang=html][ready])

Attachments

(1 attachment)

UI for this will be part of the Scheduled Changes sections. Existing Signoffs will be shown for each proposed change as well as which Roles still need to Signoff. An “Approve” button will be shown for any Change that still requires signoff. If the User holds multiple Roles, they will be prompted to specify which Role they are signing off under.
(Assignee)

Updated

2 years ago
Blocks: 1278974
(Assignee)

Updated

2 years ago
Priority: -- → P1
Whiteboard: [lang=js][lang=html][ready]
I'm implementing this for Required Signoffs as part of bug 1310226. I suspect it will be quite re-usable for other Scheduled Changes.
(Assignee)

Updated

2 years ago
Assignee: nobody → bhearsum
Created attachment 8841997 [details] [review]
signoffs ui for Rules, Releases, and Permissions
Attachment #8841997 - Flags: review?(nthomas)
Attachment #8841997 - Flags: review?(jlorenzo)
Comment on attachment 8841997 [details] [review]
signoffs ui for Rules, Releases, and Permissions

Johan is better placed to review this one too.
Attachment #8841997 - Flags: review?(nthomas)
Comment on attachment 8841997 [details] [review]
signoffs ui for Rules, Releases, and Permissions

Sorry for the big delay. I left more details at https://github.com/mozilla/balrog/pull/268#pullrequestreview-24998285
Attachment #8841997 - Flags: review?(jlorenzo) → review+

Comment 5

2 years ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/a4950a5e5860976637d9e58f2da8b16dd0617c87
bug 1310227: UI for signing off on Scheduled Changes for Rules, Releases, and Permissions (#268). r=jlorenzo
(Assignee)

Updated

2 years ago
Depends on: 1347181
In production as of yesterday!
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.