1310245 - Remove webapps from comm-central. Port Bug 1261019.

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Frank-Rainer Grahl (:frg)]

Bug 1261019 removed webapps components present in SeaMonkey, Instantbird and Thunderbird.

Comment 1

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/d1c77b5622b86dbf6d7ab90e940f8b1494f90fc0
Bug 1310245 - Remove webapps from comm-central, suite\ part. rs,a=bustage-fix

Comment 2

[aleth [:aleth]]

TB and IB: https://hg.mozilla.org/comm-central/rev/8166f30a47b0f4cf32f63ad7d875d638ae2305cc

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1310245-webapps-suite2.patch

SeaMonkey needs an additional tweak.

Kent, there are still references in mailnews code for webapps.jsm. Could Bug 1148512 probably be backed out now?

Comment 4

[Ian Neal]

Comment on attachment 8801209 [details] [diff] [review]
1310245-webapps-suite2.patch

LGTM r/a=me

Comment 5

[Frank-Rainer Grahl (:frg)]

suite part pushed.

https://hg.mozilla.org/comm-central/rev/4ab74b8cea0439e4056e7656d8542471f3c9454e

Comment 6

[Kent James (:rkent)]

(In reply to Frank-Rainer Grahl from comment #3)
> Created attachment 8801209 [details] [diff] [review]
> 1310245-webapps-suite2.patch
> 
> SeaMonkey needs an additional tweak.
> 
> Kent, there are still references in mailnews code for webapps.jsm. Could Bug
> 1148512 probably be backed out now?

Those references are just in comments, right? If you want to remove the comments, you may do so r=rkent. As for backing out bug 1148512, It would take some time to back out, I don't see that it is doing any hard, so I would leave it unless you have a concrete reason to back it out.

Comment 7

[Frank-Rainer Grahl (:frg)]

>> Those references are just in comments, right?

Yupp. I won't change them right now because the explanation for the added lines would then be gone too. So lets just clsoe the bug for now.