Remove webapps from comm-central. Port Bug 1261019.

RESOLVED FIXED in Thunderbird 52.0

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: frg, Assigned: frg)

Tracking

Trunk
Thunderbird 52.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug 1261019 removed webapps components present in SeaMonkey, Instantbird and Thunderbird.
(Assignee)

Updated

2 years ago
Depends on: 1261019

Comment 1

2 years ago
https://hg.mozilla.org/comm-central/rev/d1c77b5622b86dbf6d7ab90e940f8b1494f90fc0
Bug 1310245 - Remove webapps from comm-central, suite\ part. rs,a=bustage-fix

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
(Assignee)

Comment 3

2 years ago
Created attachment 8801209 [details] [diff] [review]
1310245-webapps-suite2.patch

SeaMonkey needs an additional tweak.

Kent, there are still references in mailnews code for webapps.jsm. Could Bug 1148512 probably be backed out now?
Assignee: nobody → frgrahl
Status: RESOLVED → REOPENED
Flags: needinfo?(rkent)
Attachment #8801209 - Flags: review?(iann_bugzilla)
Resolution: FIXED → ---

Comment 4

2 years ago
Comment on attachment 8801209 [details] [diff] [review]
1310245-webapps-suite2.patch

LGTM r/a=me
Attachment #8801209 - Flags: review?(iann_bugzilla) → review+
(In reply to Frank-Rainer Grahl from comment #3)
> Created attachment 8801209 [details] [diff] [review]
> 1310245-webapps-suite2.patch
> 
> SeaMonkey needs an additional tweak.
> 
> Kent, there are still references in mailnews code for webapps.jsm. Could Bug
> 1148512 probably be backed out now?

Those references are just in comments, right? If you want to remove the comments, you may do so r=rkent. As for backing out bug 1148512, It would take some time to back out, I don't see that it is doing any hard, so I would leave it unless you have a concrete reason to back it out.
Flags: needinfo?(rkent)
(Assignee)

Comment 7

2 years ago
>> Those references are just in comments, right?

Yupp. I won't change them right now because the explanation for the added lines would then be gone too. So lets just clsoe the bug for now.
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.