Closed Bug 1148512 Opened 5 years ago Closed 5 years ago

TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_dod.js | xpcshell return code: 0||1 | streamMessages - [streamMessages : 94] false == true | application crashed [@ mozalloc_abort(char const * const)]

Categories

(Thunderbird :: General, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 41.0

People

(Reporter: rkent, Assigned: aryx)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Under Windows only, suddenly multiple tests started failing that I believe probably use fake servers. Example:

09:00:20 INFO - TEST-START | mailnews/imap/test/unit/test_dontStatNoSelect.js
09:00:20 WARNING - TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_dontStatNoSelect.js | xpcshell return code: 0
09:00:20 INFO - TEST-INFO took 344ms
09:00:20 INFO - >>>>>>>
09:00:20 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
09:00:20 INFO - TEST-PASS | mailnews/imap/test/unit/test_dontStatNoSelect.js | run_test - [run_test : 35] 5 == 5
09:00:20 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Error: "NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" {file: "resource://gre/modules/Webapps.jsm" line: 20}]"
09:00:20 INFO - Error console says [stackFrame NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]]
09:00:20 INFO - ../../../resources/logHelper.js:_errorConsoleTunnel.observe:95
09:00:20 INFO - resource://testing-common/mailnews/maild.js:nsMailServer.prototype.performTest:246
09:00:20 INFO - C:/slave/test/build/tests/xpcshell/tests/mailnews/imap/test/unit/test_dontStatNoSelect.js:run_test:56
09:00:20 INFO - C:\slave\test\build\tests\xpcshell\head.js:_execute_test:504
09:00:20 INFO - -e:null:1
09:00:20 INFO - null:null:0
09:00:20 INFO - exiting test
Summary: TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_dod.js | xpcshell return code: 0 → TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_dod.js | xpcshell return code: 0||1 | streamMessages - [streamMessages : 94] false == true | application crashed [@ mozalloc_abort(char const * const)]
Attached patch patch, v1 (obsolete) — Splinter Review
Bug 1115495 does checks for proxies and this code runs through WebApps.jsm which calls nsIXULAppInfo but can't access it by normal means, so the environment has to provide this info.

This fixes the following permanently failing XPCShell tests on Windows:

TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_chunkLastLF.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_chunkLastLF.js | verifyContentLength - [verifyContentLength : 84] 1957 == 0
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_chunkLastLF.js | _async_driver - TypeError: ex.stack is undefined at ../../../resources/asyncTestUtils.js:169
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_dod.js | xpcshell return code: 0

TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_dod.js | streamMessages - [streamMessages : 94] false == true

TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_dontStatNoSelect.js | xpcshell return code: 0
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
Attachment #8597727 - Flags: review?(Pidgeot18)
Attached patch patch, v2Splinter Review
Also fixes:

TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_bug695309.js | xpcshell return code: 0

TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_bug695309.js | test_newMsgs - [test_newMsgs : 48] 0 == 3

TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_bug695309.js | _async_driver - TypeError: ex.stack is undefined at ../../../resources/asyncTestUtils.js:169

TEST-UNEXPECTED-FAIL | mailnews/compose/test/unit/test_sendMessageLater2.js | xpcshell return code: 0

TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_internalUris.js | xpcshell return code: 0

TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_internalUris.js | test_newMsgs - [test_newMsgs : 47] 0 == 8

TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_internalUris.js | _async_driver - TypeError: ex.stack is undefined at ../../../resources/asyncTestUtils.js:169

TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_nntpPasswordFailure.js | xpcshell return code: 0

TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_nntpPasswordFailure.js | getMail1 - [getMail1 : 128] 0 == 2

TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_nntpPasswordFailure.js | _async_driver - TypeError: ex.stack is undefined at ../../../resources/asyncTestUtils.js:169
Attachment #8597727 - Attachment is obsolete: true
Attachment #8597727 - Flags: review?(Pidgeot18)
Attachment #8597728 - Flags: review?(Pidgeot18)
Comment on attachment 8597728 [details] [diff] [review]
patch, v2

I came to the same conclusion, did my own identical patch, then noticed yours.

r=me
Attachment #8597728 - Flags: review?(Pidgeot18) → review+
I tweaked your patch, adding the changes to the head file instead of as a separate file. That also fixed the missing changes in the maildir version of imap.

http://hg.mozilla.org/comm-central/rev/8991f07b089b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
You need to log in before you can comment on or make changes to this bug.