Closed Bug 1310299 Opened 4 years ago Closed 2 years ago
Remove and prevent creation of custom Places roots
Per bug 1258127, comment 190, we can tighten our logic to prevent inserting items into the Places root: > Maybe we should just disallow adding anything to the root and have an > internal method to add to it? > This would break: > - the left pane folder creation code. This is already "broken" in the sense > its creation is incompatible with the new async bookmarking API. > - old sync (the one without a real root) could not create its root. this > means we need a downgrade path (a version with real mobile root) before > making the strict roots rule. > - Probably some add-ons, but honestly those should create their own db and > ATTACH to places.sqlite rather than creating fake roots. I know that some > add-ons do this and increase the size of places.sqlite to a level where it > also kills our history and perf, so I'd be happy to disallow it. Add-ons > have a way out using tags or attaching their own db. Someone could still try > to use db access to do its own writes, but those will clearly be bad players > at that point (we could remove any invalid root at random times).
This should now be fixed along with bug 1310295
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.