1310421 - Fix menubar color (or background-color) in private browsing with dev edition dark-theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[magicp]

Attachment: fix-menubar-color-in-private-browsing-with-dark-theme.png

STR:
1. Start Nightly with Dev Edition dark theme
2. Open a new private window (Ctrl+Shift+P)
3. Check menubar color

AR:
menubar color is difficult to see.

ER:
Fix menubar font-color (or background-color) to more light color.

Comment 1

[magicp]

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=19b99d7e48a147c56d43688ddde560c574181764&tochange=a1727a7c7f2f5cb3d732c475567e421aed2f0ba8

Comment 2

[Tim Nguyen :ntim]

Dao, can you take a look at this please? Thanks!

Comment 3

[Dão Gottwald [:dao]]

See bug 1309532 comment 5 for what's likely going on here.

Comment 4

[Dão Gottwald [:dao]]

I believe this should be fixed by bug 854126 in tomorrow's Nightly. magicp, can you verify?

Comment 5

[magicp]

Attachment: verified-53.0a1.png

This bug was fixed in latest Nightly build. I have some questions for new style.

- navigator-toolbox area turns blue... right?
- no hover action on menubar, tabs... right?
- url bar-input-box selection color cannot be seen... right?
- titlebar-buttonbox looks like blurred.
- identity-icon-labels color contrast at mozilla.org (blue and green) is hard to see for color vision abnormality.

Thanks!

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8828103 [details]
verified-53.0a1.png

This was prior to bug 854126 being fixed. Please check with the upcoming nightly.

Comment 7

[magicp]

Attachment: verified-53.0a1-20170119030211.png

This bug was fixed in the latest nightly build (20170119030211). Thanks!

Comment 8

[Dão Gottwald [:dao]]

Thanks for checking!