1309532 - Site identity icon is almost invisible on dark DevEdition theme in private browsing

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Cornel Ionce [:noni] [Hubs QA]]

[Affected versions]:
- latest 52.0a1 Nightly
- latest 51.0a2 Aurora

[Affected platforms]:
- Windows 10 x64
- Mac OS X 10.11
- Ubuntu 14.04 x86

[Steps to reproduce]:
1. Open Firefox.
2. Set Dark DevEdition theme (if not set already).
3. Enter PB mode and navigate to any site.
4. Observe the site identity icon.

[Expected result]:
The site identity icon is properly displayed.

[Actual result]:
The site identity icon is barely visible.

[Regression range]:
See bug 1301945#c2 for the regression range.

[Additional notes]:
In bug 1301945 this was fixed only for normal browsing.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Panos, are we OK shipping with this?

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Screenshot from closed dupe: https://bug1309822.bmoattachments.org/attachment.cgi?id=8800569

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

This seems more serious than P3 to me, but I wonder what Dao had in mind when he marked it as P3. Do we have a plan for what needs to be done here? Perhaps use var(--chrome-color) for the icons?

Comment 5

[Dão Gottwald [:dao]]

P3 because release isn't affected and devedition x private browsing is probably a fairly small population.

Also, the underlying problem seems to be older: Private browsing disables lightweight themes but we're somehow still applying the devedition theme -- without it being exposed as a lightweight theme to theme code, i.e. the :-moz-lwtheme selector stops working.

Comment 6

[:Gijs (out for now; he/him)]

We could avoid including the devedition stylesheet for private windows, but then you'd just get the default theme in private windows, which I'm not sure is really the desired behaviour here either.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Thanks, marking as fix-optional since it is a problem we have lived with for a while now.