Closed
Bug 1310587
Opened 8 years ago
Closed 8 years ago
[DateTimeInput] make background of reset button in input box transparent
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: jessica, Assigned: jessica)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
829 bytes,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
Follow-up to Bug 1288591.
The background color of the reset button in the input box should be transparent.
Assignee | ||
Comment 1•8 years ago
|
||
Hi Mike, could you review this small patch or forward to the right person if you have a full plate? Thank you!
Assignee: nobody → jjong
Attachment #8801647 -
Flags: review?(mconley)
Comment 2•8 years ago
|
||
Comment on attachment 8801647 [details] [diff] [review]
patch, v1.
Review of attachment 8801647 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good! Thanks!
Attachment #8801647 -
Flags: review?(mconley) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb8fe24be758
[DateTime Input] Make background of reset button in input box transparent. r=mconley
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 6•8 years ago
|
||
The background is transparent now as of Nightly 52.0a1 2016-10-24. Thanks for that!
Though this change also made the X within the icon transparent, which should rather be white I guess.
Sebastian
You need to log in
before you can comment on or make changes to this bug.
Description
•