Closed Bug 131060 Opened 23 years ago Closed 23 years ago

Dragging bookmark crashes Mozilla [@ nsMenuFrame::NotifyStateChanged]

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME
Milestone:
mozilla1.0

People

(Reporter: xpejchal, Assigned: bugs)

References

Details

(4 keywords, Whiteboard: [adt1])

Crash Data

Attachments

(1 file)

Stack of the crash mentioned above
6.08 KB, text/plain
Details
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9+) Gecko/20020314 BuildID: 2002031403 Draging bookmark to a folder in Personal Bookmark Folder crashes Mozilla. Reproducible: Always Steps to Reproduce: Drag bookmark to a folder in the Personal Bookmark Folder. Directly from browser, not from Manage Bookmarks.
Do you have a Talkback ID of your crash ?
Keywords: crash
I dont now what exactly a Talback ID is. But my user name is 3295 and it was send.
Please run Mozilla\components\talkbac.exe manually to get the TB ID. (or have you added your bugzilla email adress in the TB inicent ?)
TB4057908Y TB4056335Q TB4054161X TB4057908Y TB4057908Y TB4051691W TB4051256Y
nsMenuFrame::NotifyStateChanged [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuFrame.cpp, line 2106] nsMenuPopupFrame::SetCurrentMenuItem [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuPopupFrame.cpp, line 1459] nsMenuFrame::HandleEvent [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuFrame.cpp, line 513] nsEventStateManager::GenerateMouseEnterExit [d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp, line 2321] nsEventStateManager::PreHandleEvent [d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp, line 381] PresShell::HandleEventInternal [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 6051] PresShell::HandleEvent [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5979] nsViewManager::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 2043] nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 306] nsViewManager::DispatchEvent [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 1863] HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 83] nsWindow::DispatchEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 869] nsWindow::DispatchWindowEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 886] nsWindow::DispatchMouseEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 4713] ChildWindow::DispatchMouseEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 4963] nsWindow::DispatchMouseEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 4775] ChildWindow::DispatchMouseEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 4963] nsWindow::ProcessMessage [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 3630] nsWindow::WindowProc [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 1131] USER32.DLL + 0x1b60 (0x77e11b60) USER32.DLL + 0x1cca (0x77e11cca) USER32.DLL + 0x83f1 (0x77e183f1) nsAppShellService::Run [d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 309] main1 [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1366] main [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1701] WinMain [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1719] WinMainCRTStartup() KERNEL32.DLL + 0xd326 (0x77e8d326)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Screenshot of situation can be found at http://www.fi.muni.cz/~xpejchal/c.png
Summary: Dragging bookmark crashes Mozilla → Dragging bookmark crashes Mozilla [@nsMenuFrame::NotifyStateChanged]
I get a crash when dragging a bookmark out of the bookmark dropdown and dropping anywhere on the personal toolbar. It doesn't have to be into a folder. I'm seeing this on win98. I know this was working, adding regression keyword.
Keywords: regression
Also just found that this only occurs with the first window opened.
Here is the stack trace I'm getting with a cvs build from last night (3-22-02). nsMenuFrame::NotifyStateChanged(nsMenuFrame * const 0x029db684, nsIMenuFrame * 0x00000000) line 2115 + 58 bytes nsMenuPopupFrame::SetCurrentMenuItem(nsMenuPopupFrame * const 0x029babcc, nsIMenuFrame * 0x00000000) line 1455 nsMenuFrame::OpenMenuInternal(int 0) line 895 nsMenuFrame::AttributeChanged(nsMenuFrame * const 0x006d387c, nsIPresContext * 0x02406890, nsIContent * 0x024b5960, int 0, nsIAtom * 0x008028e0, int 3, int 5) line 718 nsCSSFrameConstructor::AttributeChanged(nsCSSFrameConstructor * const 0x02406070, nsIPresContext * 0x02406890, nsIContent * 0x024b5960, int 0, nsIAtom * 0x008028e0, int 3, int 3) line 10773 + 29 bytes StyleSetImpl::AttributeChanged(StyleSetImpl * const 0x024060e0, nsIPresContext * 0x02406890, nsIContent * 0x024b5960, int 0, nsIAtom * 0x008028e0, int 3, int -1) line 1504 PresShell::AttributeChanged(PresShell * const 0x02407d38, nsIDocument * 0x023f4470, nsIContent * 0x024b5960, int 0, nsIAtom * 0x008028e0, int 3, int -1) line 5138 + 56 bytes nsXULDocument::AttributeChanged(nsXULDocument * const 0x023f4470, nsIContent * 0x024b5960, int 0, nsIAtom * 0x008028e0, int 3, int -1) line 2072 nsXULElement::UnsetAttr(nsXULElement * const 0x024b5960, int 0, nsIAtom * 0x008028e0, int 1) line 3009 nsXULElement::RemoveAttribute(nsXULElement * const 0x024b5964, const nsAString & {...}) line 1353 + 24 bytes nsMenuFrame::OpenMenu(nsMenuFrame * const 0x006d38f8, int 0) line 748 + 68 bytes nsMenuPopupFrame::DismissChain(nsMenuPopupFrame * const 0x029babcc) line 1741 nsMenuDismissalListener::Rollup(nsMenuDismissalListener * const 0x028ce3a8) line 107 nsWindow::DealWithPopups(unsigned int 513, unsigned int 1, long 2360170, long * 0x0067fab8) line 1071 nsWindow::WindowProc(HWND__ * 0x00000ea0, unsigned int 513, unsigned int 1, long 2360170) line 1099 + 18 bytes KERNEL32! bff7363b() KERNEL32! bff94407() 00678b36()
One more thing I found. The crash doesn't actually occur until you click after dropping the bookmark. It also can be prevented totally if you click back in the bookmark popup first after dropping.
Adding topcrash and qawanted keywords. Also nominating for nsbeta1. This has been a topcrasher on recent MozillaTrunk builds. Here is just one set of crashes reported by Talkback: Count Offset Real Signature [ 13 nsMenuFrame::NotifyStateChanged 67d3e1a3 - nsMenuFrame::NotifyStateChanged ] Crash date range: 2002-03-14 to 2002-03-23 Min/Max Seconds since last crash: 29 - 307059 Min/Max Runtime: 124 - 307088 Keyword List : bookmark(6), Count Platform List 13 Windows NT 5.0 build 2195 Count Build Id List 4 2002031411 3 2002031405 2 2002031711 1 2002032205 1 2002031910 1 2002031805 1 2002031611 No of Unique Users 12 Stack trace(Frame) nsMenuFrame::NotifyStateChanged [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuFrame.cpp line 2116] nsMenuPopupFrame::SetCurrentMenuItem [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuPopupFrame.cpp line 1455] nsMenuFrame::HandleEvent [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuFrame.cpp line 513] nsEventStateManager::GenerateMouseEnterExit [d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp line 2321] nsEventStateManager::PreHandleEvent [d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp line 381] PresShell::HandleEventInternal [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp line 6078] PresShell::HandleEvent [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp line 6006] nsViewManager::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp line 2064] nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp line 306] nsViewManager::DispatchEvent [d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp line 1876] HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp line 83] nsWindow::DispatchEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 869] nsWindow::DispatchWindowEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 886] nsWindow::DispatchMouseEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 4713] ChildWindow::DispatchMouseEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 4963] nsWindow::DispatchMouseEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 4775] ChildWindow::DispatchMouseEvent [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 4963] nsWindow::ProcessMessage [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 3630] nsWindow::WindowProc [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp line 1131] USER32.DLL + 0x1b60 (0x77e11b60) USER32.DLL + 0x1cca (0x77e11cca) USER32.DLL + 0x83f1 (0x77e183f1) nsAppShellService::Run [d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp line 309] main1 [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp line 1366] main [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp line 1701] WinMain [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp line 1719] WinMainCRTStartup() KERNEL32.DLL + 0xd326 (0x77e8d326) (4375670) Comments: Draging bookmark to personal toolbar folder. (4308997) Comments: Deleting theme eskimo. (4308806) Comments: Switching to and deleting themes that are incompatible with 0.9.9+. (4181700) Comments: Dragging bookmark. (4057908) URL: http://www.sixdegreesrecords.com/ (4056335) URL: http://www.sixdegreesrecords.com/ (4054161) URL: http://www.sixdegreesrecords.com/ (4053209) URL: http://www.sixdegreesrecords.com/ (4053209) Comments: Mooving Bookmark. (4051691) URL: http://www.sixdegreesrecords.com/ (4051691) Comments: I've bookmarked http://www.sixdegreesrecords.com/. I've tried to drag&drop it from Bookmarks to toolbar? Don't know how you call it.Works for me every time I try it.(3x) (4051256) URL: www.allmusic.com (4051256) Comments: Mooving bookmark (4051006) URL: www.allmusic.com (4051006) Comments: Mooving bookmark I have not been able to reproduce this one, but if we can get a testcase for this, it would be nice to get a nsbeta1+ for this one.
Keywords: nsbeta1, qawanted, topcrash
Summary: Dragging bookmark crashes Mozilla [@nsMenuFrame::NotifyStateChanged] → Dragging bookmark crashes Mozilla [@ nsMenuFrame::NotifyStateChanged]
Ok, the actual sequence of events for me to reproduce this are: 1. Shutdown mozilla. (Make sure turbo mode isn't running in the background) 2. Open navigator. 3. Open the bookmark button on the personal toolbar. 4. Drag a bookmark out of the popup and drop it on the personal toolbar (This has to be an actual bookmark not a folder. Imported IE bookmarks seem to be exempt from the crash also). 5. Click in the content area or anywhere other than the still open popup. 6. Crash.
Adding testcase keyword and making this topcrash+. I was able to reproduce this crash using the steps in comment #12 (WinNT, build 2002032610): Incident ID 4510666 Stack Signature nsMenuFrame::NotifyStateChanged a64a18d8 Trigger Time 2002-03-26 16:02:56 Email Address jpatel@netscape.com URL visited bookmarks Build ID 2002032610 Product ID MozillaTrunk Platform Operating System Win32 Module Trigger Reason Access violation User Comments trying to reproduce bug 131060 using the steps in Comment #12 Stack Trace nsMenuFrame::NotifyStateChanged [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuFrame.cpp, line 2116] nsMenuPopupFrame::SetCurrentMenuItem [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuPopupFrame.cpp, line 1457] nsMenuFrame::OpenMenuInternal [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuFrame.cpp, line 895] nsMenuFrame::AttributeChanged [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuFrame.cpp, line 718] nsCSSFrameConstructor::AttributeChanged [d:\builds\seamonkey\mozilla\layout\html\style\src\nsCSSFrameConstructor.cpp, line 10784] StyleSetImpl::AttributeChanged [d:\builds\seamonkey\mozilla\content\base\src\nsStyleSet.cpp, line 1504] PresShell::AttributeChanged [d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5140] nsXULDocument::AttributeChanged [d:\builds\seamonkey\mozilla\content\xul\document\src\nsXULDocument.cpp, line 2077] nsXULElement::UnsetAttr [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 3019] nsXULElement::RemoveAttribute [d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 1367] nsMenuFrame::OpenMenu [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuFrame.cpp, line 750] nsMenuPopupFrame::DismissChain [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuPopupFrame.cpp, line 1744] nsMenuDismissalListener::Rollup [d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuDismissalListener.cpp, line 107] nsWindow::DealWithPopups [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 1071] nsWindow::WindowProc [d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 1100] USER32.dll + 0x1820 (0x77e71820) 0x005404e8 It took me a a few tries to grab a bookmark and drag it...but once I did and added it to the toolbar...I just clicked anywhere in the window to get the crash.
Keywords: qawanted, topcrash → testcase, topcrash+
FYI, build 2002030508 does not have this crash but build 2002031305 does. I'll work on narrowing it down some more tonight.
nsbeta1+/adt1 per nav triage team.
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt1]
Target Milestone: --- → mozilla1.0
On a fresh build pulled this morning this is works for me again.
Oops. I didn't realise the -D cvs option was sticky. So that was a 3-13 tree that I had built not 4-2. Sorry.
Well, I haven't been able to reproduce this with recent builds...and Talkback data shows this last happened with builds from 3/26. Jiri: Are you able to reproduce this anymore? If the reporter and everyone else are no longer crashing, do we know of any checkin that might have fixed this around 3/25-3/26? If so, we should mark this fixed...otherwise this can be marked worksforme.
Ok, this does work for me with a fresh build. Also I might have my time period above, for this bug appearing, off by a day.
Blocks: 134771
Well, something must have fixed this around 3/26...but since we don't know exactly what, marking this worksforme. If anyone is able to reproduce this crash please reopen.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
I think I just reproduced this one with Mozilla 1.0.0 RC1 on Win95. Talkback ID TB5409576Q (and TB5378596E yesterday) I do not reopen at the moment because I'm not sure if it is in fact the same bug (dragged bookmark from URLbar, not Bookmarks popup), but will do so if there is no reaction during the next week or so. At least the steps I got there very similarly as the reporter described: I dragged a bookmark icon (proxy icon) *from URLbar* (location bar) to a folder in the personal toolbar (bookmark toolbar). The crash appeared *without* clicking again anywhere, and yes, it was the first and only window I had opened. This crash happens quite often with me, but not everytime I try it. The visited site seems not to affect if Mozilla crashes: next time I tried to bookmark that page (it really was http://bugzilla.mozilla.org/show_bug.cgi?id=131060 !) there was no crash. I always can tell that it will crash, if after releasing the mouse button there is some harddisk activity! (Pentium 200, 64 MB, NS 4.7 and two other applications also running) The crash ahappens here about after half a second of this HD activity/after mouse button release. If there is no HD activity, there will be no crash.
Andreas, your stacks don't match the ones listed in this bug. Different crash.
Product: Browser → Seamonkey
Crash Signature: [@ nsMenuFrame::NotifyStateChanged]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: