Closed
Bug 1310665
Opened 8 years ago
Closed 7 years ago
[webvr] Implement macOS Support for OpenVR
Categories
(Core :: WebVR, defect)
Core
WebVR
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: kip, Assigned: kip)
References
Details
(Whiteboard: [webvr])
Attachments
(1 file, 2 obsolete files)
No description provided.
Updated•8 years ago
|
Summary: [webvr] Implement Mac OSX Support for OpenVR → [webvr] Implement macOS Support for OpenVR
Whiteboard: [webvr]
Assignee | ||
Updated•7 years ago
|
Component: Graphics → WebVR
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
I am cleaning up the try push, then will assign to review with aim to land in m-c
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 23•7 years ago
|
||
I have moved the part 1 patch to its own bug, Bug 1374393.
Assignee | ||
Comment 24•7 years ago
|
||
Updated dependencies. macOS support will use an IOSurface and won't require OpenGL specific direct rendering support.
No longer depends on: 1310660
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8874588 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8874590 -
Attachment is obsolete: true
Assignee | ||
Comment 26•7 years ago
|
||
The Linux specific changes are being moved to Bug 1374400 to land separately.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8874589 -
Flags: review?(dmu)
Assignee | ||
Updated•7 years ago
|
Attachment #8874589 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 32•7 years ago
|
||
@mattwoodrow Could you please review the gfx/2d and gfx/layers part of this patch? We would like to use IOSurface directly with the OpenVR API so had to add some getter methods.
Flags: needinfo?(matt.woodrow)
Comment 33•7 years ago
|
||
mozreview-review |
Comment on attachment 8874589 [details] Bug 1310665 - macOS OpenVR Support https://reviewboard.mozilla.org/r/145932/#review165966
Attachment #8874589 -
Flags: review?(matt.woodrow) → review+
Comment 34•7 years ago
|
||
mozreview-review |
Comment on attachment 8874589 [details] Bug 1310665 - macOS OpenVR Support https://reviewboard.mozilla.org/r/145932/#review166154 LGTM. just some indentation problems need to be fixed. ::: gfx/vr/gfxVROpenVR.h:74 (Diff revision 14) > + bool SubmitFrame(void* aTextureHandle, > + ::vr::ETextureType aTextureType, > + const IntSize& aSize, > + const gfx::Rect& aLeftEyeRect, > + const gfx::Rect& aRightEyeRect); > }; It seems to have indentation problems here. ::: gfx/vr/gfxVROpenVR.cpp:331 (Diff revision 14) > > +#if defined(XP_WIN) > + > +bool > +VRDisplayOpenVR::SubmitFrame(TextureSourceD3D11* aSource, > + const IntSize& aSize, It seems to have indentation problems here.
Attachment #8874589 -
Flags: review?(dmu) → review+
Comment hidden (mozreview-request) |
Comment 36•7 years ago
|
||
Pushed by kgilbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e50c3345c288 macOS OpenVR Support r=daoshengmu,mattwoodrow
Comment 37•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e50c3345c288
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•