Closed Bug 1310665 Opened 8 years ago Closed 7 years ago

[webvr] Implement macOS Support for OpenVR

Categories

(Core :: WebVR, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: kip, Assigned: kip)

References

Details

(Whiteboard: [webvr])

Attachments

(1 file, 2 obsolete files)

      No description provided.
Summary: [webvr] Implement Mac OSX Support for OpenVR → [webvr] Implement macOS Support for OpenVR
Whiteboard: [webvr]
Component: Graphics → WebVR
I am cleaning up the try push, then will assign to review with aim to land in m-c
Depends on: 1374393
I have moved the part 1 patch to its own bug, Bug 1374393.
Updated dependencies.  macOS support will use an IOSurface and won't require OpenGL specific direct rendering support.
No longer depends on: 1310660
Attachment #8874588 - Attachment is obsolete: true
Attachment #8874590 - Attachment is obsolete: true
The Linux specific changes are being moved to Bug 1374400 to land separately.
Attachment #8874589 - Flags: review?(dmu)
Attachment #8874589 - Flags: review?(matt.woodrow)
@mattwoodrow Could you please review the gfx/2d and gfx/layers part of this patch?  We would like to use IOSurface directly with the OpenVR API so had to add some getter methods.
Flags: needinfo?(matt.woodrow)
Blocks: 1383907
Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

https://reviewboard.mozilla.org/r/145932/#review165966
Attachment #8874589 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

https://reviewboard.mozilla.org/r/145932/#review166154

LGTM. just some indentation problems need to be fixed.

::: gfx/vr/gfxVROpenVR.h:74
(Diff revision 14)
> +  bool SubmitFrame(void* aTextureHandle,
> +                 ::vr::ETextureType aTextureType,
> +                 const IntSize& aSize,
> +                 const gfx::Rect& aLeftEyeRect,
> +                 const gfx::Rect& aRightEyeRect);
>  };

It seems to have indentation problems here.

::: gfx/vr/gfxVROpenVR.cpp:331
(Diff revision 14)
>  
> +#if defined(XP_WIN)
> +
> +bool
> +VRDisplayOpenVR::SubmitFrame(TextureSourceD3D11* aSource,
> +  const IntSize& aSize,

It seems to have indentation problems here.
Attachment #8874589 - Flags: review?(dmu) → review+
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e50c3345c288
macOS OpenVR Support r=daoshengmu,mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/e50c3345c288
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Clearing NI

Flags: needinfo?(matt.woodrow)
You need to log in before you can comment on or make changes to this bug.