1310665 - [webvr] Implement macOS Support for OpenVR

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Comment 1

[:kip (Kearwood Gilbert)]

Attachment: Bug 1310665 - Part 1: Build OpenVR on macOS and Linux

- OpenVR was previously only being built for Windows builds
  it will now be built additionally on macOS and Linux.

Review commit: https://reviewboard.mozilla.org/r/145930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145930/

Comment 2

[:kip (Kearwood Gilbert)]

Attachment: Bug 1310665 - macOS OpenVR Support

Review commit: https://reviewboard.mozilla.org/r/145932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145932/

Comment 3

[:kip (Kearwood Gilbert)]

Attachment: Bug 1310665 - Part 3: Enable OpenVR on macOS and Linux

Review commit: https://reviewboard.mozilla.org/r/145934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145934/

Comment 4

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/1-2/

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8874590 [details]
Bug 1310665 - Part 3: Enable OpenVR on macOS and Linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145934/diff/1-2/

Comment 6

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/2-3/

Comment 7

[:kip (Kearwood Gilbert)]

Comment on attachment 8874590 [details]
Bug 1310665 - Part 3: Enable OpenVR on macOS and Linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145934/diff/2-3/

Comment 8

[:kip (Kearwood Gilbert)]

I am cleaning up the try push, then will assign to review with aim to land in m-c

Comment 10

[:kip (Kearwood Gilbert)]

Comment on attachment 8874588 [details]
Bug 1310665 - Part 1: Build OpenVR on macOS and Linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145930/diff/1-2/

Comment 11

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/3-4/

Comment 12

[:kip (Kearwood Gilbert)]

Comment on attachment 8874590 [details]
Bug 1310665 - Part 3: Enable OpenVR on macOS and Linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145934/diff/3-4/

Comment 13

[:kip (Kearwood Gilbert)]

Comment on attachment 8874588 [details]
Bug 1310665 - Part 1: Build OpenVR on macOS and Linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145930/diff/2-3/

Comment 14

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/4-5/

Comment 15

[:kip (Kearwood Gilbert)]

Comment on attachment 8874590 [details]
Bug 1310665 - Part 3: Enable OpenVR on macOS and Linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145934/diff/4-5/

Comment 16

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/5-6/

Comment 17

[:kip (Kearwood Gilbert)]

Comment on attachment 8874590 [details]
Bug 1310665 - Part 3: Enable OpenVR on macOS and Linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145934/diff/5-6/

Comment 18

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/6-7/

Comment 19

[:kip (Kearwood Gilbert)]

Comment on attachment 8874590 [details]
Bug 1310665 - Part 3: Enable OpenVR on macOS and Linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145934/diff/6-7/

Comment 20

[:kip (Kearwood Gilbert)]

Comment on attachment 8874588 [details]
Bug 1310665 - Part 1: Build OpenVR on macOS and Linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145930/diff/3-4/

Comment 21

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/7-8/

Comment 22

[:kip (Kearwood Gilbert)]

Comment on attachment 8874590 [details]
Bug 1310665 - Part 3: Enable OpenVR on macOS and Linux

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145934/diff/7-8/

Comment 23

[:kip (Kearwood Gilbert)]

I have moved the part 1 patch to its own bug, Bug 1374393.

Comment 24

[:kip (Kearwood Gilbert)]

Updated dependencies.  macOS support will use an IOSurface and won't require OpenGL specific direct rendering support.

Comment 25

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/8-9/

Comment 26

[:kip (Kearwood Gilbert)]

The Linux specific changes are being moved to Bug 1374400 to land separately.

Comment 27

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/9-10/

Comment 28

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/10-11/

Comment 29

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/11-12/

Comment 30

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/12-13/

Comment 31

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/13-14/

Comment 32

[:kip (Kearwood Gilbert)]

@mattwoodrow Could you please review the gfx/2d and gfx/layers part of this patch?  We would like to use IOSurface directly with the OpenVR API so had to add some getter methods.

Comment 33

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

https://reviewboard.mozilla.org/r/145932/#review165966

Comment 34

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

https://reviewboard.mozilla.org/r/145932/#review166154

LGTM. just some indentation problems need to be fixed.

::: gfx/vr/gfxVROpenVR.h:74
(Diff revision 14)
> +  bool SubmitFrame(void* aTextureHandle,
> +                 ::vr::ETextureType aTextureType,
> +                 const IntSize& aSize,
> +                 const gfx::Rect& aLeftEyeRect,
> +                 const gfx::Rect& aRightEyeRect);
>  };

It seems to have indentation problems here.

::: gfx/vr/gfxVROpenVR.cpp:331
(Diff revision 14)
>  
> +#if defined(XP_WIN)
> +
> +bool
> +VRDisplayOpenVR::SubmitFrame(TextureSourceD3D11* aSource,
> +  const IntSize& aSize,

It seems to have indentation problems here.

Comment 35

[:kip (Kearwood Gilbert)]

Comment on attachment 8874589 [details]
Bug 1310665 - macOS OpenVR Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145932/diff/14-15/

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e50c3345c288
macOS OpenVR Support r=daoshengmu,mattwoodrow

Comment 37

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e50c3345c288

Comment 38

[:kip (Kearwood Gilbert)]

Clearing NI