1310937 - Autophone - mozdevice - sync adb

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Autophone and mozdevice have diverged with regard to adb*.py and friends. We should sync them back up and make sure they remain synced in the future.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: mozdevice bug-1238450.patch

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: mozdevice bug-1241267.patch

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: mozdevice bug-1242070.patch

Comment 4

[Bob Clary [:bc] (inactive)]

Attachment: mozdevice bug-1249120-01.patch

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: mozdevice bug-1249120-02.patch

Comment 6

[Bob Clary [:bc] (inactive)]

Attachment: mozdevice bug-1300890.patch

Comment 7

[Bob Clary [:bc] (inactive)]

Attachment: autophone - bug-1310937-01-1236467.patch

Comment 8

[Bob Clary [:bc] (inactive)]

Attachment: autophone - bug-1310937-02-1257510.patch

Comment 9

[Bob Clary [:bc] (inactive)]

Attachment: autophone - bug-1310937-03-1280573.patch

Comment 10

[Bob Clary [:bc] (inactive)]

Note:

* adb*.py, version_codes.py are identical across Autophone and mozdevice after these patches.
* ./mach lint -l flake8 passes in mozdevice after these patches.

I'm not sure how useful it will be but I did a try run on android opt,debug will all Android unittests:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1820b3e725d3a8bde454c342db59681380545f0f

Comment 11

[Bob Clary [:bc] (inactive)]

mmm. Don't know why  ./mach lint -l flake8 missed this...

TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/testing/mozbase/mozdevice/mozdevice/adb.py:1654:35 | at least two spaces before inline comment (E261) 

This is from mozdevice bug-1249120-01.patch. New patch coming up.

Comment 12

[Bob Clary [:bc] (inactive)]

Attachment: mozdevice bug-1249120-01.patch

Comment 13

[Bob Clary [:bc] (inactive)]

Attachment: autophone - bug-1310937-04-1249120.patch

Comment 14

[Geoff Brown [:gbrown]]

Comment on attachment 8802010 [details] [diff] [review]
mozdevice bug-1241267.patch

Review of attachment 8802010 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozdevice/mozdevice/adb_android.py
@@ +269,5 @@
>                   * ADBError
>          """
> +        cmd = ["install"]
> +        if self.version >= version_codes.M:
> +            cmd.append("-g")

"install -g" is a little controversial. Some Firefox devs have said they don't want "mach install" to use -g because they want to know which runtime permissions are required and sometimes they want to test runtime permissions, grant them manually, etc. That's not a direct concern here because 'mach install' leverages 'make install', which is implemented independently - https://hg.mozilla.org/mozilla-central/annotate/43ebf330ad94/mobile/android/build.mk#l40.

@@ +424,5 @@
>              executed as root.
>          :raises: * ADBTimeoutError
>                   * ADBError
>          """
> +        if self.version >= version_codes.HONEYCOMB:

Honeycomb is no longer supported by Firefox. Should we keep making allowance for it? Perhaps not an issue for this bug.

Comment 15

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8802015 [details] [diff] [review]
mozdevice bug-1300890.patch

Review of attachment 8802015 [details] [diff] [review]:
-----------------------------------------------------------------

we really should |hg rm adb_b2g.py| since we do not officially support b2g and have been removing it from the code base.

Comment 16

[Geoff Brown [:gbrown]]

Comment on attachment 8802011 [details] [diff] [review]
mozdevice bug-1242070.patch

Review of attachment 8802011 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozdevice/mozdevice/adb.py
@@ +1434,5 @@
>          :raises: * ADBTimeoutError
>                   * ADBRootError
>                   * ADBError
>          """
> +        # Note the on some tests such as webappstartup, an error

s/Note the/Note that/

Comment 17

[Geoff Brown [:gbrown]]

Comment on attachment 8802013 [details] [diff] [review]
mozdevice bug-1249120-02.patch

Review of attachment 8802013 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozdevice/mozdevice/adb.py
@@ +1434,5 @@
>          :raises: * ADBTimeoutError
>                   * ADBRootError
>                   * ADBError
>          """
> +        # Note that on some tests such as webappstartup, an error

Oh, there it is!

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/815de87b6dba
Autophone - mozdevice - sync Bug 1238450 - Autophone - adb.py - use ifconfig interface or netcfg to obtain ip address, r=gbrown
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b6b91ca5d50
Autophone - mozdevice - sync Bug 1241267 - Autophone - adb_android.py - use install -g on Marshmallow to grant permissions at install time, r=gbrown.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c9959b4e6aa
Autophone - mozdevice - sync Bug 1242070 - Autophone - adb.py - use native recursion with chmod when supported by the device, r=gbrown.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f971af82e5b
Autophone - mozdevice - sync Bug 1249120 - Autophone - adb.py - add ADBDevice.ls, r=gbrown.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f332f66d3c6b
Autophone - mozdevice - sync Bug 1249120 - Autophone - use unrolled recursive chmod when -R not supported, r=gbrown.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7362a3b3d239
Autophone - mozdevice - sync Bug 1300890 - Autophone - pylint fixes and logging clean up, r=jmaher.

Comment 19

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/12894623d891efef2dba0c0ffaf9512c4860dc19
https://github.com/mozilla/autophone/commit/5f880708173e676a03ed23062ad5d30d12190a94
https://github.com/mozilla/autophone/commit/66eadd8bc6066e86cf8f003e711e15a30863fb4b
https://github.com/mozilla/autophone/commit/c8b7c91f84e401ffe6d4ebceb57106943d76af29

Comment 20

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/815de87b6dba
https://hg.mozilla.org/mozilla-central/rev/5b6b91ca5d50
https://hg.mozilla.org/mozilla-central/rev/5c9959b4e6aa
https://hg.mozilla.org/mozilla-central/rev/9f971af82e5b
https://hg.mozilla.org/mozilla-central/rev/f332f66d3c6b
https://hg.mozilla.org/mozilla-central/rev/7362a3b3d239