Closed Bug 1310937 Opened 8 years ago Closed 8 years ago

Autophone - mozdevice - sync adb

Categories

(Testing Graveyard :: Autophone, defect)

defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(10 files, 1 obsolete file)

6.29 KB, patch
gbrown
: review+
Details | Diff | Splinter Review
4.11 KB, patch
gbrown
: review+
Details | Diff | Splinter Review
3.87 KB, patch
gbrown
: review+
Details | Diff | Splinter Review
5.33 KB, patch
gbrown
: review+
Details | Diff | Splinter Review
9.22 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
1.85 KB, patch
ahal
: review+
Details | Diff | Splinter Review
3.45 KB, patch
ahal
: review+
Details | Diff | Splinter Review
5.23 KB, patch
ahal
: review+
Details | Diff | Splinter Review
4.89 KB, patch
gbrown
: review+
Details | Diff | Splinter Review
715 bytes, patch
Details | Diff | Splinter Review
Autophone and mozdevice have diverged with regard to adb*.py and friends. We should sync them back up and make sure they remain synced in the future.
Attachment #8802009 - Flags: review?(gbrown)
Attachment #8802010 - Flags: review?(gbrown)
Attachment #8802011 - Flags: review?(gbrown)
Attached patch mozdevice bug-1249120-01.patch (obsolete) — Splinter Review
Attachment #8802012 - Flags: review?(gbrown)
Attachment #8802013 - Flags: review?(gbrown)
Attachment #8802015 - Flags: review?(jmaher)
Attachment #8802020 - Flags: review?(ahalberstadt)
Attachment #8802021 - Flags: review?(ahalberstadt)
Attachment #8802022 - Flags: review?(ahalberstadt)
Note:

* adb*.py, version_codes.py are identical across Autophone and mozdevice after these patches.
* ./mach lint -l flake8 passes in mozdevice after these patches.

I'm not sure how useful it will be but I did a try run on android opt,debug will all Android unittests:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1820b3e725d3a8bde454c342db59681380545f0f
Blocks: 1306703
mmm. Don't know why  ./mach lint -l flake8 missed this...

TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/testing/mozbase/mozdevice/mozdevice/adb.py:1654:35 | at least two spaces before inline comment (E261) 

This is from mozdevice bug-1249120-01.patch. New patch coming up.
Attachment #8802012 - Attachment is obsolete: true
Attachment #8802012 - Flags: review?(gbrown)
Attachment #8802042 - Flags: review?(gbrown)
Attachment #8802009 - Flags: review?(gbrown) → review+
Comment on attachment 8802010 [details] [diff] [review]
mozdevice bug-1241267.patch

Review of attachment 8802010 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozdevice/mozdevice/adb_android.py
@@ +269,5 @@
>                   * ADBError
>          """
> +        cmd = ["install"]
> +        if self.version >= version_codes.M:
> +            cmd.append("-g")

"install -g" is a little controversial. Some Firefox devs have said they don't want "mach install" to use -g because they want to know which runtime permissions are required and sometimes they want to test runtime permissions, grant them manually, etc. That's not a direct concern here because 'mach install' leverages 'make install', which is implemented independently - https://hg.mozilla.org/mozilla-central/annotate/43ebf330ad94/mobile/android/build.mk#l40.

@@ +424,5 @@
>              executed as root.
>          :raises: * ADBTimeoutError
>                   * ADBError
>          """
> +        if self.version >= version_codes.HONEYCOMB:

Honeycomb is no longer supported by Firefox. Should we keep making allowance for it? Perhaps not an issue for this bug.
Attachment #8802010 - Flags: review?(gbrown) → review+
Comment on attachment 8802015 [details] [diff] [review]
mozdevice bug-1300890.patch

Review of attachment 8802015 [details] [diff] [review]:
-----------------------------------------------------------------

we really should |hg rm adb_b2g.py| since we do not officially support b2g and have been removing it from the code base.
Attachment #8802015 - Flags: review?(jmaher) → review+
Comment on attachment 8802011 [details] [diff] [review]
mozdevice bug-1242070.patch

Review of attachment 8802011 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozdevice/mozdevice/adb.py
@@ +1434,5 @@
>          :raises: * ADBTimeoutError
>                   * ADBRootError
>                   * ADBError
>          """
> +        # Note the on some tests such as webappstartup, an error

s/Note the/Note that/
Attachment #8802011 - Flags: review?(gbrown) → review+
Comment on attachment 8802013 [details] [diff] [review]
mozdevice bug-1249120-02.patch

Review of attachment 8802013 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozdevice/mozdevice/adb.py
@@ +1434,5 @@
>          :raises: * ADBTimeoutError
>                   * ADBRootError
>                   * ADBError
>          """
> +        # Note that on some tests such as webappstartup, an error

Oh, there it is!
Attachment #8802013 - Flags: review?(gbrown) → review+
Attachment #8802020 - Flags: review?(ahalberstadt) → review+
Attachment #8802021 - Flags: review?(ahalberstadt) → review+
Attachment #8802042 - Flags: review?(gbrown) → review+
Attachment #8802022 - Flags: review?(ahalberstadt) → review+
Pushed by bclary@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/815de87b6dba
Autophone - mozdevice - sync Bug 1238450 - Autophone - adb.py - use ifconfig interface or netcfg to obtain ip address, r=gbrown
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b6b91ca5d50
Autophone - mozdevice - sync Bug 1241267 - Autophone - adb_android.py - use install -g on Marshmallow to grant permissions at install time, r=gbrown.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c9959b4e6aa
Autophone - mozdevice - sync Bug 1242070 - Autophone - adb.py - use native recursion with chmod when supported by the device, r=gbrown.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f971af82e5b
Autophone - mozdevice - sync Bug 1249120 - Autophone - adb.py - add ADBDevice.ls, r=gbrown.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f332f66d3c6b
Autophone - mozdevice - sync Bug 1249120 - Autophone - use unrolled recursive chmod when -R not supported, r=gbrown.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7362a3b3d239
Autophone - mozdevice - sync Bug 1300890 - Autophone - pylint fixes and logging clean up, r=jmaher.
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: