1311096 - Adding a separator to bookmarks toolbar makes it too tall

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[James Long (:jlongster)]

A coworker has reproduced this in Nightly. Here is my bookmarks toolbar in Nightly:

http://jlongster.com/s/upload/ddcb19a2-7594-43ce-af0f-c848fd909c12.png

This looks correct. If I add a separator, however, it becomes way too tall:

http://jlongster.com/s/upload/9bd2280a-85cc-46a3-823e-a3c2fd4ea90b.png

Comment 1

[Stefan [:stefanh]]

Gijs, is bug 726132, comment #10 still valid? Or was that just about the tabs toolbar?

Comment 2

[:Gijs (out until Jan 5th; he/him)]

(In reply to Stefan [:stefanh] from comment #1)
> Gijs, is bug 726132, comment #10 still valid? Or was that just about the
> tabs toolbar?

That's about customizable toolbar items. The bookmarks toolbar items is a bookmarks container, which is governed by other code, which apparently lets you insert separators (which are menuseparators in the menu, for instance).

Comment 3

[Stefan [:stefanh]]

Attachment: Remove hardcoded toolbarseparator min-height

So it appears that the min-height used to be needed when the toolbars had '-moz-box-align: center' (bug 583510). Despite an ambitious archeological investigation I haven't find out when this was removed, but toolbars are now back to stretching, so we can remove the min-height.

Comment 4

[:Gijs (out until Jan 5th; he/him)]

Comment on attachment 8808744 [details] [diff] [review]
Remove hardcoded toolbarseparator min-height

Review of attachment 8808744 [details] [diff] [review]:
-----------------------------------------------------------------

wah. Huh, OK. Looks OK to me.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62b32efde227
Remove toolbarseparator min-height in browser.css since it affects the toolbar height. r=Gijs.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/62b32efde227

Comment 7

[Vuyisile Ndlovu [:terrameijar]]

I tested this on Fx 52.0b7 on Ubuntu. The problem does not reproduce anymore.