Closed
Bug 1311096
Opened 8 years ago
Closed 8 years ago
Adding a separator to bookmarks toolbar makes it too tall
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: jlong, Assigned: stefanh)
Details
Attachments
(1 file)
|
1.19 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
A coworker has reproduced this in Nightly. Here is my bookmarks toolbar in Nightly: http://jlongster.com/s/upload/ddcb19a2-7594-43ce-af0f-c848fd909c12.png This looks correct. If I add a separator, however, it becomes way too tall: http://jlongster.com/s/upload/9bd2280a-85cc-46a3-823e-a3c2fd4ea90b.png
|
||
Updated•8 years ago
|
Component: Toolbars and Customization → Theme
|
||
Updated•8 years ago
|
OS: Unspecified → Mac OS X
Priority: -- → P3
|
Assignee | |
Comment 1•8 years ago
|
||
Gijs, is bug 726132, comment #10 still valid? Or was that just about the tabs toolbar?
Flags: needinfo?(gijskruitbosch+bugs)
|
|
||
Comment 2•8 years ago
|
||
(In reply to Stefan [:stefanh] from comment #1) > Gijs, is bug 726132, comment #10 still valid? Or was that just about the > tabs toolbar? That's about customizable toolbar items. The bookmarks toolbar items is a bookmarks container, which is governed by other code, which apparently lets you insert separators (which are menuseparators in the menu, for instance).
Flags: needinfo?(gijskruitbosch+bugs)
|
|
Assignee | |
Comment 3•8 years ago
|
||
So it appears that the min-height used to be needed when the toolbars had '-moz-box-align: center' (bug 583510). Despite an ambitious archeological investigation I haven't find out when this was removed, but toolbars are now back to stretching, so we can remove the min-height.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #8808744 -
Flags: review?(gijskruitbosch+bugs)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8808744 -
Attachment description: Remove hardcoded toolbarseparator height → Remove hardcoded toolbarseparator min-height
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8808744 [details] [diff] [review] Remove hardcoded toolbarseparator min-height Review of attachment 8808744 [details] [diff] [review]: ----------------------------------------------------------------- wah. Huh, OK. Looks OK to me.
Attachment #8808744 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by stefanh@inbox.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/62b32efde227 Remove toolbarseparator min-height in browser.css since it affects the toolbar height. r=Gijs.
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/62b32efde227
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Comment 7•7 years ago
|
||
I tested this on Fx 52.0b7 on Ubuntu. The problem does not reproduce anymore.
|
||
Updated•7 years ago
|
QA Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•