1311209 - Update all-locales for SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Ian Neal]

At the moment all-locales under suite/locales does not seem to reflect what we ship.
Also see https://bugzilla.mozilla.org/show_bug.cgi?id=1307995
Looking at 2.40 download options, as far as I can see we need to remove:
be
da
ka
ro
si

One that is not on the download page, but seems fairly active is:
pt-BR

so should we be shipping that?

We've also had a request to allow localisation of Kabyle (kab) but that should be a separate bug...

Comment 1

[Philip Chee]

I think we should ship pt-BR if we can. Other than that, don't know.

Comment 2

[Philip Chee]

NI Adrian and Edmund

Comment 3

[Edmund Wong (:ewong)]

(In reply to Ian Neal from comment #0)
> At the moment all-locales under suite/locales does not seem to reflect what
> we ship.
> Also see https://bugzilla.mozilla.org/show_bug.cgi?id=1307995
> Looking at 2.40 download options, as far as I can see we need to remove:
> be
> da
> ka
> ro
> si
> 
> One that is not on the download page, but seems fairly active is:
> pt-BR
> 
> so should we be shipping that?
> 
> We've also had a request to allow localisation of Kabyle (kab) but that
> should be a separate bug...

be was only recently removed as a localization and as I understand it,
it still works in be. 

However, when doing repacks, we don't look at all-locales; but,
shipped-locales.  I don't know what all-locales is used for.  

KaiRo?

Comment 4

[Robert Kaiser]

(In reply to Edmund Wong (:ewong) from comment #3)
> KaiRo?

IIRC all-locales was what Nightly and those branches were building out of automation, shipped-locales is what the beta/release build process looks at.

Comment 5

[Edmund Wong (:ewong)]

(In reply to Robert Kaiser from comment #4)
> (In reply to Edmund Wong (:ewong) from comment #3)
> > KaiRo?
> 
> IIRC all-locales was what Nightly and those branches were building out of
> automation, shipped-locales is what the beta/release build process looks at.

Thanks KaiRo for the clarification.

Comment 6

[Robert Kaiser]

And, FWIW, that means that all-locales are all that we support / have teams working on at any level, while shipped-locales means those we actually ship, and the latter should always be a subset of the former.

Comment 7

[Adrian Kalla [:adriank]]

To sum up: we have to update the shipped-locales file, not the all-locales one.

Comment 8

[Edmund Wong (:ewong)]

Attachment: proposed patch

Aiui, only be needs to be removed (need to point be-users to ru).

Comment 9

[Robert Kaiser]

Comment on attachment 8828184 [details] [diff] [review]
proposed patch

Review of attachment 8828184 [details] [diff] [review]:
-----------------------------------------------------------------

::: suite/locales/all-locales
@@ -1,1 @@
> -be

Hmm, do we know that the be team is not interested in working on SeaMonkey any more? We only should remove from all-locales if it's officially abandoned (this file is only used for l10n-repacks on nightly and aurora). For shipped-locales, it's fine to remove if the respective release doesn't build and we aren't gonna ship in that language.
Make sure we update the affected release announcement message when we add/remove entries in shipped-locales.

Comment 10

[Robert Kaiser]

Edmund, see comment #9 for my question ;-)

Comment 11

[Edmund Wong (:ewong)]

(In reply to Robert Kaiser from comment #10)
> Edmund, see comment #9 for my question ;-)

Point taken.  Haven't pinged anyone from the be localization team.  Who is on point for the be localization team?

Comment 12

[Robert Kaiser]

(In reply to Edmund Wong (:ewong) from comment #11)
> (In reply to Robert Kaiser from comment #10)
> > Edmund, see comment #9 for my question ;-)
> 
> Point taken.  Haven't pinged anyone from the be localization team.  Who is
> on point for the be localization team?

https://wiki.mozilla.org/L10n:Teams:be is the contacts page for that team.

Comment 13

[Robert Kaiser]

Comment on attachment 8828184 [details] [diff] [review]
proposed patch

Review of attachment 8828184 [details] [diff] [review]:
-----------------------------------------------------------------

r+ based on email exchange with the team, thanks ewong!

Comment 14

[Edmund Wong (:ewong)]

OTR, I contacted the be contact and was told that none of the
be localizers are interested in doing localizations for SeaMonkey.

Comment 15

[Edmund Wong (:ewong)]

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/495489dbbfa52f82c5b82abddd2256219aabbc2c

Comment 16

[Edmund Wong (:ewong)]

Comment on attachment 8828184 [details] [diff] [review]
proposed patch

[Approval Request Comment]
Regression caused by (bug #): 1307995
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Be was removed from releases in Moco since Gecko 51, so we need this
patch pushed to c-a to c-r (future 2.48 relbranch and 2.49 release)

Comment 17

[Ian Neal]

Comment on attachment 8828184 [details] [diff] [review]
proposed patch

a=me where needed

Comment 18

[Edmund Wong (:ewong)]

Pushed to comm-beta:
https://hg.mozilla.org/releases/comm-beta/rev/c863825b864e (default)

https://hg.mozilla.org/releases/comm-beta/rev/630c22cbc776 (relbranch)

Comment 19

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8828184 [details] [diff] [review]
proposed patch

This one never made it to esr52

Comment 20

[Ian Neal]

Comment on attachment 8828184 [details] [diff] [review]
proposed patch

a=me

Comment 21

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr52/rev/5c732d81af6d6a778fdd90cd86c54f75e882790a