Closed Bug 1311211 Opened 4 years ago Closed 4 years ago

Disable -Gw optimizations when building for ASan

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
2.84 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
When the -Gw optimization folds together identical data objects (e.g. vtables), it upsets ASan's ODR violation detector.
Attached patch patch (obsolete) — — Splinter Review
Assignee: nobody → dmajor
Attachment #8802617 - Flags: review?(mh+mozilla)
Attached patch patch — — Splinter Review 
Comment fix that I forgot to qref
Attachment #8803994 - Flags: review?(mh+mozilla)
Attachment #8802617 - Attachment is obsolete: true
Attachment #8802617 - Flags: review?(mh+mozilla)
Attachment #8803994 - Flags: review?(mh+mozilla) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82104756f2c2
Disable -Gw optimization when building for ASan on Windows. r=glandium
https://hg.mozilla.org/mozilla-central/rev/82104756f2c2
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.