1311368 - Video content is not always loaded on NASA Television

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Note]:
- This issue is not e10s related

[Affected versions]:
- latest Nightly 52.0a1 (2016-10-18)
- latest Aurora 51.0a2 (2016-10-19)
- 50.0b8 build1 (20161017130949) 
- 49.0.2 build1 (20161018030522)

[Affected platforms]:
- Windows 10 x64
- Mac OS X 10.11.6
- Ubuntu 14.04 x86

[Steps to reproduce]:
1. Launch Firefox
2. Go to http://www.nasa.gov/multimedia/nasatv/index.html#public
3. Wait for the video content to be loaded 
4. Refresh several times the same page and wait for the video content to be loaded 

[Expected result]:
- The video content is properly loaded every time the page is accessed 

[Actual result]:
- The video content is not always loaded (about 40% of total accessing number) - it remains in a continuous loading process

[Regression range]:
- I will investigate this as soon as possible 
- So far I can tell that the issue is not reproducible on 46.0a1 (2016-01-01)

Comment 1

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

Sorry, I forgot to mention: this is also reproducible on 49.0.1-build3 (20160922113459), so it's not a recent regression.

Comment 2

[Benjamin Smedberg]

This is Flash, so I'm going to preliminarily call this a plugin-related bug. Although failure to load could also be networking.

Comment 3

[Alice0775 White]

I can reproduce on Windows10 Nightly52.0a1.

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8db356a0d5b5e3af4aeba8fc20baf45289acca92&tochange=f0bd5218a80748df118c8a14971cff2d260813a8

Seems triggered by: f0bd5218a807	Tobias Schneider — Bug 1275591 - Enable plugin content blocking by default. r=bsmedberg

Comment 4

[Alice0775 White]

Regression window w/ browser.safebrowsing.blockedURIs.enabled=true and e10s disabled/enabled:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=240f4848ed64b72befa92175acb404e22ac148fb&tochange=3a3f45f80219bbc3d9951eef0f0c1d9b00c0ab56


Regressed by: 3a3f45f80219	Tobias Schneider — Bug 1268120 - Make plugin content blocking work on e10s. r=francois


It is strange that the patch affect on non-e10s.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Too late to fix in 50.1.0 release

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Tobias, we're running low on time to fix this on 51. Have you had any chance to look at this recently?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Jet, can you please help find an owner to investigate this?

Comment 8

[Jet Villegas (inactive)]

Attachment: Fixes ShouldBlockContent logic when content blocking is enabled.

Tobias: please review and test this patch. It fixes the bug but I haven't tested it against your plugin-blocker tests. Please help get this one landed. Thanks!

Comment 9

[Tobias Schneider [:tobytailor]]

Can confirm that this fixes the issue. Also, all uri-blocking and safe-browsing tests are passing with this patch.

Comment 10

[Jet Villegas (inactive)]

Tobias: can you set up the appropriate uplifts too?

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fd8f1f47a32
Fix ShouldBlockContent logic when content blocking is enabled. r=tobytailor

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4fd8f1f47a32

Comment 13

[Tobias Schneider [:tobytailor]]

Comment on attachment 8834196 [details] [diff] [review]
Fixes ShouldBlockContent logic when content blocking is enabled.

Approval Request Comment
[Feature/regressing bug #]: 1311368
[User impact if declined]: Failing content.
[Describe test coverage new/current, TreeHerder]: Successfully tested in 540a1.
[Risks and why]: Prevents some video content from loading.
[String/UUID change made/needed]: No string or UUID changes.

Comment 14

[Gerry Chang [:gchang]]

Comment on attachment 8834196 [details] [diff] [review]
Fixes ShouldBlockContent logic when content blocking is enabled.

Fix a video content loading issue on nasa. Aurora53+.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/19f6f5f9bd23

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 8834196 [details] [diff] [review]
Fixes ShouldBlockContent logic when content blocking is enabled.

fix content blocking issue in beta52.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6f05f53c02cd

Comment 18

[Cornel Ionce [:noni] [Hubs QA]]

Iulia, could you please confirm this fix? 
Thank you!

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/6f05f53c02cd

Comment 20

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Cornel Ionce [QA] (:cornel_ionce) from comment #18)
> Iulia, could you please confirm this fix? 
> Thank you!

I can confirm that the issue is fixed on 54.0a1 (2017-02-20), 53.0a2 (2017-02-20), 52.0b8 (20170220070057) using Windows 10 x64, Mac OS X 10.11.6 and Ubuntu 16.04 x86.

Comment 21

[Gerry Chang [:gchang]]

Comment on attachment 8834196 [details] [diff] [review]
Fixes ShouldBlockContent logic when content blocking is enabled.

We don't have then plan to have dot release for 51. Rel51-.