Skip _notifyBackgroundTab for hidden tabs

RESOLVED FIXED

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

49 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
If a new background tab is added that is also hidden, we should skip the notification, similar to pinned tabs.
Comment hidden (mozreview-request)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8802587 [details]
Bug 1311439 - Skip _notifyBackgroundTab for hidden tabs.

https://reviewboard.mozilla.org/r/86948/#review85978

r=me

Please add the explanation you gave over IRC to the secondary part of the commit msg (ie after the first line).
Attachment #8802587 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Comment 3

7 months ago
Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6626c520f7f8
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Blocks: 1310860

Comment 5

7 months ago
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a39915ca6ab4
Skip _notifyBackgroundTab for hidden tabs. r=Gijs
(Assignee)

Comment 6

7 months ago
It appears this merged but the bug was not updated:

https://hg.mozilla.org/mozilla-central/rev/a39915ca6ab4
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.