1311439 - Skip _notifyBackgroundTab for hidden tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

If a new background tab is added that is also hidden, we should skip the notification, similar to pinned tabs.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1311439 - Skip _notifyBackgroundTab for hidden tabs.

Review commit: https://reviewboard.mozilla.org/r/86948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86948/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8802587 [details]
Bug 1311439 - Skip _notifyBackgroundTab for hidden tabs.

https://reviewboard.mozilla.org/r/86948/#review85978

r=me

Please add the explanation you gave over IRC to the secondary part of the commit msg (ie after the first line).

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6626c520f7f8

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8802587 [details]
Bug 1311439 - Skip _notifyBackgroundTab for hidden tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/86948/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a39915ca6ab4
Skip _notifyBackgroundTab for hidden tabs. r=Gijs

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It appears this merged but the bug was not updated:

https://hg.mozilla.org/mozilla-central/rev/a39915ca6ab4