Closed Bug 1311521 Opened 8 years ago Closed 8 years ago

Use LoginFormFactory instead of FormLikeFactory. Port Bug 1302474 and Bug 1310049 to SeaMonkey.

Categories

(SeaMonkey :: Autocomplete, defect)

Product:
SeaMonkey
Component:
Autocomplete
Platform:
All
Unspecified
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.48 unaffected, seamonkey2.49esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.49
Tracking Flags:
Tracking Status
seamonkey2.48 --- unaffected
seamonkey2.49esr --- fixed

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(1 file, 1 obsolete file)

1311521-FormLikeFactory-V2.patch
1.99 KB, patch
philip.chee
: review+
Details | Diff | Splinter Review 
In Bug 1310049 FormLikeFactory was refactored into its own module. We need to replace it with LoginFormfactory which wraps it for use in login specific contexts.
Attached patch 1311521-FormLikeFactory.patch (obsolete) — — Splinter Review 
Error is gone and likely all which is needed but something broke the actual suggestions popup again. I need to fix Bug 1300547 first.
Depends on: 1300547
Bug 1302474 changed a method name so took care of this here too. Uncoupling from bug 1300547 before the breaks pile up.
Attachment #8802688 - Attachment is obsolete: true
Attachment #8805775 - Flags: review?(iann_bugzilla)
Depends on: 1302474
No longer depends on: 1300547
See Also: → 1300547
Summary: Use LoginFormFactory instead of FormLikeFactory. Port Bug 1310049 to SeaMonkey. → Use LoginFormFactory instead of FormLikeFactory. Port Bug 1302474 and Bug 1310049 to SeaMonkey.
Attachment #8805775 - Flags: review?(iann_bugzilla) → review+
https://hg.mozilla.org/comm-central/rev/aa8363f77371667f71816b2cef1a53ef47104067
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
status-seamonkey2.49esr: affected → fixed
Target Milestone: --- → seamonkey2.49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: