1311587 - Crash in mozilla::gfx::VRControllerManagerOpenVR::HandleInput

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-bdb2293b-b14f-487e-a876-4eaf32161019.
=============================================================

Low volume crash that started with the 10-18 nightly. It's the #32 crash for that nightly on Windows with 6 crashes.

Daosheng, do you think this is a regression from bug 1299928?

Comment 1

[Daosheng Mu[:daoshengmu]]

(In reply to Jim Chen [:jchen] [:darchons] from comment #0)
> This bug was filed from the Socorro interface and is 
> report bp-bdb2293b-b14f-487e-a876-4eaf32161019.
> =============================================================
> 
> Low volume crash that started with the 10-18 nightly. It's the #32 crash for
> that nightly on Windows with 6 crashes.
> 
> Daosheng, do you think this is a regression from bug 1299928?

Thanks for notice. It is indeed a regression bug from bug 1299928. I am going to give a quick fix on this.

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1311587 - Make sure OpenVR is installed before handling user inputs;

Review commit: https://reviewboard.mozilla.org/r/87088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87088/

Comment 3

[Daosheng Mu[:daoshengmu]]

For some cases, we have added event listeners to VRManagerParent, but it does not be ready to register VRManager. When VRManager is notified to Vsync, the VRSystem at VRControllerManagerOpenVR would be a nullptr because it is not be initialized yet.

Comment 4

[:kip (Kearwood Gilbert)]

Comment on attachment 8802794 [details]
Bug 1311587 - Make sure OpenVR is installed before handling user inputs;

https://reviewboard.mozilla.org/r/87088/#review86258

Good catch, thanks for the quick fix!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Autoland couldn't rebase this commit automatically.

Comment 6

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8802794 [details]
Bug 1311587 - Make sure OpenVR is installed before handling user inputs;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/87088/diff/1-2/

Comment 7

[Daosheng Mu[:daoshengmu]]

(In reply to Daosheng Mu[:daoshengmu] from comment #6)
> Comment on attachment 8802794 [details]
> Bug 1311587 - Make sure OpenVR is installed before handling user inputs;
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/87088/diff/1-2/

Rebase m-c and check-in again

Comment 8

[:kip (Kearwood Gilbert)]

Comment on attachment 8802794 [details]
Bug 1311587 - Make sure OpenVR is installed before handling user inputs;

https://reviewboard.mozilla.org/r/87088/#review86620

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c7640c66a3a
Make sure OpenVR is installed before handling user inputs; r=kip

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6c7640c66a3a