1311761 - try, win32, win64 --artifact: AttributeError: 'NoneType' object has no attribute 'origin'

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

+++ This bug was initially created as a clone of Bug #1311431 +++

I believe Bug 1296530 is causing bustage with artifact builds on try on macosx64 and Windows.

Before Bug 1296530: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b58a190841d0d7bb889cad1a84d8a41d4b38623b -- only tier-2 mac jobs busted, status quo.

After Bug 1296530: https://treeherder.mozilla.org/#/jobs?repo=try&revision=588f010c6dd4fc9907391ceb61dbb695df2b6a07&selectedJob=29459920
> mozbuild.configure.options.InvalidOptionError: WINDOWSSDKDIR=c:/builds/moz2_slave/try-w32-0000000000000000000000/build/src/vs2015u3/SDK is not available in this configuration

Today, after Bug 1311069: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e336329351e5cf16f8a08342fc61806fc162f5cb

>09:17:05     INFO -  checking whether cross compiling... no
>09:17:05     INFO -  Traceback (most recent call last):
>09:17:05     INFO -    File "c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/>configure.py", line 107, in <module>
>09:17:05     INFO -      sys.exit(main(sys.argv))
>09:17:05     INFO -    File "c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/>configure.py", line 26, in main
>09:17:05     INFO -      sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
>09:17:05     INFO -    File "c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\python\m>ozbuild\mozbuild\configure\__init__.py", line 360, in run
>09:17:05     INFO -      func(*args)
>09:17:05     INFO -    File "c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\python\m>ozbuild\mozbuild\configure\__init__.py", line 403, in _value_for
>09:17:05     INFO -      return self._value_for_depends(obj, need_help_dependency)
>09:17:05     INFO -    File >"c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\python\mozbuild\mozbuild\util.py", >line 924, in method_call
>09:17:05     INFO -      cache[args] = self.func(instance, *args)
>09:17:05     INFO -    File "c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\python\m>ozbuild\mozbuild\configure\__init__.py", line 425, in _value_for_depends
>09:17:05     INFO -      return obj.result
>09:17:05     INFO -    File >"c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\python\mozbuild\mozbuild\util.py", >line 942, in __get__
>09:17:05     INFO -      setattr(instance, name, self.func(instance))
>09:17:05     INFO -    File "c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\python\m>ozbuild\mozbuild\configure\__init__.py", line 90, in result
>09:17:05     INFO -      return self.func(*resolved_args)
>09:17:05     INFO -    File "c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\python\m>ozbuild\mozbuild\configure\__init__.py", line 937, in wrapped
>09:17:05     INFO -      return new_func(*args, **kwargs)
>09:17:05     INFO -    File "c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/build/>moz.configure/init.configure", line 776, in all_configure_options
>09:17:05     INFO -      if (value.origin not in ('default', 'implied') and
>09:17:05     INFO -  AttributeError: 'NoneType' object has no attribute 'origin'

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1311761 - Fixup after bug 1311069.

Review commit: https://reviewboard.mozilla.org/r/87352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87352/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8803120 [details]
Bug 1311761 - Fixup after bug 1311069.

https://reviewboard.mozilla.org/r/87352/#review86396

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc577423948f
Fixup after bug 1311069. r=chmanchester

Comment 4

[Guilherme Lima]

Landed 22 hours ago https://hg.mozilla.org/mozilla-central/rev/fc577423948f