1312032 - Pause and resume a download may cause it to fail

Status: RESOLVED WORKSFORME

(Firefox :: Downloads Panel, defect)

Description

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

[Affected platforms]:

 Windows 10 x64
 Windows 10 x32
 Windows 8.1 x64
 Ubuntu 14.04 LTS
 Mac OS X 10.10.5

[Steps to reproduce]:

 1. Launch Firefox
 2. Download a large file (ex: https://www.ubuntu.com/download/desktop/thank-you?country=RO&version=16.04.1&architecture=amd64).
 3. Click Download Panel.
 4. Right click on downloaded item and toggle between Pause and Resume multiple times.

[Expected result]:

 The download resumes without any issues.

[Actual result]:

 The download fails.

[Additional notes]:

 a. This issue is reproducible 20%.
 b. Screen cast with the issue: https://dl.dropboxusercontent.com/u/109148197/Download%20panel/Download%20failed.mov .
 c. This is reproducible also by canceling and retrying a download.

Comment 1

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Drew, Paolo, I think we uplifted a few fixes in this area during Aurora50 cycle. Could you please investigate? I am not planning to block 50.0b9 build on this issue as I don't believe this is a recent regression since 50.0b8.

Comment 2

[Drew Willcoxon :adw]

Hi Ritu, this doesn't look related to the downloads blocking bugs I worked on, and I'm not working on the downloads panel right now but I think Paolo is, so I'll let him answer.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Thanks Drew! Hi Panos, this is a regression that was found by Softvision during 50.0b9 sign off. Could you please help find an owner who can quickly investigate and root cause? We are a week away from entering RC mode for 50. I would like help to better understand how severe this issue is and what would the risk of a fix be.

Comment 4

[Drew Willcoxon :adw]

Cristian, do you think you could find a regression range?

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Hi Ritu, Paolo is the best person to figure this one out, as he recently reviewed significant code changes in the downloads panel from the Taipei team. So if this is a recent regression, it is likely caused by one of those patches. I agree that this shouldn't block 50.0b9 and possibly even shipping 50, as it sounds like a rare event with an uncommon set of user actions to trigger it.

Comment 6

[:Paolo Amadini]

It's unlikely this is a recent regression, unless there were changes in the network layer.

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

I am unable to continue in investigating the regression range due to bug 1312706, the pause button now becomes inactive after the user  pauses and resumes the download once.

Comment 8

[:Paolo Amadini]

I've looked at bug 1312706 too, and I don't think they are regressions in Firefox. I have not been able to reproduce the issues described in these bugs, and I'm not aware of any code changes in the area.

This is more likely a server issue, or maybe, since the actual downloads from the Ubuntu mirrors occur over HTTP, you may be behind a company firewall or proxy that interferes with the connection.