1312164 - uncaught exception: 2147500033 react.js:1306:3, when starting new Responsive Design Mode

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[magicp]

Steps to Reproduce:
1. Start latest Nightly
2. Go to any sites (e.g. about:home)
3. Open DevTools > Browser Console (Ctrl+Shift+J)
4. Open DevTools > Responsive Design Mode (Ctrl+Shift+M)
5. Confirm error in Browser Console

Actural Results:
In step 4, the following errors occur...

uncaught exception: 2147500033  react.js:1306:3
uncaught exception: 2147500033  browser.xml:1270:13
this.webNavigation is null  browser.xml:880
TypeError: cannot use the given object as a weak map key  RemoteAddonsParent.jsm:1085:7
TypeError: win.gBrowser is undefined[Learn More]  ReaderParent.jsm:85:1

(I confimed these errors on Mac OS X 10.10.5, Ubuntu 16.04 and Windows 10)

Expected Results:
Start new Responsive Design Mode without errors

Comment 1

[magicp]

Regression range of "uncaught exception: 2147500033"

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c9d87bca44d8a62e5ed2682bc53c2328da74e211&tochange=144625d6fafa6bd2870f9d886245e878e591b2e1

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks for filing, I have noticed these new errors ("uncaught exception: 2147500033") appearing too.  (The other errors are existing noise and are tracked by bug 1273721.)

Added to the RDM backlog and blocking RDM past Nightly for now until I understand the cause better.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1312164 - Stop checking for apps with isolated mozbrowser.

Since the apps service always returns error codes now, there's no need to ask if
any apps are installed prior to allowing non-isolated mozbrowser frames.  This
change prevents an error from being logged due to the thrown exception from the
apps service.

Review commit: https://reviewboard.mozilla.org/r/87860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/87860/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebd6e36df38a2643c9786094b8cf5cf5e8c1db81

Comment 5

[(no longer active)]

Comment on attachment 8803733 [details]
Bug 1312164 - Stop checking for apps with isolated mozbrowser.

https://reviewboard.mozilla.org/r/87860/#review87028

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ac01f1ba4f3
Stop checking for apps with isolated mozbrowser. r=Ehsan

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8ac01f1ba4f3

Comment 8

[magicp]

verified in latest Nightly on Windows, Mac OS X and Linux. Thanks!

Nightly Build (20161026030210)
Windows 10, Mac OS X 10.10.5 and Ubuntu 16.04