Closed Bug 1312328 Opened 7 years ago Closed 6 years ago

Remove CSS pref "layout.css.variables.enabled"

Categories

(Core :: CSS Parsing and Computation, defect, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox52 --- wontfix
firefox55 --- fixed

People

(Reporter: xidorn, Assigned: TYLin)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1312328 - Remove CSS variables preference "layout.css.variables.enabled".
59 bytes, text/x-review-board-request
xidorn
: review+
Details 
CSS Variables has been enabled since Firefox 31. We should remove this pref.

Even if we do not remove it, it would not control CSS Variables in stylo.
Priority: -- → P3
Mass wontfix for bugs affecting firefox 52.
status-firefox52: affected → wontfix
Comment on attachment 8855594 [details]
Bug 1312328 - Remove CSS variables preference "layout.css.variables.enabled".

https://reviewboard.mozilla.org/r/127448/#review130164

Looks good, thanks.
Attachment #8855594 - Flags: review?(xidorn+moz) → review+
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07435005e74a
Remove CSS variables preference "layout.css.variables.enabled". r=xidorn
https://hg.mozilla.org/mozilla-central/rev/07435005e74a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
I've added a note to the relevant browser compat info about this
https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_variables#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/CSS/var#Browser_compatibility

I've also added a note to the Fx55 rel notes:
https://developer.mozilla.org/en-US/Firefox/Releases/55#CSS

Let me know if you think that covers it, or if anything else is needed. thanks!
Keywords: dev-doc-needed → dev-doc-complete
Chris, the documentation changes look good to me. Thanks.
You need to log in before you can comment on or make changes to this bug.